Home » Mailing list archives » linux-kernel » 2008 » July » 5

[PATCH 12/52] jbd2: Add commit time into the commit block

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Theodore Ts'o <tytso@...>
To: Ext4 Developers List <linux-ext4@...>, Linux Kernel Developers List <linux-kernel@...>
Cc: Theodore Ts'o <tytso@...>
Subject: [PATCH 12/52] jbd2: Add commit time into the commit block
Date: Saturday, July 5, 2008 - 1:35 pm

Carlo Wood has demonstrated that it's possible to recover deleted
files from the journal.  Something that will make this easier is if we
can put the time of the commit into commit block.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
 fs/jbd2/commit.c     |    3 +++
 include/linux/jbd2.h |    2 ++
 2 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c
index a2ed72f..92b6ac3 100644
--- a/fs/jbd2/commit.c
+++ b/fs/jbd2/commit.c
@@ -112,6 +112,7 @@ static int journal_submit_commit_record(journal_t *journal,
 	struct buffer_head *bh;
 	int ret;
 	int barrier_done = 0;
+	struct timespec now = current_kernel_time();
 
 	if (is_journal_aborted(journal))
 		return 0;
@@ -126,6 +127,8 @@ static int journal_submit_commit_record(journal_t *journal,
 	tmp->h_magic = cpu_to_be32(JBD2_MAGIC_NUMBER);
 	tmp->h_blocktype = cpu_to_be32(JBD2_COMMIT_BLOCK);
 	tmp->h_sequence = cpu_to_be32(commit_transaction->t_tid);
+	tmp->h_commit_sec = cpu_to_be64(now.tv_sec);
+	tmp->h_commit_nsec = cpu_to_be32(now.tv_nsec);
 
 	if (JBD2_HAS_COMPAT_FEATURE(journal,
 				    JBD2_FEATURE_COMPAT_CHECKSUM)) {
diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
index d147f0f..ec9cadf 100644
--- a/include/linux/jbd2.h
+++ b/include/linux/jbd2.h
@@ -168,6 +168,8 @@ struct commit_header {
 	unsigned char   h_chksum_size;
 	unsigned char 	h_padding[2];
 	__be32 		h_chksum[JBD2_CHECKSUM_BYTES];
+	__be64		h_commit_sec;
+	__be32		h_commit_nsec;
 };
 
 /*
-- 
1.5.6.rc3.1.g36b7.dirty

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 08/52] ext4: miscellaneous error checks and coding cl..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 09/52] ext4: remove double definitions of xattr macros, Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 10/52] ext4: Rename read_block_bitmap() to ext4_read_..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 11/52] ext4: Remove unused variable from ext4_show_op..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 12/52] jbd2: Add commit time into the commit block, Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 13/52] ext4: New inode allocation for FLEX_BG meta-da..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 14/52] jbd2: fix race between jbd2_journal_try_to_fre..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 15/52] ext4: remove redundant code in ext4_fill_super(), Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 16/52] ext4: remove quota allocation when ext4_mb_new..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 17/52] ext4: Update i_disksize properly when allocati..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 18/52] ext4: return error when calling ext4_ext_split..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 19/52] ext4: Make ext4_ext_find_extent fills ext_path..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)