Home » Mailing list archives » linux-kernel » 2008 » July » 4

[PATCH] [5/9] MCE: Rename mce_dont_init on 64bit to mce_disabled

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andi Kleen <andi@...>
To: <masbock@...>, <x86@...>, <linux-kernel@...>
Subject: [PATCH] [5/9] MCE: Rename mce_dont_init on 64bit to mce_disabled
Date: Friday, July 4, 2008 - 5:20 pm

This way they are the same between 32bit and 64bit and no special
cases needed. The semantics were always the same.

Signed-off-by: Andi Kleen <ak@linux.intel.com>

---
 arch/x86/kernel/cpu/mcheck/mce_64.c |    8 ++++----
 include/asm-x86/mce.h               |    2 --
 2 files changed, 4 insertions(+), 6 deletions(-)

Index: linux/arch/x86/kernel/cpu/mcheck/mce_64.c
===================================================================
--- linux.orig/arch/x86/kernel/cpu/mcheck/mce_64.c
+++ linux/arch/x86/kernel/cpu/mcheck/mce_64.c
@@ -35,7 +35,7 @@
 
 atomic_t mce_entry;
 
-static int mce_dont_init;
+int mce_disabled __cpuinitdata;
 
 /*
  * Tolerant levels:
@@ -535,7 +535,7 @@ void __cpuinit mcheck_init(struct cpuinf
 
 	mce_cpu_quirks(c);
 
-	if (mce_dont_init ||
+	if (mce_disabled ||
 	    cpu_test_and_set(smp_processor_id(), mce_cpus) ||
 	    !mce_available(c))
 		return;
@@ -722,7 +722,7 @@ void __init restart_mce(void)
  */
 static int __init mcheck_disable(char *str)
 {
-	mce_dont_init = 1;
+	mce_disabled = 1;
 	return 1;
 }
 
@@ -734,7 +734,7 @@ static int __init mcheck_disable(char *s
 static int __init mcheck_enable(char *str)
 {
 	if (!strcmp(str, "off"))
-		mce_dont_init = 1;
+		mce_disabled = 1;
 	else if (!strcmp(str, "bootlog") || !strcmp(str,"nobootlog"))
 		mce_bootlog = str[0] == 'b';
 	else if (isdigit(str[0]))
Index: linux/include/asm-x86/mce.h
===================================================================
--- linux.orig/include/asm-x86/mce.h
+++ linux/include/asm-x86/mce.h
@@ -84,9 +84,7 @@ struct mce_log {
 
 #ifdef __KERNEL__
 
-#ifdef CONFIG_X86_32
 extern int mce_disabled;
-#else /* CONFIG_X86_32 */
 
 #include <asm/atomic.h>
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] [0/9] Use 64bit x86 machine check code for 32bit too, Andi Kleen, (Fri Jul 4, 5:20 pm)
Re: [PATCH] [0/9] Use 64bit x86 machine check code for 32bit..., H. Peter Anvin, (Mon Jul 7, 5:26 pm)
Re: [PATCH] [0/9] Use 64bit x86 machine check code for 32bit..., Andi Kleen, (Mon Jul 7, 6:09 pm)
Re: [PATCH] [0/9] Use 64bit x86 machine check code for 32bit..., H. Peter Anvin, (Mon Jul 7, 5:37 pm)
Re: [PATCH] [0/9] Use 64bit x86 machine check code for 32bit..., Max Asbock, (Mon Jul 7, 8:00 pm)
Re: [PATCH] [0/9] Use 64bit x86 machine check code for 32bit..., Andi Kleen, (Mon Jul 7, 8:25 pm)
[PATCH] [1/9] MCE: Make 64bit mce code 32bit clean, Andi Kleen, (Fri Jul 4, 5:20 pm)
[PATCH] [9/9] MCE: Use 64bit machine check code on 32bit, Andi Kleen, (Fri Jul 4, 5:20 pm)
Re: [PATCH] [9/9] MCE: Use 64bit machine check code on 32bit, Bert Wesarg, (Sat Jul 5, 5:50 am)
Re: [PATCH] [9/9] MCE: Use 64bit machine check code on 32bit, Andi Kleen, (Sat Jul 5, 5:54 am)
Re: [PATCH] [9/9] MCE: Use 64bit machine check code on 32bit, Bert Wesarg, (Sat Jul 5, 6:17 am)
Re: [PATCH] [9/9] MCE: Use 64bit machine check code on 32bit, Andi Kleen, (Sat Jul 5, 6:55 am)
Re: [PATCH] [9/9] MCE: Use 64bit machine check code on 32bit, Pavel Machek, (Thu Jul 10, 2:23 pm)
[PATCH] [8/9] MCE: Remove oops_begin() use in 64bit machine ..., Andi Kleen, (Fri Jul 4, 5:20 pm)
[PATCH] [3/9] MCE: Port K7 bank 0 quirk to 64bit mce code, Andi Kleen, (Fri Jul 4, 5:20 pm)
[PATCH] [7/9] MCE: Remove machine check handler idle notify ..., Andi Kleen, (Fri Jul 4, 5:20 pm)
[PATCH] [6/9] MCE: Provide exit_idle dummy functions for 32b..., Andi Kleen, (Fri Jul 4, 5:20 pm)
[PATCH] [5/9] MCE: Rename mce_dont_init on 64bit to mce_disa..., Andi Kleen, (Fri Jul 4, 5:20 pm)
[PATCH] [4/9] MCE: Call 64bit machine check through a call v..., Andi Kleen, (Fri Jul 4, 5:20 pm)
[PATCH] [2/9] MCE: Implement the PPro bank 0 quirk in the 64..., Andi Kleen, (Fri Jul 4, 5:20 pm)