Re: [PATCH] fix build error of driver/mfd/tc6393xb.c

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Takashi Iwai <tiwai@...>

To: Dmitry Baryshkov <dbaryshkov@...>

Cc: Stephen Rothwell <sfr@...>, David Brownell <david-b@...>, <linux-next@...>, LKML <linux-kernel@...>

Subject: Re: [PATCH] fix build error of driver/mfd/tc6393xb.c

Date: Friday, July 4, 2008 - 9:59 am

At Fri, 4 Jul 2008 17:22:35 +0400,
Dmitry Baryshkov wrote:
quoted text> 
> On Fri, Jul 04, 2008 at 02:59:18PM +0200, Takashi Iwai wrote:
> > At Fri, 4 Jul 2008 16:42:56 +0400,
> > Dmitry Baryshkov wrote:
> > > 
> > > On Fri, Jul 04, 2008 at 02:04:30PM +0200, Takashi Iwai wrote:
> > > > At Fri, 4 Jul 2008 15:47:55 +0400,
> > > > Dmitry Baryshkov wrote:
> > > > > 
> > > > > On Fri, Jul 04, 2008 at 01:20:42PM +0200, Takashi Iwai wrote:
> > > > > > Fix the build of tc6393xb  due to missing definition of struct
> > > > > > gpio_chip.
> > > > > > 
> > > > > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > > > > > 
> > > > > > ---
> > > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > > > > > index 9f93c29..2981da4 100644
> > > > > > --- a/drivers/mfd/Kconfig
> > > > > > +++ b/drivers/mfd/Kconfig
> > > > > > @@ -44,7 +44,7 @@ config HTC_PASIC3
> > > > > >  
> > > > > >  config MFD_TC6393XB
> > > > > >  	bool "Support Toshiba TC6393XB"
> > > > > > -	depends on HAVE_GPIO_LIB
> > > > > > +	depends on HAVE_GPIO_LIB && GENERIC_GPIO
> > > > > >  	select MFD_CORE
> > > > > >  	help
> > > > > >  	  Support for Toshiba Mobile IO Controller TC6393XB
> > > > > 
> > > > > Which configuration does provide HAVE_GPIO_LIB but not GENERIC_GPIO?
> > > > 
> > > > The below is the config with which I got the error.
> > > 
> > > The proper fix probably is to make PPC_MPC5200_GPIO also select
> > > GENERIC_GPIO. I don't think that building GPIO_LIB w/o GENERIC_GPIO
> > > should be supported.
> > 
> > [Added David to Cc]
> > 
> > Then HAVE_GPIO_LIB should depend on GENERIC_GPIO.
> > Or, linux/gpio.h should be fixed so that the code can be built
> > properly without GENERIC_GPIO.
> 
> IIRC selected symbols don't propagate their depends.

Then HAVE_GPIO_LIB selects GENERIC_GPIO.  Right now, it's a missing
dependency.

quoted text> Also linux/gpio.h don't have anything in common with HAVE_GPIO_LIB.

That's another side of the problem.


Takashi
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] fix build error of driver/mfd/tc6393xb.c, Takashi Iwai, (Fri Jul 4, 7:20 am)

Re: [PATCH] fix build error of driver/mfd/tc6393xb.c, Dmitry Baryshkov, (Fri Jul 4, 7:47 am)

Re: [PATCH] fix build error of driver/mfd/tc6393xb.c, Takashi Iwai, (Fri Jul 4, 8:04 am)

Re: [PATCH] fix build error of driver/mfd/tc6393xb.c, Dmitry Baryshkov, (Fri Jul 4, 8:42 am)

Re: [PATCH] fix build error of driver/mfd/tc6393xb.c, Takashi Iwai, (Fri Jul 4, 8:59 am)

Re: [PATCH] fix build error of driver/mfd/tc6393xb.c, David Brownell, (Fri Jul 4, 12:50 pm)

Re: [PATCH] fix build error of driver/mfd/tc6393xb.c, Dmitry Baryshkov, (Fri Jul 4, 9:22 am)

Re: [PATCH] fix build error of driver/mfd/tc6393xb.c, Takashi Iwai, (Fri Jul 4, 9:59 am)

Re: [PATCH] fix build error of driver/mfd/tc6393xb.c, David Brownell, (Fri Jul 4, 12:52 pm)

Re: [PATCH] fix build error of driver/mfd/tc6393xb.c, Dmitry Baryshkov, (Fri Jul 4, 10:22 am)

Re: [PATCH] fix build error of driver/mfd/tc6393xb.c, Takashi Iwai, (Fri Jul 4, 11:24 am)

Re: [PATCH] fix build error of driver/mfd/tc6393xb.c, David Brownell, (Fri Jul 4, 12:54 pm)

Re: [PATCH] fix build error of driver/mfd/tc6393xb.c, Dmitry Baryshkov, (Sat Jul 5, 4:31 am)

Re: [PATCH] fix build error of driver/mfd/tc6393xb.c, David Brownell, (Sat Jul 5, 1:13 pm)

Re: [PATCH] fix build error of driver/mfd/tc6393xb.c, Takashi Iwai, (Mon Jul 7, 12:09 pm)

Re: [PATCH] fix build error of driver/mfd/tc6393xb.c, David Brownell, (Mon Jul 7, 12:19 pm)

Re: [PATCH] fix build error of driver/mfd/tc6393xb.c, Takashi Iwai, (Mon Jul 7, 12:23 pm)

Re: [PATCH] fix build error of driver/mfd/tc6393xb.c, Dmitry Baryshkov, (Fri Jul 4, 11:27 am)

Re: [PATCH] fix build error of driver/mfd/tc6393xb.c, Takashi Iwai, (Fri Jul 4, 12:47 pm)

Navigation

Popular discussions


linux-kernel:
david	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Justin C. Sherrill	Mailing list archive
Ingo Molnar	[patch 08/13] syslets: x86, add move_user_context() method
git:

linux-netdev:
Steven Rostedt	Re: -rt scheduling: wakeup bug?
David Miller	[GIT]: Networking
Jarek Poplawski	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
openbsd-misc:

Colocation donated by:

Online users

Syndicate