memcg: lru scan fix (Was: 2.6.26-rc8-mm1

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>
Cc: <linux-kernel@...>, <linux-mm@...>, kosaki.motohiro@jp.fujitsu.com <kosaki.motohiro@...>, riel@redhat.com <riel@...>
Date: Friday, July 4, 2008 - 5:02 am

Since rc5-mm3, memcg easily goes into OOM when limit was low.
This is a fix to split-lru to fix OOM.

==
Under memcg, active anon tend not to go to inactive anon.
This will cause OOM in memcg easily when tons of anon was used at once.
This check was lacked in split-lru.

Signed-off-by:KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

Index: test-2.6.26-rc8-mm1/mm/vmscan.c
===================================================================
--- test-2.6.26-rc8-mm1.orig/mm/vmscan.c
+++ test-2.6.26-rc8-mm1/mm/vmscan.c
@@ -1501,6 +1501,8 @@ static unsigned long shrink_zone(int pri
 	 */
 	if (scan_global_lru(sc) && inactive_anon_is_low(zone))
 		shrink_active_list(SWAP_CLUSTER_MAX, zone, sc, priority, 0);
+	else if (!scan_global_lru(sc))
+		shrink_active_list(SWAP_CLUSTER_MAX, zone, sc, priority, 0);
 
 	throttle_vm_writeout(sc->gfp_mask);
 	return nr_reclaimed;

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.26-rc8-mm1, Andrew Morton, (Thu Jul 3, 5:02 am)
Re: 2.6.26-rc8-mm1 - Missing AC97 power save Kconfig?, Randy Dunlap, (Wed Jul 9, 6:05 pm)
Re: 2.6.26-rc8-mm1: unable to mount nfs shares, Mariusz Kozlowski, (Fri Jul 4, 6:49 pm)
Re: 2.6.26-rc8-mm1: unable to mount nfs shares, Andrew Morton, (Fri Jul 4, 7:07 pm)
[PATCH] memcg: handle shmem's swap cache (Was 2.6.26-rc8-mm1, KAMEZAWA Hiroyuki, (Fri Jul 4, 5:09 am)
memcg: lru scan fix (Was: 2.6.26-rc8-mm1, KAMEZAWA Hiroyuki, (Fri Jul 4, 5:02 am)
Re: memcg: lru scan fix (Was: 2.6.26-rc8-mm1, Rik van Riel, (Fri Jul 4, 3:16 pm)
Re: memcg: lru scan fix (Was: 2.6.26-rc8-mm1, Andrew Morton, (Fri Jul 4, 3:24 pm)
Re: memcg: lru scan fix (Was: 2.6.26-rc8-mm1, KAMEZAWA Hiroyuki, (Fri Jul 4, 11:59 pm)
Question: split-lur // Re: 2.6.26-rc8-mm1, KAMEZAWA Hiroyuki, (Thu Jul 3, 10:48 pm)
Re: [BUILD-FAILURE] 2.6.26-rc8-mm1 - x86 - __ptep_modify_pro..., Jeremy Fitzhardinge, (Thu Jul 3, 2:00 pm)
[bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", KOSAKI Motohiro, (Thu Jul 3, 7:59 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", David Woodhouse, (Fri Jul 4, 10:13 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Arjan van de Ven, (Fri Jul 4, 4:42 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Arjan van de Ven, (Fri Jul 4, 4:59 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", David Woodhouse, (Fri Jul 4, 10:31 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", maximilian attems, (Fri Jul 4, 10:24 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", maximilian attems, (Sat Jul 5, 6:26 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Hannes Reinecke, (Fri Jul 4, 10:39 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", David Woodhouse, (Fri Jul 4, 10:42 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Olivier Galibert, (Fri Jul 4, 7:13 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Olivier Galibert, (Sat Jul 5, 6:53 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Olivier Galibert, (Sat Jul 5, 8:02 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Christoph Hellwig, (Sat Jul 5, 1:13 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Christoph Hellwig, (Sun Jul 6, 6:02 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Olivier Galibert, (Sat Jul 5, 10:44 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", David Woodhouse, (Sat Jul 5, 11:10 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Henrique de Moraes Holschuh..., (Fri Jul 4, 7:58 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Henrique de Moraes Holschuh..., (Fri Jul 4, 11:52 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Henrique de Moraes Holschuh..., (Sat Jul 5, 9:08 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", David Woodhouse, (Fri Jul 4, 10:37 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Mikael Pettersson, (Thu Jul 3, 10:31 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Rafael J. Wysocki, (Thu Jul 3, 5:42 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Rafael J. Wysocki, (Thu Jul 3, 5:52 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Rafael J. Wysocki, (Thu Jul 3, 6:27 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Rafael J. Wysocki, (Thu Jul 3, 4:52 pm)