Re: [patch v3] splice: fix race with page invalidation

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Evgeniy Polyakov
Date: Thursday, July 31, 2008 - 6:29 am

On Thu, Jul 31, 2008 at 01:33:50PM +0100, Jamie Lokier (jamie@shareable.org) wrote:

It depends... COW can DoS the system: consider attacker who sends a
page, writes there, sends again and so on in lots of threads. Depending
on link capacity eventually COW will eat the whole RAM.


<q>
Benchmark of the 100 1MB files transfer (files are in VFS already) using
sync sendfile() against aio_sendfile_path() shows about 10MB/sec
performance win (78 MB/s vs 66-72 MB/s over 1 Gb network, sendfile
sending server is one-way AMD Athlong 64 3500+) for aio_sendfile_path().
</q>

So, it was really better that sync sendfile :)


That's how all AIO should work of course. We are getting into a bit of
offtopic, but aio_sendfile() worked that way as long as syslets,
although the former did allocate some structures before trying to send
the data.


Looks scary :)
Thread allocation in userspace is rather costly operations compared to
syslet threads in kernelspace. But depending on IO pattern this may or
may not be a noticeble factor... It requires testing and numbers.

-- 
	Evgeniy Polyakov
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Wed Jul 30, 2:43 am)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Wed Jul 30, 10:00 am)
Re: [patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Wed Jul 30, 10:29 am)
Re: [patch v3] splice: fix race with page invalidation, Jens Axboe, (Wed Jul 30, 10:54 am)
Re: [patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Wed Jul 30, 11:32 am)
Re: [patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Wed Jul 30, 11:43 am)
Re: [patch v3] splice: fix race with page invalidation, Jens Axboe, (Wed Jul 30, 12:45 pm)
Re: [patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Wed Jul 30, 1:05 pm)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Wed Jul 30, 1:13 pm)
Re: [patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Wed Jul 30, 1:45 pm)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Wed Jul 30, 1:51 pm)
Re: [patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Wed Jul 30, 2:16 pm)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Wed Jul 30, 2:22 pm)
Re: [patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Wed Jul 30, 2:46 pm)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Wed Jul 30, 2:56 pm)
Re: [patch v3] splice: fix race with page invalidation, Jamie Lokier, (Wed Jul 30, 5:11 pm)
Re: [patch v3] splice: fix race with page invalidation, Jamie Lokier, (Wed Jul 30, 5:42 pm)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Wed Jul 30, 5:51 pm)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Wed Jul 30, 5:54 pm)
Re: [patch v3] splice: fix race with page invalidation, Nick Piggin, (Wed Jul 30, 7:16 pm)
Re: [patch v3] splice: fix race with page invalidation, Jamie Lokier, (Wed Jul 30, 11:12 pm)
Re: [patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Thu Jul 31, 12:30 am)
Re: [patch v3] splice: fix race with page invalidation, Evgeniy Polyakov, (Thu Jul 31, 3:26 am)
Re: [patch v3] splice: fix race with page invalidation, Jamie Lokier, (Thu Jul 31, 5:33 am)
Re: [patch v3] splice: fix race with page invalidation, Nick Piggin, (Thu Jul 31, 5:49 am)
Re: [patch v3] splice: fix race with page invalidation, Nick Piggin, (Thu Jul 31, 5:59 am)
Re: [patch v3] splice: fix race with page invalidation, Evgeniy Polyakov, (Thu Jul 31, 6:29 am)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Thu Jul 31, 9:34 am)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Thu Jul 31, 9:56 am)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Thu Jul 31, 10:00 am)
Re: [patch v3] splice: fix race with page invalidation, Jamie Lokier, (Thu Jul 31, 10:21 am)
Re: [patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Thu Jul 31, 11:13 am)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Thu Jul 31, 11:54 am)
Re: [patch v3] splice: fix race with page invalidation, Nick Piggin, (Thu Jul 31, 6:22 pm)
Re: [patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Fri Aug 1, 11:28 am)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Fri Aug 1, 11:32 am)
Re: [patch v3] splice: fix race with page invalidation, Jamie Lokier, (Mon Aug 4, 8:29 am)
Re: [patch v3] splice: fix race with page invalidation, Michael Kerrisk, (Sun Aug 10, 8:22 pm)