Home » Mailing list archives » linux-kernel » 2008 » July » 31

Re: [PATCH] serial: change remove NR_IRQS in 8250.c

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Eric W. Biederman
Subject: Re: [PATCH] serial: change remove NR_IRQS in 8250.c
Date: Thursday, July 31, 2008 - 4:50 am

> replace

Could you size this array by NR_UARTS (our worst case usage)
and place irq_no in struct irq_info?

Also you want to hold irq_info->lock when you set or clear irq_no.
Just to be on the safe side.  I expect we can avoid clearing the irq_no
in the irq_lists and prevent a few more races from being a possibility.

Eric
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] x86: 64bit support more than 256 irq v2, Yinghai Lu, (Tue Jul 29, 2:14 pm)
Re: [PATCH] x86: 64bit support more than 256 irq v2, Yinghai Lu, (Tue Jul 29, 3:16 pm)
Re: [PATCH] x86: 64bit support more than 256 irq v2, Eric W. Biederman, (Tue Jul 29, 4:22 pm)
RFC [PATCH] x86: introduce nr_irqs for 64bit, Yinghai Lu, (Tue Jul 29, 9:38 pm)
Re: RFC [PATCH] x86: introduce nr_irqs for 64bit, Ingo Molnar, (Wed Jul 30, 3:09 am)
[PATCH] x86: introduce nr_irqs for 64bit v2, Yinghai Lu, (Wed Jul 30, 3:11 am)
Re: RFC [PATCH] x86: introduce nr_irqs for 64bit, Yinghai Lu, (Wed Jul 30, 3:16 am)
Re: RFC [PATCH] x86: introduce nr_irqs for 64bit, Mike Travis, (Wed Jul 30, 5:58 am)
[PATCH 0/7] dyn_array support, Yinghai Lu, (Wed Jul 30, 12:10 pm)
[PATCH 2/7] x86: introduce nr_irqs for 64bit v3, Yinghai Lu, (Wed Jul 30, 12:13 pm)
[PATCH 5/7] pci: make irq2_iommu to use dyn_array, Yinghai Lu, (Wed Jul 30, 12:16 pm)
[PATCH 7/7] x86: make 64bit support dyn_array, Yinghai Lu, (Wed Jul 30, 12:18 pm)
[PATCH 1/7] x86: 64bit support more than 256 irq v1, Yinghai Lu, (Wed Jul 30, 12:27 pm)
[PATCH 3/7] add dyn_array support, Yinghai Lu, (Wed Jul 30, 12:37 pm)
[PATCH 6/7] irq: make irq_desc to use dyn_array, Yinghai Lu, (Wed Jul 30, 12:40 pm)
[PATCH 4/7] random: make irq_timer_state to use dyn_array, Yinghai Lu, (Wed Jul 30, 12:40 pm)
[PATCH 0/3] dyn_array support #2, Yinghai Lu, (Wed Jul 30, 9:09 pm)
[PATCH 1/3] serial: change irq_lists to use dyn_array, Yinghai Lu, (Wed Jul 30, 9:10 pm)
[PATCH 2/3] add per_cpu_dyn_array support, Yinghai Lu, (Wed Jul 30, 9:11 pm)
[PATCH 3/3] irq: make irqs in kernel stat use per_cpu_dyn_ ..., Yinghai Lu, (Wed Jul 30, 9:12 pm)
Re: [PATCH 1/3] serial: change irq_lists to use dyn_array, Eric W. Biederman, (Wed Jul 30, 10:58 pm)
[PATCH] serial: change remove NR_IRQS in 8250.c, Yinghai Lu, (Thu Jul 31, 1:26 am)
[PATCH] x86 remove irq_vectors_limit.h, Yinghai Lu, (Thu Jul 31, 3:14 am)
Re: [PATCH] serial: change remove NR_IRQS in 8250.c, Eric W. Biederman, (Thu Jul 31, 4:50 am)
Re: [PATCH] serial: change remove NR_IRQS in 8250.c, Alan Cox, (Thu Jul 31, 6:57 am)
Re: [PATCH 0/3] dyn_array support #2, Mike Travis, (Thu Jul 31, 9:32 am)
Re: [PATCH] serial: change remove NR_IRQS in 8250.c, Eric W. Biederman, (Thu Jul 31, 11:10 am)
Re: [PATCH 0/3] dyn_array support #2, Yinghai Lu, (Thu Jul 31, 11:21 am)
Re: [PATCH 0/3] dyn_array support #2, Peter Zijlstra, (Thu Jul 31, 2:51 pm)
Re: [PATCH 0/3] dyn_array support #2, Yinghai Lu, (Thu Jul 31, 3:07 pm)
Re: [PATCH 0/3] dyn_array support #2, Eric W. Biederman, (Thu Jul 31, 3:14 pm)
Re: [PATCH 0/3] dyn_array support #2, Yinghai Lu, (Thu Jul 31, 3:25 pm)
Re: [PATCH] serial: change remove NR_IRQS in 8250.c, Alan Cox, (Thu Jul 31, 4:15 pm)
Re: [PATCH] serial: change remove NR_IRQS in 8250.c, Yinghai Lu, (Thu Jul 31, 8:20 pm)
Re: [PATCH 0/3] dyn_array support #2, Yinghai Lu, (Thu Jul 31, 8:52 pm)
Re: [PATCH 0/7] dyn_array support, Eric W. Biederman, (Fri Aug 1, 1:13 pm)