login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
July
»
31
Re: [PATCH] ide-cd: fix endianity for the error message in cdrom_read_capacity
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From: Borislav Petkov
Subject:
Re: [PATCH] ide-cd: fix endianity for the error message in cdrom_read_capacity
Date: Wednesday, July 30, 2008 - 8:32 pm
On Wed, Jul 30, 2008 at 01:58:36PM -0700, Greg KH wrote:
quoted text
> On Wed, Jul 30, 2008 at 09:12:57PM +0200, Borislav Petkov wrote: > > On Wed, Jul 30, 2008 at 09:33:28AM -0700, Greg KH wrote: > > > On Wed, Jul 30, 2008 at 10:52:50AM +0200, Boris Petkov wrote: > > > > On Wed, Jul 30, 2008 at 10:18 AM, Andrew Morton > > > > <akpm@linux-foundation.org> wrote: > > > > > On Wed, 30 Jul 2008 10:10:06 +0200 Petr Tesarik <ptesarik@suse.cz> wrote: > > > > > > > > > >> Resent because of a typo in the LKML address. :( > > > > > > > > > > Thanks. > > > > > > > > > >> > > > > >> Aesthetic regards aside, commit e8e7b9eb11c34ee18bde8b7011af41938d1ad667 > > > > >> still leaves a bug in the error message, because it uses the unconverted > > > > >> big-endian value for printk. > > > > >> > > > > >> Fix this by using a local variable in machine byte order. The result is > > > > >> correct, more readable, and also produces slightly shorter code on i386. > > > > >> > > > > >> Cc: Jens Axboe <jens.axboe@oracle.com> > > > > >> Cc: Jan Kara <jack@suse.cz> > > > > >> Signed-off-by: Petr Tesarik <ptesarik@suse.cz> > > > > > > > > I definitely like this one better, thanks. > > > > > > > > Acked-by: Borislav Petkov <petkovbb@gmail.com> > > > > > > > > > > > > > > > > > > Bart owns this patch now. It got lost for a month and it has already > > > > > been fixed twice and it is also on the route to 2.6.25.x and 2.6.26.x, > > > > > so it'll get complicated. Not a happy little patch. > > > > > > > > Greg, can you please apply this one on top of -stable. > > > > > > What one? Do you have a git commit id? > > > > Oh, sorry about that. Ok, you should have in both 2.6.25 and .26 the patch with > > upstream commit id e8e7b9eb11c34ee18bde8b7011af41938d1ad667. I rediffed the new > > one on top, here's the 2.6.26 version, the 2.6.25 one follows. > > I need the patch id when this goes to Linus, in his tree. If you add > "cc: stable <stable@kernel.org>" to the signed-off-by area, when it gets > into Linus's tree, we will be automatically notified of it.
Bart already did that. It's now in his pata-2.6 tree. -- Regards/Gruss, Boris. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH] ide-cd: fix endianity for the error message in cdr ...
, Petr Tesarik
, (Wed Jul 30, 1:10 am)
Re: [PATCH] ide-cd: fix endianity for the error message in ...
, Andrew Morton
, (Wed Jul 30, 1:18 am)
Re: [PATCH] ide-cd: fix endianity for the error message in ...
, Boris Petkov
, (Wed Jul 30, 1:52 am)
Re: [PATCH] ide-cd: fix endianity for the error message in ...
, Greg KH
, (Wed Jul 30, 9:33 am)
Re: [PATCH] ide-cd: fix endianity for the error message in ...
, Borislav Petkov
, (Wed Jul 30, 12:12 pm)
Re: [PATCH] ide-cd: fix endianity for the error message in ...
, Bartlomiej Zolnierki ...
, (Wed Jul 30, 12:25 pm)
Re: [PATCH] ide-cd: fix endianity for the error message in ...
, Borislav Petkov
, (Wed Jul 30, 12:27 pm)
Re: [PATCH] ide-cd: fix endianity for the error message in ...
, Andrew Morton
, (Wed Jul 30, 1:02 pm)
Re: [PATCH] ide-cd: fix endianity for the error message in ...
, Greg KH
, (Wed Jul 30, 1:58 pm)
Re: [PATCH] ide-cd: fix endianity for the error message in ...
, Bartlomiej Zolnierki ...
, (Wed Jul 30, 2:23 pm)
Re: [PATCH] ide-cd: fix endianity for the error message in ...
, Borislav Petkov
, (Wed Jul 30, 8:32 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
David Howells
[PATCH] KEYS: Use the variable 'key' in keyctl_describe_key()
Greg Kroah-Hartman
[PATCH 17/36] sysdev: detect multiple driver registrations
Andy Walls
Re: [PATCH 11/32] v4l/cx18: update workqueue usage
Thomas Gleixner
[patch -mm 19/28] x86_64: Use generic cmos update
Greg Kroah-Hartman
[PATCH 09/36] driver core: register_memory/unregister_memory clean ups and bugfix
git
:
Mark Junker
git on MacOSX and files with decomposed utf-8 file names
Johannes Schindelin
Re: error: cannot lock ref 'refs/remotes/origin/*'
Pat Thoyts
[PATCH] git-gui: use themed tk widgets with Tk 8.5
Michael Witten
Re: 'git gc --aggressive' effectively unusable
Johannes Schindelin
Re: [PATCH 2/2] git-svn: support fetch with autocrlf on
linux-netdev
:
David Miller
Re: [PATCH 32/53] netns xfrm: finding policy in netns
Jean-Louis Dupond
Re: tg3 driver not advertising 1000mbit
Jan Engelhardt
[PATCH 1/3] net: tcp: make hybla selectable as default congestion module
Daniel Schaffrath
Re: tcp bw in 2.6
Matt Mackall
Re: [regression] nf_iterate(), BUG: unable to handle kernel NULL pointer dereference
git-commits-head
:
Linux Kernel Mailing List
V4L/DVB (8018): Add em2860 chip ID
Linux Kernel Mailing List
ipv6: fix an oops when force unload ipv6 module
Linux Kernel Mailing List
tracing: protect reader of cmdline output
Linux Kernel Mailing List
imxfb: Fix margin settings
Linux Kernel Mailing List
V4L/DVB (10826): cx88: Add IR support to pcHDTV HD3000 & HD5500
openbsd-misc
:
Stas Miasnikou
Re: Another question: device naming convention
Darrin Chandler
Re: That whole "Linux stealing our code" thing
Community First Financial
Teacher A+ Loan
Jan Stary
Re: audio recording levels
Andrej Elizarov
Re: Web Browsers
Colocation donated by:
Syndicate