Home » Mailing list archives » linux-kernel » 2008 » July » 30

[patch 26/29] ath5k: dont enable MSI, we cannot handle it yet

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Greg KH
Subject: [patch 26/29] ath5k: dont enable MSI, we cannot handle it yet
Date: Wednesday, July 30, 2008 - 4:27 pm

2.6.25-stable review patch.  If anyone has any objections, please let us 
know.

------------------
From: Pavel Roskin <proski@gnu.org>

commit 256b152b005e319f985f50f2a910a75ba0def74f upstream

MSI is a nice thing, but we cannot enable it without changing the
interrupt handler.  If we do it, we break MSI capable hardware,
specifically AR5006 chipset.

Signed-off-by: Pavel Roskin <proski@gnu.org>
Acked-by: Nick Kossifidis <mickflemm@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/net/wireless/ath5k/base.c |    5 -----
 1 file changed, 5 deletions(-)

--- a/drivers/net/wireless/ath5k/base.c
+++ b/drivers/net/wireless/ath5k/base.c
@@ -484,9 +484,6 @@ ath5k_pci_probe(struct pci_dev *pdev,
 	/* Set private data */
 	pci_set_drvdata(pdev, hw);
 
-	/* Enable msi for devices that support it */
-	pci_enable_msi(pdev);
-
 	/* Setup interrupt handler */
 	ret = request_irq(pdev->irq, ath5k_intr, IRQF_SHARED, "ath", sc);
 	if (ret) {
@@ -553,7 +550,6 @@ err_ah:
 err_irq:
 	free_irq(pdev->irq, sc);
 err_free:
-	pci_disable_msi(pdev);
 	ieee80211_free_hw(hw);
 err_map:
 	pci_iounmap(pdev, mem);
@@ -575,7 +571,6 @@ ath5k_pci_remove(struct pci_dev *pdev)
 	ath5k_detach(pdev, hw);
 	ath5k_hw_detach(sc->ah);
 	free_irq(pdev->irq, sc);
-	pci_disable_msi(pdev);
 	pci_iounmap(pdev, sc->iobase);
 	pci_release_region(pdev, 0);
 	pci_disable_device(pdev);

-- 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 00/29] 2.6.25-stable review, Greg KH, (Wed Jul 30, 4:24 pm)
[patch 01/29] quota: fix possible infinite loop in quota code, Greg KH, (Wed Jul 30, 4:26 pm)
[patch 02/29] isofs: fix minor filesystem corruption, Greg KH, (Wed Jul 30, 4:26 pm)
[patch 03/29] x86: fix crash due to missing debugctlmsr on ..., Greg KH, (Wed Jul 30, 4:26 pm)
[patch 04/29] vmlinux.lds: move __attribute__((__cold__)) ..., Greg KH, (Wed Jul 30, 4:26 pm)
[patch 05/29] tcp: Clear probes_out more aggressively in t ..., Greg KH, (Wed Jul 30, 4:26 pm)
[patch 06/29] sparc64: Fix lockdep issues in LDC protocol ..., Greg KH, (Wed Jul 30, 4:26 pm)
[patch 07/29] sparc64: Fix cpufreq notifier registry., Greg KH, (Wed Jul 30, 4:26 pm)
[patch 08/29] sparc64: Do not define BIO_VMERGE_BOUNDARY., Greg KH, (Wed Jul 30, 4:26 pm)
[patch 09/29] pata_atiixp: Dont disable, Greg KH, (Wed Jul 30, 4:27 pm)
[patch 10/29] markers: fix duplicate modpost entry, Greg KH, (Wed Jul 30, 4:27 pm)
[patch 11/29] ide-cd: fix oops when using growisofs, Greg KH, (Wed Jul 30, 4:27 pm)
[patch 12/29] Fix build on COMPAT platforms when CONFIG_EP ..., Greg KH, (Wed Jul 30, 4:27 pm)
[patch 13/29] ARM: fix fls() for 64-bit arguments, Greg KH, (Wed Jul 30, 4:27 pm)
[patch 14/29] ALSA: hda - Fix &quot;alc262_sony_unsol&quot; hda_verb ..., Greg KH, (Wed Jul 30, 4:27 pm)
[patch 15/29] ALSA: trident - pause s/pdif output, Greg KH, (Wed Jul 30, 4:27 pm)
[patch 16/29] ahci: retry enabling AHCI a few times before ..., Greg KH, (Wed Jul 30, 4:27 pm)
[patch 17/29] x86: fix kernel_physical_mapping_init() for ..., Greg KH, (Wed Jul 30, 4:27 pm)
[patch 18/29] VFS: increase pseudo-filesystem block size t ..., Greg KH, (Wed Jul 30, 4:27 pm)
[patch 19/29] tmpfs: fix kernel BUG in shmem_delete_inode, Greg KH, (Wed Jul 30, 4:27 pm)
[patch 20/29] mpc52xx_psc_spi: fix block transfer, Greg KH, (Wed Jul 30, 4:27 pm)
[patch 21/29] markers: fix markers read barrier for multip ..., Greg KH, (Wed Jul 30, 4:27 pm)
[patch 22/29] ixgbe: remove device ID for unsupported device, Greg KH, (Wed Jul 30, 4:27 pm)
[patch 23/29] eCryptfs: use page_alloc not kmalloc to get ..., Greg KH, (Wed Jul 30, 4:27 pm)
[patch 24/29] cpufreq acpi: only call _PPC after cpufreq A ..., Greg KH, (Wed Jul 30, 4:27 pm)
[patch 25/29] b43legacy: Release mutex in error handling code, Greg KH, (Wed Jul 30, 4:27 pm)
[patch 26/29] ath5k: dont enable MSI, we cannot handle it yet, Greg KH, (Wed Jul 30, 4:27 pm)
[patch 27/29] Correct hash flushing from huge_ptep_set_wrp ..., Greg KH, (Wed Jul 30, 4:27 pm)
[patch 28/29] netfilter -stable: nf_conntrack_tcp: fix end ..., Greg KH, (Wed Jul 30, 4:27 pm)
[patch 29/29] Fix off-by-one error in iov_iter_advance(), Greg KH, (Wed Jul 30, 4:27 pm)