Re: [patch v3] splice: fix race with page invalidation

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Wednesday, July 30, 2008 - 1:13 pm

On Wed, 30 Jul 2008, Miklos Szeredi wrote:

I dislike that mentality.

The fact is, it's not a bug-fix, it's just papering over the real problem.

And by papering it over, it then just makes people less likely to bother 
with the real issue.

For example, and I talked about this earlier - what make syou think that 
the FUSE/NFSD behaviour you don't like is at all valid in the first place?

If you depend on data not being truncated because you have it "in flight", 
tjhere's already something wrong there. It's _not_ just that people can 
see zero bytes in the reply - apparently they can see the file shrink 
before they see the read return. That kind of thing just worries me. And 
it might be a general NFS issue, not necessarily a FUSE one.

So I think your whole approach stinks. I don't agree with the "bug-fix". 
It really smells like a "bug-paper-over".

			Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Wed Jul 30, 2:43 am)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Wed Jul 30, 10:00 am)
Re: [patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Wed Jul 30, 10:29 am)
Re: [patch v3] splice: fix race with page invalidation, Jens Axboe, (Wed Jul 30, 10:54 am)
Re: [patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Wed Jul 30, 11:32 am)
Re: [patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Wed Jul 30, 11:43 am)
Re: [patch v3] splice: fix race with page invalidation, Jens Axboe, (Wed Jul 30, 12:45 pm)
Re: [patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Wed Jul 30, 1:05 pm)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Wed Jul 30, 1:13 pm)
Re: [patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Wed Jul 30, 1:45 pm)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Wed Jul 30, 1:51 pm)
Re: [patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Wed Jul 30, 2:16 pm)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Wed Jul 30, 2:22 pm)
Re: [patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Wed Jul 30, 2:46 pm)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Wed Jul 30, 2:56 pm)
Re: [patch v3] splice: fix race with page invalidation, Jamie Lokier, (Wed Jul 30, 5:11 pm)
Re: [patch v3] splice: fix race with page invalidation, Jamie Lokier, (Wed Jul 30, 5:42 pm)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Wed Jul 30, 5:51 pm)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Wed Jul 30, 5:54 pm)
Re: [patch v3] splice: fix race with page invalidation, Nick Piggin, (Wed Jul 30, 7:16 pm)
Re: [patch v3] splice: fix race with page invalidation, Jamie Lokier, (Wed Jul 30, 11:12 pm)
Re: [patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Thu Jul 31, 12:30 am)
Re: [patch v3] splice: fix race with page invalidation, Evgeniy Polyakov, (Thu Jul 31, 3:26 am)
Re: [patch v3] splice: fix race with page invalidation, Jamie Lokier, (Thu Jul 31, 5:33 am)
Re: [patch v3] splice: fix race with page invalidation, Nick Piggin, (Thu Jul 31, 5:49 am)
Re: [patch v3] splice: fix race with page invalidation, Nick Piggin, (Thu Jul 31, 5:59 am)
Re: [patch v3] splice: fix race with page invalidation, Evgeniy Polyakov, (Thu Jul 31, 6:29 am)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Thu Jul 31, 9:34 am)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Thu Jul 31, 9:56 am)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Thu Jul 31, 10:00 am)
Re: [patch v3] splice: fix race with page invalidation, Jamie Lokier, (Thu Jul 31, 10:21 am)
Re: [patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Thu Jul 31, 11:13 am)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Thu Jul 31, 11:54 am)
Re: [patch v3] splice: fix race with page invalidation, Nick Piggin, (Thu Jul 31, 6:22 pm)
Re: [patch v3] splice: fix race with page invalidation, Miklos Szeredi, (Fri Aug 1, 11:28 am)
Re: [patch v3] splice: fix race with page invalidation, Linus Torvalds, (Fri Aug 1, 11:32 am)
Re: [patch v3] splice: fix race with page invalidation, Jamie Lokier, (Mon Aug 4, 8:29 am)
Re: [patch v3] splice: fix race with page invalidation, Michael Kerrisk, (Sun Aug 10, 8:22 pm)