Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin"

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jeff Garzik <jeff@...>
Cc: Theodore Tso <tytso@...>, Hugh Dickins <hugh@...>, Andrew Morton <akpm@...>, KOSAKI Motohiro <kosaki.motohiro@...>, <mchan@...>, <linux-kernel@...>, <linux-mm@...>, <netdev@...>
Date: Thursday, July 3, 2008 - 5:33 pm

Jeff Garzik wrote:

They had individual options for a long time, but the consensus was that 
I should remove them -- a consensus which was probably right. It was 
moderately inconvenient going back through it all and recommitting it 
without that, but it was worth it to get it right...


That's right, although it doesn't really matter when they're both in the 
vmlinux.

When it's actually a module, there really is no good reason not to let 
request_firmware() get satisfied from userspace. If you can load 
modules, then you can load firmware too -- the required udev stuff has 
been there as standard for a _long_ time, as most modern drivers 
_require_ it without even giving you the built-in-firmware option at all.

It makes no more sense to object to that than it does to object to the 
module depending on _other_ modules. Both those other modules, and the 
required firmware, are _installed_ by the kernel Makefiles, after all.

It wouldn't be _impossible_ to put firmware blobs into the foo.ko files 
themselves and find them there. The firmware blobs in the kernel are 
done in a separate section (like initcalls, exceptions tables, pci 
fixups, and a bunch of other stuff). It'd just take some work in 
module.c to link them into a global list, and some locking shenanigans 
in the lookups (and lifetime issues to think about). But it just isn't 
worth the added complexity, given that userspace is known to be alive 
and working. It's pointless not to just use request_firmware() normally, 
from a module.

-- 
dwmw2
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.26-rc8-mm1, Andrew Morton, (Thu Jul 3, 5:02 am)
Re: 2.6.26-rc8-mm1 - Missing AC97 power save Kconfig?, Randy Dunlap, (Wed Jul 9, 6:05 pm)
Re: 2.6.26-rc8-mm1: unable to mount nfs shares, Mariusz Kozlowski, (Fri Jul 4, 6:49 pm)
Re: 2.6.26-rc8-mm1: unable to mount nfs shares, Andrew Morton, (Fri Jul 4, 7:07 pm)
[PATCH] memcg: handle shmem's swap cache (Was 2.6.26-rc8-mm1, KAMEZAWA Hiroyuki, (Fri Jul 4, 5:09 am)
memcg: lru scan fix (Was: 2.6.26-rc8-mm1, KAMEZAWA Hiroyuki, (Fri Jul 4, 5:02 am)
Re: memcg: lru scan fix (Was: 2.6.26-rc8-mm1, Rik van Riel, (Fri Jul 4, 3:16 pm)
Re: memcg: lru scan fix (Was: 2.6.26-rc8-mm1, Andrew Morton, (Fri Jul 4, 3:24 pm)
Re: memcg: lru scan fix (Was: 2.6.26-rc8-mm1, KAMEZAWA Hiroyuki, (Fri Jul 4, 11:59 pm)
Question: split-lur // Re: 2.6.26-rc8-mm1, KAMEZAWA Hiroyuki, (Thu Jul 3, 10:48 pm)
Re: [BUILD-FAILURE] 2.6.26-rc8-mm1 - x86 - __ptep_modify_pro..., Jeremy Fitzhardinge, (Thu Jul 3, 2:00 pm)
[bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", KOSAKI Motohiro, (Thu Jul 3, 7:59 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", David Woodhouse, (Fri Jul 4, 10:13 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Arjan van de Ven, (Fri Jul 4, 4:42 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Arjan van de Ven, (Fri Jul 4, 4:59 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", David Woodhouse, (Fri Jul 4, 10:31 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", maximilian attems, (Fri Jul 4, 10:24 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", maximilian attems, (Sat Jul 5, 6:26 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Hannes Reinecke, (Fri Jul 4, 10:39 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", David Woodhouse, (Fri Jul 4, 10:42 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Olivier Galibert, (Fri Jul 4, 7:13 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Olivier Galibert, (Sat Jul 5, 6:53 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Olivier Galibert, (Sat Jul 5, 8:02 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Christoph Hellwig, (Sat Jul 5, 1:13 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Christoph Hellwig, (Sun Jul 6, 6:02 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Olivier Galibert, (Sat Jul 5, 10:44 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", David Woodhouse, (Sat Jul 5, 11:10 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Henrique de Moraes Holschuh..., (Fri Jul 4, 7:58 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Henrique de Moraes Holschuh..., (Fri Jul 4, 11:52 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Henrique de Moraes Holschuh..., (Sat Jul 5, 9:08 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", David Woodhouse, (Fri Jul 4, 10:37 am)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", David Woodhouse, (Thu Jul 3, 5:33 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Mikael Pettersson, (Thu Jul 3, 10:31 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Rafael J. Wysocki, (Thu Jul 3, 5:42 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Rafael J. Wysocki, (Thu Jul 3, 5:52 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Rafael J. Wysocki, (Thu Jul 3, 6:27 pm)
Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin", Rafael J. Wysocki, (Thu Jul 3, 4:52 pm)