Re: [BUILD-FAILURE] 2.6.26-rc8-mm1 - x86 - __ptep_modify_prot_start() missing

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Andrew Morton
Date: Thursday, July 3, 2008 - 10:46 am

On Thu, 3 Jul 2008 17:59:43 +0530 Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:


grump.  Who did all this stuff?

I dunno.  I'll drop s390-build-fixes.patch, add some ccs and stomp off.


From: Andrew Morton <akpm@linux-foundation.org>

In file included from include/asm/pgtable.h:1087,
                 from include/linux/mm.h:39,
                 from arch/s390/mm/hugetlbpage.c:8:
include/asm-generic/pgtable.h: In function '__ptep_modify_prot_start':
include/asm-generic/pgtable.h:209: error: dereferencing pointer to incomplete type

Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 include/asm-generic/pgtable.h |   26 +++++++++-----------------
 1 file changed, 9 insertions(+), 17 deletions(-)

diff -puN include/asm-generic/pgtable.h~s390-build-fixes include/asm-generic/pgtable.h
--- a/include/asm-generic/pgtable.h~s390-build-fixes
+++ a/include/asm-generic/pgtable.h
@@ -197,17 +197,13 @@ static inline int pmd_none_or_clear_bad(
 }
 #endif /* CONFIG_MMU */
 
-static inline pte_t __ptep_modify_prot_start(struct mm_struct *mm,
-					     unsigned long addr,
-					     pte_t *ptep)
-{
-	/*
-	 * Get the current pte state, but zero it out to make it
-	 * non-present, preventing the hardware from asynchronously
-	 * updating it.
-	 */
-	return ptep_get_and_clear(mm, addr, ptep);
-}
+/*
+ * Get the current pte state, but zero it out to make it
+ * non-present, preventing the hardware from asynchronously
+ * updating it.
+ */
+#define __ptep_modify_prot_start(mm, addr, ptep)	\
+	ptep_get_and_clear(mm, addr, ptep)
 
 static inline void __ptep_modify_prot_commit(struct mm_struct *mm,
 					     unsigned long addr,
@@ -235,12 +231,8 @@ static inline void __ptep_modify_prot_co
  * queue the update to be done at some later time.  The update must be
  * actually committed before the pte lock is released, however.
  */
-static inline pte_t ptep_modify_prot_start(struct mm_struct *mm,
-					   unsigned long addr,
-					   pte_t *ptep)
-{
-	return __ptep_modify_prot_start(mm, addr, ptep);
-}
+#define ptep_modify_prot_start(mm, addr, ptep)		\
+	__ptep_modify_prot_start(mm, addr, ptep)
 
 /*
  * Commit an update to a pte, leaving any hardware-controlled bits in
_


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.26-rc8-mm1, Andrew Morton, (Thu Jul 3, 2:02 am)
Re: [BUILD-FAILURE] 2.6.26-rc8-mm1 - x86 - __ptep_modify_p ..., Andrew Morton, (Thu Jul 3, 10:46 am)
Re: [BUILD-FAILURE] 2.6.26-rc8-mm1 - x86 - __ptep_modify_p ..., Jeremy Fitzhardinge, (Thu Jul 3, 11:00 am)
Question: split-lur // Re: 2.6.26-rc8-mm1, KAMEZAWA Hiroyuki, (Thu Jul 3, 7:48 pm)
memcg: lru scan fix (Was: 2.6.26-rc8-mm1, KAMEZAWA Hiroyuki, (Fri Jul 4, 2:02 am)
[PATCH] memcg: handle shmem's swap cache (Was 2.6.26-rc8-mm1, KAMEZAWA Hiroyuki, (Fri Jul 4, 2:09 am)
Re: memcg: lru scan fix (Was: 2.6.26-rc8-mm1, Rik van Riel, (Fri Jul 4, 12:16 pm)
Re: memcg: lru scan fix (Was: 2.6.26-rc8-mm1, Andrew Morton, (Fri Jul 4, 12:24 pm)
Re: 2.6.26-rc8-mm1: unable to mount nfs shares, Mariusz Kozlowski, (Fri Jul 4, 3:49 pm)
Re: 2.6.26-rc8-mm1: unable to mount nfs shares, Andrew Morton, (Fri Jul 4, 4:07 pm)
Re: [bug?] tg3: Failed to load firmware &quot;tigon/tg3_tso.bin&quot;, Henrique de Moraes H ..., (Fri Jul 4, 4:58 pm)
Re: [bug?] tg3: Failed to load firmware &quot;tigon/tg3_tso.bin&quot;, Henrique de Moraes H ..., (Fri Jul 4, 8:52 pm)
Re: memcg: lru scan fix (Was: 2.6.26-rc8-mm1, KAMEZAWA Hiroyuki, (Fri Jul 4, 8:59 pm)
Re: [PATCH] memcg: handle shmem's swap cache (Was 2.6.26-r ..., KAMEZAWA Hiroyuki, (Fri Jul 4, 11:11 pm)
Re: [bug?] tg3: Failed to load firmware &quot;tigon/tg3_tso.bin&quot;, Henrique de Moraes H ..., (Sat Jul 5, 6:08 am)
Re: 2.6.26-rc8-mm1 - Missing AC97 power save Kconfig?, Randy Dunlap, (Wed Jul 9, 3:05 pm)