Home » Mailing list archives » linux-kernel » 2008 » July » 3

[PATCH] node meminfo Active & Inactive pages to Kbytes

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: John Blackwood <john.blackwood@...>
To: <linux-kernel@...>
Cc: Andi Kleen <andi-suse@...>, Andrew Morton <akpm@...>, Todd Allen <todd.allen@...>
Subject: [PATCH] node meminfo Active &amp; Inactive pages to Kbytes
Date: Thursday, July 3, 2008 - 10:35 am

Hi Andrew and Andi,

We found a minor bug in the output of
/sys/devices/system/node/node[n]/meminfo
where the Active and Inactive values are in pages instead of Kbytes.

Looks like this occurred back in 2.6.20 when the code was changed
over to use node_page_state().

Thanks.

--- linux.2.6.26-rc8/drivers/base/node.c	2008-07-03 09:26:01.000000000 -0400
+++ new/drivers/base/node.c	2008-07-03 09:25:45.000000000 -0400
@@ -84,8 +84,8 @@ static ssize_t node_read_meminfo(struct
  		       nid, K(i.totalram),
  		       nid, K(i.freeram),
  		       nid, K(i.totalram - i.freeram),
-		       nid, node_page_state(nid, NR_ACTIVE),
-		       nid, node_page_state(nid, NR_INACTIVE),
+		       nid, K(node_page_state(nid, NR_ACTIVE)),
+		       nid, K(node_page_state(nid, NR_INACTIVE)),
  #ifdef CONFIG_HIGHMEM
  		       nid, K(i.totalhigh),
  		       nid, K(i.freehigh),
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] node meminfo Active & Inactive pages to Kbytes, John Blackwood, (Thu Jul 3, 10:35 am)
Re: [PATCH] node meminfo Active &amp; Inactive pages to Kbytes, Andrew Morton, (Thu Jul 3, 6:42 pm)
Re: [PATCH] node meminfo Active &amp; Inactive pages to Kbytes, John Blackwood, (Sat Jul 5, 11:15 am)