Re: linux-next: build failure

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: KOSAKI Motohiro <kosaki.motohiro@...>, Stephen Rothwell <sfr@...>, David Miller <davem@...>, <linux-next@...>, LKML <linux-kernel@...>, Andrew Morton <akpm@...>, Mike Travis <travis@...>
Date: Tuesday, July 29, 2008 - 12:44 pm

On Tue, 29 Jul 2008, Linus Torvalds wrote:

In fact, that does seem what gcc-4.x does. The way to tell is to do

	const int *x;

	({ *x }) = 1;

and it's (a) legal (assignments to non-lvalues wouldn't work) and (b) 
gives a nice warning about assignment to read-only location, which in turn 
implies that the compiler properly just peeled off the de-reference even 
though it was inside the statement expression.

IOW, at least in gcc-4.3 (and apparently in earlier gcc-4 versions, but 
not in gcc-3.4.5), a statement expression with an lvalue return value _is_ 
actually an lvalue.

But that also means that there is no difference what-so-ever between (x) 
and ({ x; }) in gcc-4. And in gcc-3 there is, because apparently in gcc-3 
a statement expression is never an lvalue (which is actually the sane 
thing, imho).

			Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
linux-next: build failure, Stephen Rothwell, (Tue Jul 29, 2:23 am)
Re: linux-next: build failure, Ingo Molnar, (Tue Jul 29, 4:00 am)
Re: linux-next: build failure, Linus Torvalds, (Tue Jul 29, 12:26 pm)
Re: linux-next: build failure, Wenji Huang, (Tue Jul 29, 4:14 am)
Re: linux-next: build failure, Stephen Rothwell, (Tue Jul 29, 4:03 am)
Re: linux-next: build failure, Ingo Molnar, (Tue Jul 29, 4:58 am)
Re: linux-next: build failure, KOSAKI Motohiro, (Tue Jul 29, 7:28 am)
Re: linux-next: build failure, Ingo Molnar, (Tue Jul 29, 7:40 am)
Re: linux-next: build failure, Linus Torvalds, (Tue Jul 29, 12:33 pm)
Re: linux-next: build failure, Linus Torvalds, (Tue Jul 29, 12:44 pm)
Re: linux-next: build failure, Ingo Molnar, (Tue Jul 29, 12:42 pm)
Re: linux-next: build failure, Mike Travis, (Tue Jul 29, 10:31 am)
Re: linux-next: build failure, Mike Travis, (Tue Jul 29, 10:33 am)