On Tue, Jul 29, 2008 at 08:40:49AM +0200, Sam Ravnborg wrote:
quoted text
> Hi Paul
> 
> > This didn't end up being _too_ painful, though it did take a bit of time
> > to hunt down all of the guilty parties. I've pushed out what I have now,
> > which you can see at:
> > 
> > http://git.kernel.org/?p=linux/kernel/git/lethal/sh-2.6.git;a=commitdiff;h=f15cbe6f1a4...
> > 
> > It's been holding up to all of the random builds I've thrown at it so
> > far, so there shouldn't be any really nasty surprises left over.
> 
> I took a quick look at it and the header re-org looks good.
> I like that you added the 'mach-' prefix to the directory names.
> 
> But I also noticed several changes like this:
> -#include <asm/landisk/iodata_landisk.h>
> +#include <mach/iodata_landisk.h>
> 
> In this case you _know_ that this is a landisk so
> the less magic option would have been the longer
> include form like this:
> +#include <mach-landisk/mach/iodata_landisk.h>
> 
> It would be preferable that we use the gcc -I
> directive:
> 
>     -Iarch/sh/include/mach-$MACH
> 
> only to automagically select between identical named
> files for the different platforms and not like
> the above where we use it simply to cut off the include
> path a little.
> 
Yes, I had thought about that as well. We certainly need to go this route
if we are building multiple mach types at the same time. Fortunately the
vast majority of mach types do not have their own include structure, so
it's not been something that's popped up yet as a real problem.

quoted text
> Another note is that you decided to move the generated
> file over to arch/sh/include too.
> I really do not know if I think this is the right approach.

This was before I realized that asm-offsets.h was being placed in
include/asm-sh anyways, despite the directory not existing until Kbuild
created it. I don't have any problems with moving it back, I just thought
the idea of multiple include directories for the same asm/ prefix seemed
non-intuitive.
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/