On Tue, Jul 15, 2008 at 08:46:52AM -0400, Theodore Tso wrote:
quoted text
> On Tue, Jul 15, 2008 at 12:37:18AM -0400, Christoph Hellwig wrote:
> > And for this one I haven't even heard back on my review comments.  None
> > of them is a merge blocker so it's not critical, but I find it quite odd
> > that the pull request is coming before even replying to the review
> > comments.
> 
> Can you resend your e-mail, please?  I can't seem to find it in my
> inbox.  Thanks!!

It was just a paragraph in the mail also commenting on the previously
core parts:

quoted text
> Also the code still deals with the !buffer_mapped and no buffers on page
> cases all over which isn't needed anymore with ->page_mkwrite
> implemented.
> Similarly the !get_block case in mpage_da_writepages doesn't make any
> sense - it's never used and if people would want to use
> generic_writepages they could trivially just call it directly.

I've got a comment from Jan that the no buffers case can still happen,
so that can be removed.

Any chance you could also look into the kerneldoc comments for the newly
exported fs/mpage.c routines as commented on the updated patch?
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/