Home » Mailing list archives » linux-kernel » 2008 » July » 22

Re: [PATCH 2.6.26] PCI: refuse to re-add a device to a bus upon pci_scan_child_bus()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Eran Liberty
Subject: Re: [PATCH 2.6.26] PCI: refuse to re-add a device to a bus upon pci_scan_child_bus()
Date: Tuesday, July 22, 2008 - 8:25 am

Matthew Wilcox wrote:
If my devices where the only one on the bus I would not have stumbled on 
this bug. I would have removed them all before reloading and would have 
scanned and empty PCI bus list after the reloading.

Alas, the CPU itself is a pci device. Upon scanning the bus it is it who 
is duplicated. Upon trying to "pci_bus_add_devices()" you get resource 
collision.

Do you perceive any down side to my suggested patch?
It seems (to me) really logical that a device can not and should not be 
added twice to a pci bus device list.

Liberty
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
2.6.24-rc4: pci_remove_bus_device() => pci_scan_child_bus( ..., Eran Liberty, (Wed Jun 18, 7:18 am)
[PATCH 2.6.24-rc4] PCI: refuse to re-add a device to a bus ..., Eran Liberty, (Sun Jul 20, 3:31 am)
Re: [PATCH 2.6.24-rc4] PCI: refuse to re-add a device to a ..., Eran Liberty, (Sun Jul 20, 9:48 am)
[PATCH 2.6.26] PCI: refuse to re-add a device to a bus upo ..., Eran Liberty, (Mon Jul 21, 12:18 pm)
Re: [PATCH 2.6.26] PCI: refuse to re-add a device to a bus ..., Matthew Wilcox, (Mon Jul 21, 12:49 pm)
Re: [PATCH 2.6.26] PCI: refuse to re-add a device to a bus ..., eran liberty, (Tue Jul 22, 1:21 am)
Re: [PATCH 2.6.26] PCI: refuse to re-add a device to a bus ..., Matthew Wilcox, (Tue Jul 22, 4:49 am)
Re: [PATCH 2.6.26] PCI: refuse to re-add a device to a bus ..., Eran Liberty, (Tue Jul 22, 6:08 am)
Re: [PATCH 2.6.26] PCI: refuse to re-add a device to a bus ..., Eran Liberty, (Tue Jul 22, 6:14 am)
Re: [PATCH 2.6.26] PCI: refuse to re-add a device to a bus ..., Matthew Wilcox, (Tue Jul 22, 7:13 am)
Re: [PATCH 2.6.26] PCI: refuse to re-add a device to a bus ..., Eran Liberty, (Tue Jul 22, 8:25 am)
Re: [PATCH 2.6.26] PCI: refuse to re-add a device to a bus ..., Matthew Wilcox, (Tue Jul 22, 9:52 am)
Re: [PATCH 2.6.26] PCI: refuse to re-add a device to a bus ..., Eran Liberty, (Tue Jul 22, 10:41 am)
Re: [PATCH 2.6.26] PCI: refuse to re-add a device to a bus ..., Matthew Wilcox, (Tue Jul 22, 11:11 am)
Re: [PATCH 2.6.26] PCI: refuse to re-add a device to a bus ..., Eran Liberty, (Wed Jul 23, 11:31 am)
Re: [PATCH 2.6.26] PCI: refuse to re-add a device to a bus ..., Eran Liberty, (Sun Jul 27, 4:01 am)
Re: [PATCH 2.6.26] PCI: refuse to re-add a device to a bus ..., Matthew Wilcox, (Sun Jul 27, 8:08 am)
ftrace introduces instability into kernel 2.6.27(-rc2,-rc3), Eran Liberty, (Mon Aug 18, 1:08 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Mon Aug 18, 8:07 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Mathieu Desnoyers, (Mon Aug 18, 8:47 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Mon Aug 18, 9:12 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Mathieu Desnoyers, (Mon Aug 18, 10:04 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Scott Wood, (Mon Aug 18, 10:21 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Eran Liberty, (Mon Aug 18, 11:25 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Mon Aug 18, 11:27 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Scott Wood, (Mon Aug 18, 11:29 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Mathieu Desnoyers, (Mon Aug 18, 11:41 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Mon Aug 18, 11:47 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Mon Aug 18, 11:50 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Scott Wood, (Mon Aug 18, 11:56 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Mon Aug 18, 12:28 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Benjamin Herrenschmidt, (Mon Aug 18, 6:51 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Benjamin Herrenschmidt, (Mon Aug 18, 6:53 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Benjamin Herrenschmidt, (Mon Aug 18, 6:54 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Mon Aug 18, 7:28 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Benjamin Herrenschmidt, (Mon Aug 18, 7:39 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Mon Aug 18, 7:41 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Mathieu Desnoyers, (Mon Aug 18, 7:47 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Benjamin Herrenschmidt, (Mon Aug 18, 7:56 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Mon Aug 18, 8:12 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Mon Aug 18, 8:32 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Mathieu Desnoyers, (Mon Aug 18, 8:36 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Mon Aug 18, 9:00 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Benjamin Herrenschmidt, (Mon Aug 18, 9:17 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Eran Liberty, (Tue Aug 19, 2:56 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Eran Liberty, (Tue Aug 19, 5:09 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Mathieu Desnoyers, (Tue Aug 19, 6:02 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Mathieu Desnoyers, (Tue Aug 19, 6:05 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Eran Liberty, (Tue Aug 19, 7:21 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Mathieu Desnoyers, (Tue Aug 19, 7:42 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Tue Aug 19, 9:47 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Mathieu Desnoyers, (Tue Aug 19, 10:34 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Tue Aug 19, 1:15 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Tue Aug 19, 2:08 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Benjamin Herrenschmidt, (Tue Aug 19, 2:46 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Benjamin Herrenschmidt, (Tue Aug 19, 2:47 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Jeremy Fitzhardinge, (Tue Aug 19, 4:58 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Benjamin Herrenschmidt, (Tue Aug 19, 6:17 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Benjamin Herrenschmidt, (Wed Aug 20, 12:18 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Nick Piggin, (Wed Aug 20, 2:40 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Eran Liberty, (Wed Aug 20, 4:18 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Wed Aug 20, 6:12 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Wed Aug 20, 6:14 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Wed Aug 20, 6:19 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Eran Liberty, (Wed Aug 20, 6:36 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Wed Aug 20, 6:43 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Eran Liberty, (Wed Aug 20, 7:02 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Josh Boyer, (Wed Aug 20, 7:16 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Wed Aug 20, 7:22 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Josh Boyer, (Wed Aug 20, 7:50 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Jon Smirl, (Wed Aug 20, 7:55 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Wed Aug 20, 8:23 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Wed Aug 20, 8:27 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Eran Liberty, (Wed Aug 20, 11:23 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Wed Aug 20, 11:33 am)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Benjamin Herrenschmidt, (Wed Aug 20, 2:36 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Benjamin Herrenschmidt, (Wed Aug 20, 2:37 pm)
Re: ftrace introduces instability into kernel 2.6.27(-rc2, ..., Steven Rostedt, (Wed Aug 20, 2:44 pm)
[PATCH 2.6.26] SERIAL DRIVER: Handle Multiple consecutive ..., Eran Liberty, (Mon Sep 15, 9:30 am)
Re: [PATCH 2.6.26] SERIAL DRIVER: Handle Multiple consecut ..., Andrew Morton, (Wed Sep 17, 4:46 pm)
Re: [PATCH 2.6.26] SERIAL DRIVER: Handle Multiple consecut ..., Eran Liberty, (Wed Sep 17, 11:58 pm)