[PATCH 39/79] block: make /proc/partitions and /proc/diskstats use class_find_device()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Greg Kroah-Hartman
Date: Monday, July 21, 2008 - 10:19 pm

Use the proper class iterator function instead of mucking around in the
internals of the class structures.

Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 block/genhd.c |   25 +++++++++++++------------
 1 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/block/genhd.c b/block/genhd.c
index 70f1d70..c13cc77 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -317,17 +317,21 @@ static void *part_start(struct seq_file *part, loff_t *pos)
 	return NULL;
 }
 
+static int find_next(struct device *dev, void *data)
+{
+	if (dev->type == &disk_type)
+		return 1;
+	return 0;
+}
+
 static void *part_next(struct seq_file *part, void *v, loff_t *pos)
 {
 	struct gendisk *gp = v;
 	struct device *dev;
 	++*pos;
-	list_for_each_entry(dev, &gp->dev.node, node) {
-		if (&dev->node == &block_class.devices)
-			return NULL;
-		if (dev->type == &disk_type)
-			return dev_to_disk(dev);
-	}
+	dev = class_find_device(&block_class, &gp->dev, NULL, find_next);
+	if (dev)
+		return dev_to_disk(dev);
 	return NULL;
 }
 
@@ -578,12 +582,9 @@ static void *diskstats_next(struct seq_file *part, void *v, loff_t *pos)
 	struct device *dev;
 
 	++*pos;
-	list_for_each_entry(dev, &gp->dev.node, node) {
-		if (&dev->node == &block_class.devices)
-			return NULL;
-		if (dev->type == &disk_type)
-			return dev_to_disk(dev);
-	}
+	dev = class_find_device(&block_class, &gp->dev, NULL, find_next);
+	if (dev)
+		return dev_to_disk(dev);
 	return NULL;
 }
 
-- 
1.5.6.3

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[GIT PATCH] driver core patches against 2.6.26, Greg KH, (Mon Jul 21, 10:18 pm)
[PATCH 01/79] sysfs: add /sys/dev/{char,block} to lookup s ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 02/79] kobject: replace '/' with '!' in name, Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 03/79] debugfs: Add a reference to the debugfs API ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 04/79] Firmware: fix typo in example code, Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 05/79] device create: block: convert device_create ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 06/79] device create: char: convert device_create t ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 07/79] device create: coda: convert device_create t ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 08/79] device create: dca: convert device_create to ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 09/79] device create: dvb: convert device_create to ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 10/79] device create: framebuffer: convert device_c ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 11/79] device create: hid: convert device_create to ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 12/79] device create: hwmon: convert device_create ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 13/79] device create: i2c: convert device_create to ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 14/79] device create: ide: convert device_create to ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 15/79] device create: ieee1394: convert device_crea ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 16/79] device create: infiniband: convert device_cr ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 17/79] device create: isdn: convert device_create t ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 18/79] device create: macintosh: convert device_cre ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 19/79] device create: mips: convert device_create t ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 20/79] device create: misc: convert device_create t ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 21/79] device create: mtd: convert device_create to ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 22/79] device create: net: convert device_create to ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 23/79] device create: s390: convert device_create t ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 24/79] device create: scsi: convert device_create t ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 25/79] device create: sound: convert device_create ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 26/79] device create: spi: convert device_create to ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 27/79] device create: usb: convert device_create to ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 28/79] device create: x86: convert device_create to ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 29/79] driver core: remove device_create(), Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 30/79] device create: convert device_create_drvdata ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 31/79] Driver Core: add ability for class_for_each_ ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 32/79] Driver Core: add ability for class_find_devi ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 33/79] block: fix compiler warning in genhd.c, Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 34/79] block: make printk_partition use the class i ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 35/79] block: make blk_lookup_devt use the class it ..., Greg Kroah-Hartman, (Mon Jul 21, 10:18 pm)
[PATCH 36/79] block: make /proc/diskstats only build if CO ..., Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 37/79] block: make proc files seq_start use the cla ..., Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 38/79] block: move header for /proc/partitions to s ..., Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 39/79] block: make /proc/partitions and /proc/disks ..., Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 41/79] infiniband: make cm_device use a struct devi ..., Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 42/79] bluetooth: remove improper bluetooth class s ..., Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 43/79] class: move driver core specific parts to a ..., Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 48/79] class: fix docbook comments for class_privat ..., Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 49/79] class: add lockdep infrastructure, Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 50/79] class: change internal semaphore to a mutex, Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 51/79] driver core: remove KOBJ_NAME_LEN define, Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 52/79] driver core: remove DEVICE_NAME_SIZE define, Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 53/79] driver core: remove DEVICE_ID_SIZE define, Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 54/79] driver core: fix a lot of printk usages of b ..., Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 55/79] pnp: add acpi:* modalias entries, Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 56/79] UIO: fix UIO Kconfig dependencies, Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 57/79] UIO: Add write function to allow irq masking, Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 58/79] UIO: add generic UIO platform driver, Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 59/79] UIO: minor style and comment fixes, Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 60/79] kobject: reorder kobject to save space on 64 ..., Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 61/79] kobject: should use kobject_put() in kset-ex ..., Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 62/79] sysdev: fix debugging statements in registra ..., Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 63/79] sysfs: don't call notify_change, Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 64/79] uio-howto.tmpl: use standard copyright/legal ..., Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 65/79] uio-howto.tmpl: use unique output names, Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 66/79] always enable FW_LOADER unless EMBEDDED=y, Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 67/79] HOWTO: change email addresses of James in HOWTO, Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 68/79] debugfs: Implement debugfs_remove_recursive(), Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 69/79] sysfs-rules.txt: reword API stability statement, Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 70/79] kobject: Transmit return value of call_userm ..., Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 71/79] driver core: Suppress sysfs warnings for dev ..., Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 72/79] sysdev: Pass the attribute to the low level ..., Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 73/79] sysdev: Add utility functions for simple int ..., Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 74/79] sysdev: Convert the x86 mce tolerant sysdev ..., Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 75/79] HP iLO driver, Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 76/79] MTD: handle pci_name() being const, Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 77/79] 3c59x: handle pci_name() being const, Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 78/79] sparc64: fix up bus_id changes in sparc core ..., Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
[PATCH 79/79] arm: bus_id -&gt; dev_name() and dev_set_name() ..., Greg Kroah-Hartman, (Mon Jul 21, 10:19 pm)
RE: [PATCH 75/79] HP iLO driver, Altobelli, David, (Tue Jul 22, 10:11 am)
Re: [PATCH 75/79] HP iLO driver, Greg KH, (Tue Jul 22, 10:16 am)
Re: [PATCH 18/79] device create: macintosh: convert device ..., Benjamin Herrenschmidt, (Tue Jul 22, 3:00 pm)