Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison overwritten

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Evgeniy Polyakov
Date: Monday, July 21, 2008 - 2:24 pm

On Mon, Jul 21, 2008 at 09:21:38PM +0200, Ingo Molnar (mingo@elte.hu) wrote:

e1000_clean_tx_irq() call looks particulary suspicious: it is called
without adapter->tx_queue_lock in poll controller (netconsole callback)
and with that lock in NAPI handler.

Can you check kind of this patch:

diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index 869544b..5f180d8 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -4067,7 +4067,9 @@ static void e1000_netpoll(struct net_device *netdev)
 	disable_irq(adapter->pdev->irq);
 	e1000_intr(adapter->pdev->irq, netdev);
 
+	spin_lock(&adapter->tx_queue_lock);
 	e1000_clean_tx_irq(adapter);
+	spin_unlock(&adapter->tx_queue_lock);
 
 	enable_irq(adapter->pdev->irq);
 }


-- 
	Evgeniy Polyakov
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison ..., Evgeniy Polyakov, (Thu Jul 17, 10:46 pm)
Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison ..., Evgeniy Polyakov, (Fri Jul 18, 3:16 am)
Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison ..., Christoph Lameter, (Fri Jul 18, 6:54 am)
Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison ..., Christoph Lameter, (Fri Jul 18, 6:55 am)
Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison ..., Christoph Lameter, (Fri Jul 18, 7:48 am)
Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison ..., Evgeniy Polyakov, (Fri Jul 18, 9:07 am)
Re: [bug] Attempt to release alive inet socket f6fac040, Ingo Molnar, (Fri Jul 18, 12:10 pm)
Re: [bug] Attempt to release alive inet socket f6fac040, Ingo Molnar, (Fri Jul 18, 12:55 pm)
Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison ..., Evgeniy Polyakov, (Mon Jul 21, 3:06 am)
Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison ..., Evgeniy Polyakov, (Mon Jul 21, 4:25 am)
Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison ..., Evgeniy Polyakov, (Mon Jul 21, 5:57 am)
Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison ..., Christoph Lameter, (Mon Jul 21, 9:19 am)
Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison ..., Christoph Lameter, (Mon Jul 21, 9:22 am)
Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison ..., Evgeniy Polyakov, (Mon Jul 21, 12:57 pm)
Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison ..., Evgeniy Polyakov, (Mon Jul 21, 2:24 pm)