Re: [git pull] scheduler updates for v2.6.27, phase #2

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Daniel Walker
Date: Monday, July 21, 2008 - 1:16 pm

On Mon, 2008-07-21 at 21:23 +0200, Peter Zijlstra wrote:


Yours removed the warning .. I made an alternate one below only compile
tested, your choice..

Signed-off-by: Daniel Walker <dwalker@mvista.com>


diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
index 47ceac9..febb864 100644
--- a/kernel/sched_rt.c
+++ b/kernel/sched_rt.c
@@ -242,7 +242,7 @@ static int do_balance_runtime(struct rt_rq *rt_rq)
 	rt_period = ktime_to_ns(rt_b->rt_period);
 	for_each_cpu_mask(i, rd->span) {
 		struct rt_rq *iter = sched_rt_period_rt_rq(rt_b, i);
-		s64 diff;
+		u64 diff;
 
 		if (iter == rt_rq)
 			continue;
@@ -252,7 +252,7 @@ static int do_balance_runtime(struct rt_rq *rt_rq)
 			goto next;
 
 		diff = iter->rt_runtime - iter->rt_time;
-		if (diff > 0) {
+		if ((s64)(diff) > 0) {
 			do_div(diff, weight);
 			if (rt_rq->rt_runtime + diff > rt_period)
 				diff = rt_period - rt_rq->rt_runtime;


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[git pull] scheduler updates for v2.6.27, phase #2, Ingo Molnar, (Mon Jul 21, 8:38 am)
Re: [git pull] scheduler updates for v2.6.27, phase #2, Daniel Walker, (Mon Jul 21, 9:31 am)
Re: [git pull] scheduler updates for v2.6.27, phase #2, Peter Zijlstra, (Mon Jul 21, 12:23 pm)
Re: [git pull] scheduler updates for v2.6.27, phase #2, Daniel Walker, (Mon Jul 21, 1:16 pm)
Re: [git pull] scheduler updates for v2.6.27, phase #2, Peter Zijlstra, (Thu Jul 24, 3:43 am)
Re: [git pull] scheduler updates for v2.6.27, phase #2, Andrew Morton, (Thu Jul 24, 4:09 am)
Re: [git pull] scheduler updates for v2.6.27, phase #2, Peter Zijlstra, (Thu Jul 24, 4:15 am)
Re: [git pull] scheduler updates for v2.6.27, phase #2, Ingo Molnar, (Thu Jul 24, 4:24 am)
Re: [git pull] scheduler updates for v2.6.27, phase #2, Daniel Walker, (Thu Jul 24, 12:12 pm)