Re: Please pull ACPI updates

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andi Kleen <andi@...>
Cc: Ray Lee <ray-lk@...>, Linus Torvalds <torvalds@...>, Jesse Barnes <jbarnes@...>, Rafael J. Wysocki <rjw@...>, <torvalds@...>, <linux-kernel@...>, <linux-acpi@...>
Date: Friday, July 18, 2008 - 2:39 am

On Thu, 17 Jul 2008, Andi Kleen wrote:


Andi,

say you create patch P1 against tree version T1 creating tree T2

you then rebase patch P1 against tree version T5 creating tree T6

people tested tree T2, they didn't test tree T6. while the changes made by 
patch P1 are still the same, there may be other changes that interact with 
things (and not nessasarily by chnaging the same area of the code, they 
may change memory layouts, timing, etc)

when someone is trying to track things down they can no longer recreate 
the state of tree T2, you've wiped the record of that from history. all 
they can do is to test version T5 and T6.

the other approach is that you create patch P1 against tree version T1 
creating tree T2, this then gets merged with tree version T5 upstream 
creating tree T6.

now when someone goes to track down a problem they can see all four tree 
versions, T1, T2, T5, and T6. they can not only test that T5 works but T6 
doesn't, but they can test that T2 works as well. They then can immediatly 
start looking for other interactions that are the result of the merge (and 
what's different between T1 and T5) rather then focusing just on 'what did 
patch P1 change'


now, it's also not good to have large areas of non-bisectable trees and 
bugs with their fixes a lot later, but with distributed testing and 
development you will never completely eliminate this.

there are things that you can do to minimize that, and using some number 
of topic branches seems to be one of the big ones (and I'll point you at 
the other explinations from this thread that have focused on what those 
are)

David Lang
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Please pull ACPI updates, Andi Kleen, (Wed Jul 16, 5:45 pm)
Re: Please pull ACPI updates, Rafael J. Wysocki, (Wed Jul 16, 6:11 pm)
Re: Please pull ACPI updates, Jesse Barnes, (Wed Jul 16, 7:33 pm)
Re: Please pull ACPI updates, Andi Kleen, (Thu Jul 17, 2:47 am)
Re: Please pull ACPI updates, Linus Torvalds, (Thu Jul 17, 11:18 am)
Re: Please pull ACPI updates, Linus Torvalds, (Thu Jul 17, 11:47 am)
Re: Please pull ACPI updates, Andi Kleen, (Thu Jul 17, 12:23 pm)
Re: Please pull ACPI updates, Ray Lee, (Thu Jul 17, 3:11 pm)
Re: Please pull ACPI updates, Andi Kleen, (Thu Jul 17, 3:49 pm)
Re: Please pull ACPI updates, Ray Lee, (Thu Jul 17, 4:11 pm)
Re: Please pull ACPI updates, Andi Kleen, (Thu Jul 17, 4:29 pm)
Re: Please pull ACPI updates, , (Fri Jul 18, 2:39 am)
Re: Please pull ACPI updates, Linus Torvalds, (Thu Jul 17, 4:01 pm)
Re: Please pull ACPI updates, Linus Torvalds, (Thu Jul 17, 4:16 pm)
Re: Please pull ACPI updates, Andi Kleen, (Thu Jul 17, 4:34 pm)
Re: Please pull ACPI updates, Linus Torvalds, (Thu Jul 17, 4:28 pm)
Re: Please pull ACPI updates, Olivier Galibert, (Fri Jul 18, 9:25 am)
Re: Please pull ACPI updates, Ray Lee, (Fri Jul 18, 11:57 am)
Re: Please pull ACPI updates, Andi Kleen, (Thu Jul 17, 4:14 pm)
Re: Please pull ACPI updates, Linus Torvalds, (Thu Jul 17, 12:02 pm)
Re: Please pull ACPI updates, Linus Torvalds, (Wed Jul 16, 7:45 pm)
Re: Please pull ACPI updates, Andi Kleen, (Thu Jul 17, 2:40 am)
Re: Please pull ACPI updates, Linus Torvalds, (Thu Jul 17, 11:03 am)
Re: Please pull ACPI updates, Len Brown, (Thu Jul 17, 2:49 pm)
Re: Please pull ACPI updates, J. Bruce Fields, (Thu Jul 17, 5:15 pm)
Re: Please pull ACPI updates, Linus Torvalds, (Thu Jul 17, 3:12 pm)
Re: Please pull ACPI updates, Linus Torvalds, (Thu Jul 17, 3:16 pm)
Re: Please pull ACPI updates, Harvey Harrison, (Thu Jul 17, 3:12 pm)
Re: Please pull ACPI updates, Andi Kleen, (Thu Jul 17, 3:50 pm)
Re: Please pull ACPI updates, Jesse Barnes, (Wed Jul 16, 7:51 pm)
Re: Please pull ACPI updates, Linus Torvalds, (Wed Jul 16, 8:32 pm)
Re: Please pull ACPI updates, Andi Kleen, (Thu Jul 17, 2:45 am)
Re: Please pull ACPI updates, Linus Torvalds, (Thu Jul 17, 11:06 am)
Re: Please pull ACPI updates, Linus Torvalds, (Wed Jul 16, 8:53 pm)
Re: Please pull ACPI updates, Jesse Barnes, (Wed Jul 16, 10:26 pm)
Re: Please pull ACPI updates, Linus Torvalds, (Wed Jul 16, 10:56 pm)