Re: Please pull ACPI updates

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andi Kleen <andi@...>
Cc: Ray Lee <ray-lk@...>, Jesse Barnes <jbarnes@...>, Rafael J. Wysocki <rjw@...>, <torvalds@...>, <linux-kernel@...>, <linux-acpi@...>
Date: Thursday, July 17, 2008 - 4:01 pm

On Thu, 17 Jul 2008, Andi Kleen wrote:

No.

"git bisect" is perfetly able to handle merges. They are _fine_.

The problem with rebasing is that it *changes* something that was already 
tested (and possibly merged into somebody elses tree) into SOMETHING ELSE.

And that means that a large portion of the previous testing is basically 
thrown away.

In particular, if something worked for somebody before, it also removes 
the "known good state" from a bisection standpoint, so rebasing actually 
makes things _harder_ to bisect - because now you cannot sanely bisect 
between two versions of the tree (when you mark the old tree "good", it 
has no relevance to the new tree that had all the old history rewritten).

So no, rebasing does _not_ make bisection easier. It makes it easier to 
understand, perhaps, but it actually makes many things much much harder, 
and removes all trace of any testing coverage that the old commit had.

			Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Please pull ACPI updates, Andi Kleen, (Wed Jul 16, 5:45 pm)
Re: Please pull ACPI updates, Rafael J. Wysocki, (Wed Jul 16, 6:11 pm)
Re: Please pull ACPI updates, Jesse Barnes, (Wed Jul 16, 7:33 pm)
Re: Please pull ACPI updates, Andi Kleen, (Thu Jul 17, 2:47 am)
Re: Please pull ACPI updates, Linus Torvalds, (Thu Jul 17, 11:18 am)
Re: Please pull ACPI updates, Linus Torvalds, (Thu Jul 17, 11:47 am)
Re: Please pull ACPI updates, Andi Kleen, (Thu Jul 17, 12:23 pm)
Re: Please pull ACPI updates, Ray Lee, (Thu Jul 17, 3:11 pm)
Re: Please pull ACPI updates, Andi Kleen, (Thu Jul 17, 3:49 pm)
Re: Please pull ACPI updates, Ray Lee, (Thu Jul 17, 4:11 pm)
Re: Please pull ACPI updates, Andi Kleen, (Thu Jul 17, 4:29 pm)
Re: Please pull ACPI updates, , (Fri Jul 18, 2:39 am)
Re: Please pull ACPI updates, Linus Torvalds, (Thu Jul 17, 4:01 pm)
Re: Please pull ACPI updates, Linus Torvalds, (Thu Jul 17, 4:16 pm)
Re: Please pull ACPI updates, Andi Kleen, (Thu Jul 17, 4:34 pm)
Re: Please pull ACPI updates, Linus Torvalds, (Thu Jul 17, 4:28 pm)
Re: Please pull ACPI updates, Olivier Galibert, (Fri Jul 18, 9:25 am)
Re: Please pull ACPI updates, Ray Lee, (Fri Jul 18, 11:57 am)
Re: Please pull ACPI updates, Andi Kleen, (Thu Jul 17, 4:14 pm)
Re: Please pull ACPI updates, Linus Torvalds, (Thu Jul 17, 12:02 pm)
Re: Please pull ACPI updates, Linus Torvalds, (Wed Jul 16, 7:45 pm)
Re: Please pull ACPI updates, Andi Kleen, (Thu Jul 17, 2:40 am)
Re: Please pull ACPI updates, Linus Torvalds, (Thu Jul 17, 11:03 am)
Re: Please pull ACPI updates, Len Brown, (Thu Jul 17, 2:49 pm)
Re: Please pull ACPI updates, J. Bruce Fields, (Thu Jul 17, 5:15 pm)
Re: Please pull ACPI updates, Linus Torvalds, (Thu Jul 17, 3:12 pm)
Re: Please pull ACPI updates, Linus Torvalds, (Thu Jul 17, 3:16 pm)
Re: Please pull ACPI updates, Harvey Harrison, (Thu Jul 17, 3:12 pm)
Re: Please pull ACPI updates, Andi Kleen, (Thu Jul 17, 3:50 pm)
Re: Please pull ACPI updates, Jesse Barnes, (Wed Jul 16, 7:51 pm)
Re: Please pull ACPI updates, Linus Torvalds, (Wed Jul 16, 8:32 pm)
Re: Please pull ACPI updates, Andi Kleen, (Thu Jul 17, 2:45 am)
Re: Please pull ACPI updates, Linus Torvalds, (Thu Jul 17, 11:06 am)
Re: Please pull ACPI updates, Linus Torvalds, (Wed Jul 16, 8:53 pm)
Re: Please pull ACPI updates, Jesse Barnes, (Wed Jul 16, 10:26 pm)
Re: Please pull ACPI updates, Linus Torvalds, (Wed Jul 16, 10:56 pm)