Home » Mailing list archives » linux-kernel » 2008 » July » 17

Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or other GPEs) on Asus EeePC

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Alan Jenkins <alan-jenkins@...>
To: Alexey Starikovskiy <astarikovskiy@...>
Cc: <linux-acpi@...>, linux-kernel <linux-kernel@...>
Subject: Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or other GPEs) on Asus EeePC
Date: Thursday, July 17, 2008 - 12:02 pm

Alexey Starikovskiy wrote:
Vacuously so.

My patch still applies, but #10919 makes it obsolete.  My patch fixed a
bug that shows up in polling mode.  #10919 kills polling mode.

I've tested v2.6.26 + #10919 and it works fine (except for spamming the
kernel log - please read my Bugzilla comment).


It appears that interrupt mode suffered from a race which is very
similar to my original problem.  If two GPE interrupts arrive before the
workqueue runs, then the second interrupt will be ignored because
EC_FLAGS_QUERY_PENDING is still set.  This will happen with any EC if
interrupts are very close together, right?

I think my patch also fixes this theoretical problem.  But I'd rather
you took over on this.  I was already confused by ec.c in v2.6.26, and
with #10919 I understand it even less.  E.g. why is
ec_switch_to_poll_mode() still present; what does it do now do_ec_poll()
is removed?

I'm happy to work on this with you, but I'd need to be able understand
the code first :-(.

Alan
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] acpi: Avoid dropping rapid hotkey events (or other G..., Alan Jenkins, (Tue Jul 15, 6:25 pm)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Alexey Starikovskiy, (Thu Jul 17, 10:35 am)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Alan Jenkins, (Thu Jul 17, 12:02 pm)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Alexey Starikovskiy, (Thu Jul 17, 12:45 pm)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Alan Jenkins, (Thu Jul 17, 2:55 pm)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Alexey Starikovskiy, (Thu Jul 17, 2:59 pm)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Andrew Morton, (Tue Aug 12, 7:28 pm)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Alan Jenkins, (Wed Aug 13, 6:21 am)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Andrew Morton, (Wed Aug 13, 6:46 am)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Alan Jenkins, (Wed Aug 13, 7:51 am)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Maximilian Engelhardt, (Wed Aug 13, 9:36 am)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Alan Jenkins, (Wed Aug 13, 10:39 am)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Alan Jenkins, (Wed Aug 13, 7:45 am)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Alexey Starikovskiy, (Thu Jul 17, 7:49 am)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Henrique de Moraes Holschuh..., (Thu Jul 17, 8:13 am)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Alexey Starikovskiy, (Thu Jul 17, 8:30 am)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Henrique de Moraes Holschuh..., (Thu Jul 17, 12:26 pm)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Alan Jenkins, (Thu Jul 17, 12:45 pm)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Henrique de Moraes Holschuh..., (Thu Jul 17, 2:50 pm)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Alan Jenkins, (Thu Jul 17, 3:07 pm)
[PATCH 0/3] acpi: GPE fixes, Alan Jenkins, (Sat Jul 19, 7:37 am)
Re: [PATCH 0/3] acpi: GPE fixes, Vegard Nossum, (Sat Jul 19, 10:07 am)