Re: [Squashfs-devel] Squashfs mainlining status?

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Peter Korsgaard <jacmet@...>
Cc: Phillip Lougher <phillip@...>, <squashfs-devel@...>, Linux Kernel Development <linux-kernel@...>
Date: Thursday, July 17, 2008 - 11:35 am

Hi Peter,

On Wed, 4 Jun 2008, Peter Korsgaard wrote:

Oops, I've just returned from holidays, and realize I never actually responded
to this question. So here is the gist of it:

| I had a closer look at the structures and bitfields, and I still think it's
| possible to stay compatible with the current little endian layout:
|   1. About half of the bitfields are actually bytes or 16-bit words. Hence
|      these can easily be converted to __u8 or __le16.
|   2. Most of the remaining bitfields sit in an 8, 16, or 32 bit integer.
|      Hence these can be converted to such an integer (or an array of bytes,
|      cfr. 3 below), and accessed using get_unaligned_le{16,32}() and a
|      shift/mask operation.
|   3. There are a few bitfields that sit in an `odd' number of bytes. These
|      can be converted to an array of bytes, and accessed using
|      get_unaligned_le{16,32}() and a shift/mask operation.
|   4. The integral fields in the structs should be accessed using
|      get_unaligned_le{8,16,32}(), too.

I noticed the squashfs CVS repository is getting a new (incompatible) 4.0
layout now?

What do people think?

With kind regards,

Geert Uytterhoeven
Software Architect

Sony Techsoft Centre Europe
The Corporate Village
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Squashfs mainlining status?, Geert Uytterhoeven, (Mon Jun 2, 11:33 am)
Re: Squashfs mainlining status?, Phillip Lougher, (Tue Jun 3, 11:16 pm)
Re: [Squashfs-devel] Squashfs mainlining status?, Peter Korsgaard, (Wed Jun 4, 5:37 am)
Re: [Squashfs-devel] Squashfs mainlining status?, Geert Uytterhoeven, (Thu Jul 17, 11:35 am)
Re: [Squashfs-devel] Squashfs mainlining status?, Robert Lougher, (Thu Jul 17, 11:47 am)
Re: [Squashfs-devel] Squashfs mainlining status?, Geert Uytterhoeven, (Fri Jul 18, 2:14 am)
Re: [Squashfs-devel] Squashfs mainlining status?, Robert Lougher, (Fri Jul 18, 8:37 am)