Re: KVM overflows the stack

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Roland Dreier <rdreier@...>
Cc: Avi Kivity <avi@...>, linux-kernel@vger.kernel.org <linux-kernel@...>, kvm-devel <kvm@...>, Anthony N. Liguori [imap] <aliguori@...>
Date: Thursday, July 17, 2008 - 10:06 am

On Wed, 2008-07-16 at 23:08 -0700, Roland Dreier wrote:

Well, you *better* be able to deal with it.  :)

This code is also doing a *ton* of copy_to/from_user().  If userspace
had one of its input buffers swapped out (or one of its output buffers
not faulted in yet) and we're out of memory enough to be failing
kmallocs() then we're sure as heck also going to failing the user
copies.

I think it's a non-issue.

-- Dave

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
kvm causing memory corruption? ~2.6.25-rc6, Dave Hansen, (Tue Mar 25, 5:12 pm)
Re: kvm causing memory corruption? now 2.6.26-rc4, Dave Hansen, (Mon Jun 2, 6:30 pm)
Re: kvm causing memory corruption? now 2.6.26-rc4, Avi Kivity, (Wed Jun 4, 9:42 am)
Re: kvm causing memory corruption? now 2.6.26-rc4, Dave Hansen, (Fri Jun 6, 3:41 am)
Re: kvm causing memory corruption? now 2.6.26-rc4, Avi Kivity, (Thu Jun 12, 9:10 am)
Re: kvm causing memory corruption? now 2.6.26-rc8, Dave Hansen, (Tue Jul 15, 2:57 pm)
Re: kvm causing memory corruption? now 2.6.26, Dave Hansen, (Wed Jul 16, 5:44 pm)
Re: kvm causing memory corruption? now 2.6.26, Avi Kivity, (Thu Jul 17, 1:38 am)
KVM overflows the stack, Dave Hansen, (Wed Jul 16, 6:48 pm)
Re: KVM overflows the stack, Dave Hansen, (Thu Jul 17, 2:27 am)
Re: KVM overflows the stack, Avi Kivity, (Thu Jul 17, 1:52 am)
[PATCH] update kvm's anon_inodes.c for r/o bind mounts, Dave Hansen, (Thu Jul 17, 2:45 am)
Re: KVM overflows the stack, Dave Hansen, (Thu Jul 17, 2:14 am)
Re: KVM overflows the stack, Avi Kivity, (Thu Jul 17, 2:42 am)
Re: KVM overflows the stack, Roland Dreier, (Thu Jul 17, 2:08 am)
Re: KVM overflows the stack, Dave Hansen, (Thu Jul 17, 10:06 am)
Re: KVM overflows the stack, Avi Kivity, (Thu Jul 17, 10:15 am)
Re: kvm causing memory corruption? now 2.6.26-rc4, Dave Hansen, (Mon Jun 16, 2:07 pm)
Re: kvm causing memory corruption? now 2.6.26-rc4, Dave Hansen, (Mon Jun 2, 8:59 pm)