[PATCH 14/23] tracehook: get_signal_to_deliver

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Roland McGrath
Date: Thursday, July 17, 2008 - 12:30 am

This defines the tracehook_get_signal() hook to allow tracing code to
slip in before normal signal dequeuing.  This lays the groundwork for
new tracing features that can inject synthetic signals outside the
normal queue or control the disposition of delivered signals.  The
calling convention lets tracehook_get_signal() decide both exactly
what will happen and what signal number to report in the handler/exit.

Signed-off-by: Roland McGrath <roland@redhat.com>
---
 include/linux/tracehook.h |   29 +++++++++++++++++++++++++++++
 kernel/signal.c           |   38 +++++++++++++++++++++++++++-----------
 2 files changed, 56 insertions(+), 11 deletions(-)

diff --git a/include/linux/tracehook.h b/include/linux/tracehook.h
index 3548694..42a0d7b 100644
--- a/include/linux/tracehook.h
+++ b/include/linux/tracehook.h
@@ -422,4 +422,33 @@ static inline int tracehook_consider_fatal_signal(struct task_struct *task,
 	return (task_ptrace(task) & PT_PTRACED) != 0;
 }
 
+/**
+ * tracehook_get_signal - deliver synthetic signal to traced task
+ * @task:		@current
+ * @regs:		task_pt_regs(@current)
+ * @info:		details of synthetic signal
+ * @return_ka:		sigaction for synthetic signal
+ *
+ * Return zero to check for a real pending signal normally.
+ * Return -1 after releasing the siglock to repeat the check.
+ * Return a signal number to induce an artifical signal delivery,
+ * setting *@info and *@return_ka to specify its details and behavior.
+ *
+ * The @return_ka->sa_handler value controls the disposition of the
+ * signal, no matter the signal number.  For %SIG_DFL, the return value
+ * is a representative signal to indicate the behavior (e.g. %SIGTERM
+ * for death, %SIGQUIT for core dump, %SIGSTOP for job control stop,
+ * %SIGTSTP for stop unless in an orphaned pgrp), but the signal number
+ * reported will be @info->si_signo instead.
+ *
+ * Called with @task->sighand->siglock held, before dequeuing pending signals.
+ */
+static inline int tracehook_get_signal(struct task_struct *task,
+				       struct pt_regs *regs,
+				       siginfo_t *info,
+				       struct k_sigaction *return_ka)
+{
+	return 0;
+}
+
 #endif	/* <linux/tracehook.h> */
diff --git a/kernel/signal.c b/kernel/signal.c
index 860afb8..1766c47 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1779,17 +1779,33 @@ relock:
 		    do_signal_stop(0))
 			goto relock;
 
-		signr = dequeue_signal(current, &current->blocked, info);
-		if (!signr)
-			break; /* will return 0 */
+		/*
+		 * Tracing can induce an artifical signal and choose sigaction.
+		 * The return value in @signr determines the default action,
+		 * but @info->si_signo is the signal number we will report.
+		 */
+		signr = tracehook_get_signal(current, regs, info, return_ka);
+		if (unlikely(signr < 0))
+			goto relock;
+		if (unlikely(signr != 0))
+			ka = return_ka;
+		else {
+			signr = dequeue_signal(current, &current->blocked,
+					       info);
 
-		if (signr != SIGKILL) {
-			signr = ptrace_signal(signr, info, regs, cookie);
 			if (!signr)
-				continue;
+				break; /* will return 0 */
+
+			if (signr != SIGKILL) {
+				signr = ptrace_signal(signr, info,
+						      regs, cookie);
+				if (!signr)
+					continue;
+			}
+
+			ka = &sighand->action[signr-1];
 		}
 
-		ka = &sighand->action[signr-1];
 		if (ka->sa.sa_handler == SIG_IGN) /* Do nothing.  */
 			continue;
 		if (ka->sa.sa_handler != SIG_DFL) {
@@ -1837,7 +1853,7 @@ relock:
 				spin_lock_irq(&sighand->siglock);
 			}
 
-			if (likely(do_signal_stop(signr))) {
+			if (likely(do_signal_stop(info->si_signo))) {
 				/* It released the siglock.  */
 				goto relock;
 			}
@@ -1858,7 +1874,7 @@ relock:
 
 		if (sig_kernel_coredump(signr)) {
 			if (print_fatal_signals)
-				print_fatal_signal(regs, signr);
+				print_fatal_signal(regs, info->si_signo);
 			/*
 			 * If it was able to dump core, this kills all
 			 * other threads in the group and synchronizes with
@@ -1867,13 +1883,13 @@ relock:
 			 * first and our do_group_exit call below will use
 			 * that value and ignore the one we pass it.
 			 */
-			do_coredump((long)signr, signr, regs);
+			do_coredump(info->si_signo, info->si_signo, regs);
 		}
 
 		/*
 		 * Death signals, no core dump.
 		 */
-		do_group_exit(signr);
+		do_group_exit(info->si_signo);
 		/* NOTREACHED */
 	}
 	spin_unlock_irq(&sighand->siglock);
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/23] tracehook, Roland McGrath, (Thu Jul 17, 12:25 am)
[PATCH 01/23] tracehook: add linux/tracehook.h, Roland McGrath, (Thu Jul 17, 12:27 am)
[PATCH 02/23] tracehook: exec, Roland McGrath, (Thu Jul 17, 12:28 am)
[PATCH 03/23] tracehook: unexport ptrace_notify, Roland McGrath, (Thu Jul 17, 12:28 am)
[PATCH 04/23] tracehook: exit, Roland McGrath, (Thu Jul 17, 12:28 am)
[PATCH 05/23] tracehook: clone, Roland McGrath, (Thu Jul 17, 12:29 am)
[PATCH 06/23] tracehook: vfork-done, Roland McGrath, (Thu Jul 17, 12:29 am)
[PATCH 07/23] tracehook: release_task, Roland McGrath, (Thu Jul 17, 12:29 am)
[PATCH 08/23] tracehook: tracehook_tracer_task, Roland McGrath, (Thu Jul 17, 12:29 am)
[PATCH 09/23] tracehook: tracehook_expect_breakpoints, Roland McGrath, (Thu Jul 17, 12:29 am)
[PATCH 10/23] tracehook: tracehook_signal_handler, Roland McGrath, (Thu Jul 17, 12:30 am)
[PATCH 11/23] tracehook: tracehook_consider_ignored_signal, Roland McGrath, (Thu Jul 17, 12:30 am)
[PATCH 12/23] tracehook: tracehook_consider_fatal_signal, Roland McGrath, (Thu Jul 17, 12:30 am)
[PATCH 13/23] tracehook: syscall, Roland McGrath, (Thu Jul 17, 12:30 am)
[PATCH 14/23] tracehook: get_signal_to_deliver, Roland McGrath, (Thu Jul 17, 12:30 am)
[PATCH 15/23] tracehook: job control, Roland McGrath, (Thu Jul 17, 12:30 am)
[PATCH 16/23] tracehook: death, Roland McGrath, (Thu Jul 17, 12:30 am)
[PATCH 17/23] tracehook: force signal_pending(), Roland McGrath, (Thu Jul 17, 12:30 am)
[PATCH 18/23] tracehook: TIF_NOTIFY_RESUME, Roland McGrath, (Thu Jul 17, 12:31 am)
[PATCH 19/23] tracehook: asm/syscall.h, Roland McGrath, (Thu Jul 17, 12:31 am)
[PATCH 20/23] tracehook: CONFIG_HAVE_ARCH_TRACEHOOK, Roland McGrath, (Thu Jul 17, 12:31 am)
[PATCH 21/23] tracehook: wait_task_inactive, Roland McGrath, (Thu Jul 17, 12:31 am)
[PATCH 22/23] task_current_syscall, Roland McGrath, (Thu Jul 17, 12:31 am)
[PATCH 23/23] /proc/PID/syscall, Roland McGrath, (Thu Jul 17, 12:31 am)
Re: [PATCH 00/23] tracehook, Andrew Morton, (Thu Jul 17, 12:39 am)
Re: [PATCH 00/23] tracehook, Roland McGrath, (Thu Jul 17, 1:11 am)
Re: [PATCH 00/23] tracehook, Andrew Morton, (Thu Jul 17, 1:30 am)
Re: [PATCH 00/23] tracehook, Roland McGrath, (Thu Jul 17, 1:37 am)
Re: [PATCH 01/23] tracehook: add linux/tracehook.h, Alexey Dobriyan, (Thu Jul 17, 1:48 am)
Re: [PATCH 00/23] tracehook, Andrew Morton, (Thu Jul 17, 1:51 am)
Re: [PATCH 01/23] tracehook: add linux/tracehook.h, Petr Tesarik, (Thu Jul 17, 4:06 am)
Re: [PATCH 01/23] tracehook: add linux/tracehook.h, Christoph Hellwig, (Thu Jul 17, 6:34 am)
Re: [PATCH 01/23] tracehook: add linux/tracehook.h, Alexey Dobriyan, (Thu Jul 17, 2:50 pm)
Re: [PATCH 23/23] /proc/PID/syscall, Alexey Dobriyan, (Thu Jul 17, 3:56 pm)
Re: [PATCH 00/23] tracehook, Ingo Molnar, (Fri Jul 18, 1:07 am)
Re: [PATCH 00/23] tracehook, David Miller, (Fri Jul 18, 2:20 am)
Re: [PATCH 00/23] tracehook, Andi Kleen, (Fri Jul 18, 4:24 am)
Re: [PATCH 00/23] tracehook, David Miller, (Fri Jul 18, 4:32 am)
Re: [PATCH 01/23] tracehook: add linux/tracehook.h, Petr Tesarik, (Fri Jul 18, 4:57 am)
Re: [PATCH 23/23] /proc/PID/syscall, Roland McGrath, (Mon Jul 21, 1:19 am)
Re: [PATCH 02/23] tracehook: exec, Christoph Hellwig, (Mon Jul 21, 1:49 am)
Re: [PATCH 00/23] tracehook, Roland McGrath, (Mon Jul 21, 2:59 am)
Re: [PATCH 00/23] tracehook, Roland McGrath, (Mon Jul 21, 3:54 am)
Re: [PATCH 00/23] tracehook, David Miller, (Mon Jul 21, 8:18 am)