Re: kvm causing memory corruption? now 2.6.26

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Dave Hansen <dave@...>
Cc: linux-kernel@vger.kernel.org <linux-kernel@...>, kvm-devel <kvm@...>, Anthony N. Liguori [imap] <aliguori@...>
Date: Thursday, July 17, 2008 - 1:38 am

Dave Hansen wrote:

Well that assert is plain wrong:

static int apic_match_dest(struct kvm_vcpu *vcpu, struct kvm_lapic *source,
               int short_hand, int dest, int dest_mode)
{
    int result = 0;
    struct kvm_lapic *target = vcpu->arch.apic;

    apic_debug("target %p, source %p, dest 0x%x, "
           "dest_mode 0x%x, short_hand 0x%x",
           target, source, dest, dest_mode, short_hand);

    ASSERT(!target);


It should be ASSERT(target), if anything.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
kvm causing memory corruption? ~2.6.25-rc6, Dave Hansen, (Tue Mar 25, 5:12 pm)
Re: kvm causing memory corruption? now 2.6.26-rc4, Dave Hansen, (Mon Jun 2, 6:30 pm)
Re: kvm causing memory corruption? now 2.6.26-rc4, Avi Kivity, (Wed Jun 4, 9:42 am)
Re: kvm causing memory corruption? now 2.6.26-rc4, Dave Hansen, (Fri Jun 6, 3:41 am)
Re: kvm causing memory corruption? now 2.6.26-rc4, Avi Kivity, (Thu Jun 12, 9:10 am)
Re: kvm causing memory corruption? now 2.6.26-rc8, Dave Hansen, (Tue Jul 15, 2:57 pm)
Re: kvm causing memory corruption? now 2.6.26, Dave Hansen, (Wed Jul 16, 5:44 pm)
Re: kvm causing memory corruption? now 2.6.26, Avi Kivity, (Thu Jul 17, 1:38 am)
KVM overflows the stack, Dave Hansen, (Wed Jul 16, 6:48 pm)
Re: KVM overflows the stack, Dave Hansen, (Thu Jul 17, 2:27 am)
Re: KVM overflows the stack, Avi Kivity, (Thu Jul 17, 1:52 am)
[PATCH] update kvm's anon_inodes.c for r/o bind mounts, Dave Hansen, (Thu Jul 17, 2:45 am)
Re: KVM overflows the stack, Dave Hansen, (Thu Jul 17, 2:14 am)
Re: KVM overflows the stack, Avi Kivity, (Thu Jul 17, 2:42 am)
Re: KVM overflows the stack, Roland Dreier, (Thu Jul 17, 2:08 am)
Re: KVM overflows the stack, Dave Hansen, (Thu Jul 17, 10:06 am)
Re: KVM overflows the stack, Avi Kivity, (Thu Jul 17, 10:15 am)
Re: kvm causing memory corruption? now 2.6.26-rc4, Dave Hansen, (Mon Jun 16, 2:07 pm)
Re: kvm causing memory corruption? now 2.6.26-rc4, Dave Hansen, (Mon Jun 2, 8:59 pm)