From: Jie Yang <jie.yang@atheros.com>

Full patch for the Atheros L1E Gigabit Ethernet driver.
Supportring AR8121, AR8113 and AR8114

Signed-off-by: Jie Yang <jie.yang @atheros.com>
---
Update on comments:
        1) Remove __attribute__(packet)  when structure has no holes
        2) remove typedef like "typedef enum {} xx_name; "
        3) remove "#ifdef module_param_array"
        4) move "#define PCI_DEVICE_ID_ATTANSIC_L1E   0x1026"  from
         include/linux/pci_ids.h to driver/net/atl1e/atl1e_main.c

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index d85b9d0..415688c 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2383,6 +2383,17 @@ config ATL1
          To compile this driver as a module, choose M here.  The module
          will be called atl1.

+config ATL1E
+        tristate "Atheros L1E Gigabit Ethernet support (EXPERIMENTAL)"
+        depends on PCI && EXPERIMENTAL
+        select CRC32
+        select MII
+        help
+          This driver supports the Atheros L1E gigabit ethernet adapter.
+
+          To compile this driver as a module, choose M here.  The module
+          will be called atl1e.
+
 endif # NETDEV_1000

 #
diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index 87703ff..1d93093 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
@@ -15,6 +15,7 @@ obj-$(CONFIG_EHEA) += ehea/
 obj-$(CONFIG_CAN) += can/
 obj-$(CONFIG_BONDING) += bonding/
 obj-$(CONFIG_ATL1) += atlx/
+obj-$(CONFIG_ATL1E) += atl1e/
 obj-$(CONFIG_GIANFAR) += gianfar_driver.o
 obj-$(CONFIG_TEHUTI) += tehuti.o

diff --git a/drivers/net/atl1e/Makefile b/drivers/net/atl1e/Makefile
new file mode 100644
index 0000000..bc11be8
--- /dev/null
+++ b/drivers/net/atl1e/Makefile
@@ -0,0 +1,2 @@
+obj-$(CONFIG_ATL1E)    += atl1e.o
+atl1e-objs             += atl1e_main.o atl1e_hw.o atl1e_ethtool.o atl1e_param.o
diff --git a/drivers/net/atl1e/atl1e.h b/drivers/net/atl1e/atl1e.h
new file mode 100644
index 0000000..b623bfa
--- ...
[ message continues ]

On Wed, 16 Jul 2008 17:42:52 +0800

Output of checkpatch (scripts/checkpatch.pl in kernel source).
Personally, I am not a whitespace bigot, and don't think
all the warnings in checkpatch have to be fixed.

----------
ERROR: patch seems to be corrupt (line wrapped?)
#121: FILE: drivers/net/atl1e/atl1e.h:9:
ree

WARNING: space prohibited between function name and open parenthesis '('
#212: FILE: drivers/net/atl1e/atl1e.h:97:
+       _tpd =3D (((_vlan) << (4)) | (((_vlan) >> 13) & 7) |\

ERROR: spaces required around that '=' (ctx:WxV)
#212: FILE: drivers/net/atl1e/atl1e.h:97:
+       _tpd =3D (((_vlan) << (4)) | (((_vlan) >> 13) & 7) |\
             ^

ERROR: code indent should use tabs where possible
#213: FILE: drivers/net/atl1e/atl1e.h:98:
+                (((_vlan) >> 9) & 8))$

WARNING: space prohibited between function name and open parenthesis '('
#216: FILE: drivers/net/atl1e/atl1e.h:101:
+       _vlan =3D (((_tpd) >> 8) | (((_tpd) & 0x77) << 9) |\

ERROR: spaces required around that '=' (ctx:WxV)
#216: FILE: drivers/net/atl1e/atl1e.h:101:
+       _vlan =3D (((_tpd) >> 8) | (((_tpd) & 0x77) << 9) |\
              ^

ERROR: code indent should use tabs where possible
#217: FILE: drivers/net/atl1e/atl1e.h:102:
+                  (((_tdp) & 0x88) << 5))$

ERROR: code indent should use tabs where possible
#234: FILE: drivers/net/atl1e/atl1e.h:119:
+                        ADVERTISE_10_FULL  |\$

ERROR: code indent should use tabs where possible
#235: FILE: drivers/net/atl1e/atl1e.h:120:
+                        ADVERTISE_100_HALF |\$

ERROR: code indent should use tabs where possible
#236: FILE: drivers/net/atl1e/atl1e.h:121:
+                        ADVERTISE_100_FULL |\$

ERROR: code indent should use tabs where possible
#237: FILE: drivers/net/atl1e/atl1e.h:122:
+                        ADVERTISE_1000_FULL)$

ERROR: spaces required around that '=' (ctx:WxV)
#359: FILE: drivers/net/atl1e/atl1e.h:244:
+       atl1e_dma_req_128 =3D 0,
                   ...
[ message continues ]

> Output of checkpatch (scripts/checkpatch.pl in kernel source).
 > Personally, I am not a whitespace bigot, and don't think
 > all the warnings in checkpatch have to be fixed.
 > 
 > ----------
 > ERROR: patch seems to be corrupt (line wrapped?)
 > #121: FILE: drivers/net/atl1e/atl1e.h:9:
 > ree
 > 
 > WARNING: space prohibited between function name and open parenthesis '('
 > #212: FILE: drivers/net/atl1e/atl1e.h:97:
 > +       _tpd =3D (((_vlan) << (4)) | (((_vlan) >> 13) & 7) |\

It's kind of pointless to run checkpatch on a corrupted patch (the email
was quoted-printable and you didn't decode it back to text).  Of course
it's also better to send non-mangled patches.

 - R.
--

[ message continues ]

On Thursday, July 17, 2008 12:36 AM

Hi, Roland
        I used outlook to send these patches, can you give me some
aderise on how to send non-mangled patches.

Best wishes
jie
--

[ message continues ]

You should use Thunderbird to send you patchs. And check it by send the 
mail to yourself.

Regards.
Wei Yongjun
--

[ message continues ]

On Thu, 17 Jul 2008 11:30:27 +0800

Alternatively, use a text file as attachment. It doesn't work as well but then
it comes through unmangled.
--

[ message continues ]