Re: acpi based pci gap calculation - v3

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andi Kleen <ak@...>
Cc: <akataria@...>, Ingo Molnar <mingo@...>, Brown, Len <len.brown@...>, LKML <linux-kernel@...>, linux-acpi <linux-acpi@...>, linux-pci@vger.kernel.org <linux-pci@...>, TJ <linux@...>
Date: Wednesday, July 16, 2008 - 8:03 pm

On Wednesday, July 16, 2008 9:33 am Andi Kleen wrote:

Well it's hardly last minute given that the merge window only opened a couple 
of days ago...

But beyond that, now that I've thought about it a bit more I'm not even sure 
the patch is really correct (though it works on my test machines).  Shouldn't 
we be looking at _PRS not _CRS?  And ideally we should try to find even more 
space, not less.  This patch made one of my machines lose quite a bit of 
space:

...
Allocating PCI resources starting at c0000000 (gap: bf000000:40f00000)
...
ACPI: PCI resources should start at c0000000 (gap: bf000000:31000000)
...

which is a step backwards.  With that in mind, I reverted the patch before 
asking Linus to pull; I'm hopeful we can do better though.  I'd love to never 
see "resource allocation failed" messages anymore.

Thanks,
Jesse
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
acpi based pci gap calculation - v3, Alok Kataria, (Tue Jul 15, 2:59 pm)
Re: acpi based pci gap calculation - v3, Andi Kleen, (Wed Jul 16, 1:42 am)
Re: acpi based pci gap calculation - v3, Jesse Barnes, (Tue Jul 15, 4:28 pm)
Re: acpi based pci gap calculation - v3, Alok Kataria, (Tue Jul 15, 4:54 pm)
Re: acpi based pci gap calculation - v3, Jesse Barnes, (Tue Jul 15, 6:53 pm)
Re: acpi based pci gap calculation - v3, Andi Kleen, (Wed Jul 16, 1:40 am)
Re: acpi based pci gap calculation - v3, Jesse Barnes, (Wed Jul 16, 12:06 pm)
Re: acpi based pci gap calculation - v3, Andi Kleen, (Wed Jul 16, 12:33 pm)
Re: acpi based pci gap calculation - v3, Jesse Barnes, (Wed Jul 16, 8:03 pm)
Re: acpi based pci gap calculation - v3, Alok Kataria, (Thu Jul 17, 5:31 pm)
Re: acpi based pci gap calculation - v3, Ingo Molnar, (Tue Jul 15, 7:07 pm)