Re: [BUGFIX][PATCH v2 0/2] configfs: Fix cleanup after mkdir() failure

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Joel Becker <Joel.Becker@...>
Cc: <linux-kernel@...>, <ocfs2-devel@...>
Date: Wednesday, July 16, 2008 - 1:56 pm

On Wed, Jul 16, 2008 at 10:27:03AM -0700, Joel Becker wrote:
in my

You requested me to move a BUG_ON() earlier (before the actual memory
allocation), and to update documentation. I'm quite in a hurry on other thi=
ngs,
so I'm delaying this (especially the documentation part for which I feel li=
ke a
new paragraph is needed).

 as

You may look at the retry loop in configfs_rmdir() and see=A0that locks nee=
d only
to be taken inside the loop, not outside. This would result in fewer lines =
for
exactly the same behavior.


Sorry for not being responsive enough. As mentioned above, I have more urge=
nt
things to work on right now.

Thanks,

Louis

--=20
Dr Louis Rilling			Kerlabs
Skype: louis.rilling			Batiment Germanium
Phone: (+33|0) 6 80 89 08 23		80 avenue des Buttes de Coesmes
http://www.kerlabs.com/			35700 Rennes
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [BUGFIX][PATCH v2 0/2] configfs: Fix cleanup after mkdir..., Louis Rilling, (Wed Jul 16, 1:56 pm)