Re: [PATCH 14/14] ACPI: Provide /sys/devices/system/cpu/cpuN/deconfigure

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Alex Chiang
Date: Tuesday, July 15, 2008 - 11:40 am

* Andi Kleen <ak@linux.intel.com>:

Hm, sorry.

I thought it would have been weird to send patches 1-13 / 14 to
linux-arch, but not send 14 / 14. Perhaps I should set a Reply-to:
in the future?


These are not new tables -- they are methods that live underneath
processor objects in the namespace.

Yes, they are specific to HP, but because they are methods, there
shouldn't be any collision with other vendors defining methods
with the same name (with the DMI check).


Yeah, I'm not totally happy with it either. But I'd like to
clarify -- are you concerned with the name of the interface
(deconfigure) or the "nothing happens until next boot" behavior?

Would it help if I renamed it to "enabled" and had something
like:

	echo 0 > enabled
	echo 1 > enabled
	cat enabled

And then that would map to vendor-specific behavior?

Or is it really the "nothing happens until next boot" thing that
bothers you?


Well, life would be a lot easier if we had a generic way to poke
at ACPI methods, but dev_acpi has been rejected multiple times.
;)

On a more serious note, my fear is that an interface like this is
not going to have agreement / clear semantics for a long time
because one vendor is going to want to call it 'deconfigured' and
another one might want to call it 'disabled' and a third might
want to call it 'puppy_dogs' and they'll all be kinda related but
not exactly the same.

That's why I was going down the road of creating at least one
generic interface, but with vendor-specific semantics.

Calling it 'enabled' might be a better idea.


We have HP ia64 systems shipping today that support this.

Thanks.

/ac

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/14] Introduce cpu_enabled_map and friends, Alex Chiang, (Mon Jul 14, 7:33 pm)
[PATCH 01/14] Introduce cpu_enabled_map and friends, Alex Chiang, (Mon Jul 14, 7:33 pm)
[PATCH 02/14] [M32R] Populate cpu_enabled_map, Alex Chiang, (Mon Jul 14, 7:33 pm)
[PATCH 03/14] [ALPHA] Populate cpu_enabled_map, Alex Chiang, (Mon Jul 14, 7:33 pm)
[PATCH 04/14] [ARM] Populate cpu_enabled_map, Alex Chiang, (Mon Jul 14, 7:34 pm)
[PATCH 05/14] [MIPS] Populate cpu_enabled_map, Alex Chiang, (Mon Jul 14, 7:34 pm)
[PATCH 06/14] [PARISC] Populate cpu_enabled_map, Alex Chiang, (Mon Jul 14, 7:34 pm)
[PATCH 07/14] [POWERPC] Populate cpu_enabled_map, Alex Chiang, (Mon Jul 14, 7:34 pm)
[PATCH 08/14] [S390] Populate cpu_enabled_map, Alex Chiang, (Mon Jul 14, 7:34 pm)
[PATCH 09/14] [SH] Populate cpu_enabled_map, Alex Chiang, (Mon Jul 14, 7:34 pm)
[PATCH 12/14] [IA64] Populate and use cpu_enabled_map, Alex Chiang, (Mon Jul 14, 7:34 pm)
[PATCH 11/14] x86: Populate cpu_enabled_map, Alex Chiang, (Mon Jul 14, 7:56 pm)
Re: [PATCH 01/14] Introduce cpu_enabled_map and friends, Matthew Wilcox, (Mon Jul 14, 8:15 pm)
Re: [PATCH 07/14] [POWERPC] Populate cpu_enabled_map, Benjamin Herrenschmidt, (Mon Jul 14, 10:51 pm)
Re: [PATCH 01/14] Introduce cpu_enabled_map and friends, Russell King, (Tue Jul 15, 3:21 am)
Re: [PATCH 01/14] Introduce cpu_enabled_map and friends, Alex Chiang, (Tue Jul 15, 10:57 am)
Re: [PATCH 01/14] Introduce cpu_enabled_map and friends, Matthew Wilcox, (Tue Jul 15, 11:16 am)
Re: [PATCH 14/14] ACPI: Provide /sys/devices/system/cpu/cp ..., Alex Chiang, (Tue Jul 15, 11:40 am)
Re: [PATCH 01/14] Introduce cpu_enabled_map and friends, Russell King, (Tue Jul 15, 11:48 am)
Re: [PATCH 01/14] Introduce cpu_enabled_map and friends, Alex Chiang, (Tue Jul 15, 12:15 pm)
Re: [PATCH 07/14] [POWERPC] Populate cpu_enabled_map, Alex Chiang, (Tue Jul 15, 6:04 pm)
Re: [PATCH 11/14] x86: Populate cpu_enabled_map, H. Peter Anvin, (Fri Jul 18, 1:00 pm)
Re: [PATCH 01/14] Introduce cpu_enabled_map and friends, Russell King, (Fri Jul 18, 2:44 pm)
Re: [PATCH 11/14] x86: Populate cpu_enabled_map, Alex Chiang, (Fri Jul 18, 4:06 pm)