login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
July
»
15
Re: [BUG][PATCH][pcmcia] cisinfo_t removal prevents card detection
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From: Manuel Lauss
Subject:
Re: [BUG][PATCH][pcmcia] cisinfo_t removal prevents card detection
Date: Tuesday, July 15, 2008 - 6:36 am
On Tue, Jul 15, 2008 at 03:26:15PM +0200, Marc Zyngier wrote:
quoted text
> Dominik, > > The commit > > c5081d5f4775b2a3f858f91151bbf9163e473075 (pcmcia: simplify > pccard_validate_cis) > > that entered mainline yesterday introduced a bug that prevents card > detection > on my platform (PXA255 based), and possibly others : > > @@ -1490,11 +1491,13 @@ int pccard_validate_cis(struct pcmcia_socket *s, > unsigned int function, cisinfo_ > ((tuple->TupleCode > 0x90) && (tuple->TupleCode < 0xff))) > reserved++; > } > - if ((info->Chains == MAX_TUPLES) || (reserved > 5) || > - ((!dev_ok || !ident_ok) && (info->Chains > 10))) > - info->Chains = 0; > + if ((count) || (reserved > 5) || > + ((!dev_ok || !ident_ok) && (count > 10))) > + count = 0; > > Since count starts at 1, condition is now always true, and count then > reset to 0. Restoring the comparaison to MAX_TUPLES makes everybody > happy... > > M. > > Signed-off-by: Marc Zyngier <marc.zyngier@altran.com> > > diff --git a/drivers/pcmcia/cistpl.c b/drivers/pcmcia/cistpl.c > index 9fcff0c..65129b5 100644 > --- a/drivers/pcmcia/cistpl.c > +++ b/drivers/pcmcia/cistpl.c > @@ -1490,7 +1490,7 @@ int pccard_validate_cis(struct pcmcia_socket *s, > unsigned int function, unsigned > ((tuple->TupleCode > 0x90) && (tuple->TupleCode < 0xff))) > reserved++; > } > - if ((count) || (reserved > 5) || > + if ((count == MAX_TUPLES) || (reserved > 5) || > ((!dev_ok || !ident_ok) && (count > 10))) > count = 0;
Confirmed: this fixes CF card detection on my SH and MIPS boards. Thanks! -- Manuel Lauss --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[BUG][PATCH][pcmcia] cisinfo_t removal prevents card detection
, Marc Zyngier
, (Tue Jul 15, 6:26 am)
Re: [BUG][PATCH][pcmcia] cisinfo_t removal prevents card d ...
, Manuel Lauss
, (Tue Jul 15, 6:36 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Kay Sievers
Re: char/tpm: tpm_infineon no longer loaded for HP 2510p laptop
Eric W. Biederman
[PATCH 8/8] sysfs: user namespaces: fix bug with clone(CLONE_NEWUSER) with fairsched
S K
Re: cpufreq doesn't seem to work in Intel Q9300
Bart Van Assche
Re: Is gcc thread-unsafe?
Greg Kroah-Hartman
[PATCH 20/36] Driver core: Call device_pm_add() after bus_add_device() in device_a...
git
:
Junio C Hamano
Re: git-svnimport
Junio C Hamano
Re: [PATCH] git-mv: Keep moved index entries inact
Johannes Schindelin
Re: [PATCH] Fix approxidate("never") to always return 0
A Large Angry SCM
Re: [RFC] origin link for cherry-pick and revert
Gabriel
[PATCH] When a remote is added but not fetched, tell the user.
linux-netdev
:
Daniel Lezcano
getsockopt(TCP_DEFER_ACCEPT) value change
David Miller
Re: 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying to ifenslave a seco...
Ingo Molnar
Re: [regression] nf_iterate(), BUG: unable to handle kernel NULL pointer dereference
Eric W. Biederman
[PATCH 14/20] net: Simplify pppol2tp pernet operations.
Jeff Kirsher
[net-2.6 PATCH 2/5] e1000e: increase swflag acquisition timeout for ICHx/PCH
git-commits-head
:
Linux Kernel Mailing List
ath9k_htc: Allocate URBs properly
Linux Kernel Mailing List
sm501: add power control callback
Linux Kernel Mailing List
MIPS: Cavium: Remove unused watchdog code.
Linux Kernel Mailing List
V4L/DVB (8976): af9015: Add USB ID for AVerMedia A309
Linux Kernel Mailing List
ARM: 5670/1: bcmring: add default configuration for bcmring arch
openbsd-misc
:
daniele.pilenga
snmpd hangs on 4.1 looking up hrSWRunTable
Jason Dixon
Re: any web management gui for pf ?
Christophe Rioux
Implementation example of snmp
Nick Holland
Re: booting openbsd on eee without cd-rom
Bryan Irvine
Re: OpenBSD 4.7 Released, May 19 2010
Colocation donated by:
Syndicate