Re: BUG: unable to handle kernel NULL pointer dereference at 000000000000000e (reset_prng_context)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Neil Horman <nhorman@...>
Cc: Simon Arlott <simon@...>, Linux Kernel Mailing List <linux-kernel@...>, Andrew Morton <akpm@...>, Herbert Xu <herbert@...>
Date: Tuesday, July 15, 2008 - 7:33 am

* Neil Horman <nhorman@tuxdriver.com> wrote:


i have just triggered this crash too. Please, when you know about bootup 
crashes in your code send a patch to the lkml thread so that people can 
apply it and have a working system.

Note that the new crypto/prng.c driver has very bad quality:

  total: 45 errors, 21 warnings, 1 checks, 410 lines checked

It has tons of completely unacceptable code mistakes in it.

And the commit log says:

|  commit b8454eebe380677789735fd6bad368af2e6b2d1e
|  Author: Neil Horman <nhorman@tuxdriver.com>
|  AuthorDate: Mon Jul 7 22:41:31 2008 +0800
|  CommitDate: Thu Jul 10 20:35:18 2008 +0800
|
|      crypto: prng - Deterministic CPRNG

i.e. this patch went in just 7 days from development to upstream, with 
insufficient review, with no linux-next presence at all (as of 
linux-next when v2.6.26 was released) and insufficient testing.

That's not how it's supposed to be.

	Ingo
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: BUG: unable to handle kernel NULL pointer dereference at..., Ingo Molnar, (Tue Jul 15, 7:33 am)