Home » Mailing list archives » linux-kernel » 2008 » July » 15

Re: [PATCH] Add SPI over GPIO driver

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ben Nizette <bn@...>
To: Michael Buesch <mb@...>
Cc: Andrew Morton <akpm@...>, Stephen Rothwell <sfr@...>, linux-kernel <linux-kernel@...>, David Brownell <david-b@...>, Piot Skamruk <piotr.skamruk@...>, <openwrt-devel@...>
Subject: Re: [PATCH] Add SPI over GPIO driver
Date: Tuesday, July 15, 2008 - 1:30 am

On Mon, 2008-07-14 at 21:09 +0200, Michael Buesch wrote:

Right, this is where spi-gpio is, please disregard my question in the
mmc-spi-gpio thing thread, it was domestic blindness after all :-)

Looks good overall.  I'm not sure that it need pretend to be
hotpluggable though (i.e. the board info can be hardwired so there's no
need for the board setup callback).  I guess this is to integrate with
your "dynamically create an mmc over spi over gpio" thinggy in the other
thread.  As I said there, I'd prefer that this platform device is
treated like other platform devices and any dynamicness be introduced at
in a more generic way.

What problem are you solving (or whole in board support are you
plugging) in this dynamic plugging of MMCs?

Thanks,
	--Ben.


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Add SPI over GPIO driver, Michael Buesch, (Mon Jul 14, 3:09 pm)
Re: [PATCH] Add SPI over GPIO driver, Ben Nizette, (Tue Jul 15, 1:30 am)
Re: [PATCH] Add SPI over GPIO driver, Michael Buesch, (Tue Jul 15, 9:05 am)
Re: [PATCH] Add SPI over GPIO driver, Andrew Morton, (Mon Jul 14, 4:43 pm)
Re: [PATCH] Add SPI over GPIO driver, Michael Buesch, (Tue Jul 15, 8:52 am)