login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
July
»
14
Re: [PATCH] Add SPI over GPIO driver
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Andrew Morton <akpm@...>
To: Michael Buesch <mb@...>
Cc: <sfr@...>, <linux-kernel@...>, <david-b@...>, <piotr.skamruk@...>, <openwrt-devel@...>
Subject:
Re: [PATCH] Add SPI over GPIO driver
Date: Monday, July 14, 2008 - 4:43 pm
On Mon, 14 Jul 2008 21:09:12 +0200 Michael Buesch <mb@bu3sch.de> wrote:
quoted text
> +static inline void do_spidelay(struct spi_device *dev, unsigned nsecs) > +{ > + struct spi_gpio *sp = spidev_to_sg(dev); > + > + if (!sp->info->no_spi_delay) > + ndelay(nsecs); > +} > + > +#define spidelay(nsecs) do { \ > + /* Steal the spi_device pointer from our caller. \ > + * The bitbang-API should probably get fixed here... */ \ > + do_spidelay(spi, nsecs); \ > + } while (0)
A macro which requires that its caller have a particular local variable is a bit nasty. Could we plan to add the spi_device* to spidelay() please? --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] Add SPI over GPIO driver
, Michael Buesch
, (Mon Jul 14, 3:09 pm)
Re: [PATCH] Add SPI over GPIO driver
, Ben Nizette
, (Tue Jul 15, 1:30 am)
Re: [PATCH] Add SPI over GPIO driver
, Michael Buesch
, (Tue Jul 15, 9:05 am)
Re: [PATCH] Add SPI over GPIO driver
, Andrew Morton
, (Mon Jul 14, 4:43 pm)
Re: [PATCH] Add SPI over GPIO driver
, Michael Buesch
, (Tue Jul 15, 8:52 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg Kroah-Hartman
[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Vladislav Bolkhovitin
Re: Integration of SCST in the mainstream Linux kernel
Andrew Morton
-mm merge plans for 2.6.23
Can E. Acar
Re: Wasting our Freedom
git
:
linux-netdev
:
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller
[GIT]: Networking
PJ Waskiewicz
[ANNOUNCE] ixgbe: Data Center Bridging (DCB) support for ixgbe
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
3 users
and
837 guests
online.
Online users
zeekec
Jeremy
redchiplawyer
Syndicate