Re: [git pull] core, x86: make LIST_POISON less deadly

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andi Kleen <andi@...>
Cc: Ingo Molnar <mingo@...>, Linux Kernel Mailing List <linux-kernel@...>, Andrew Morton <akpm@...>, Avi Kivity <avi@...>
Date: Monday, July 14, 2008 - 2:42 pm

On Mon, 14 Jul 2008, Andi Kleen wrote:

Don't be silly. It prints out the oops message.

People who cannot see where that oops is, and cannot be bothered to look 
at the register state aren't going to help _anyway_.

In fact, with the 0xdead... sequence, it's going to be *more* obvious than 
with some almost-kernel 0xffffc.. address, even if it's not showing up in 
the first line.

In other words, your whole argument is pure and utter sh*t. The page fault 
is _less_ readable than the GP fault.


And I disagree. Violently. 

The whole and ONLY point of poisoning is to get the fault.

With the canonical address, you won't get it reliably, and when you do get 
it, it's not obvious to decode.

End of discussion.

			Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[git pull] core, x86: make LIST_POISON less deadly, Ingo Molnar, (Mon Jul 14, 10:48 am)
Re: [git pull] core, x86: make LIST_POISON less deadly, Linus Torvalds, (Mon Jul 14, 11:03 am)
Re: [git pull] core, x86: make LIST_POISON less deadly, Linus Torvalds, (Mon Jul 14, 2:42 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Ingo Molnar, (Mon Jul 14, 11:12 am)
Re: [git pull] core, x86: make LIST_POISON less deadly, Linus Torvalds, (Mon Jul 14, 11:59 am)
Re: [git pull] core, x86: make LIST_POISON less deadly, Linus Torvalds, (Mon Jul 14, 2:42 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Linus Torvalds, (Mon Jul 14, 3:30 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Avi Kivity, (Mon Jul 14, 12:08 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Linus Torvalds, (Mon Jul 14, 12:26 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Ingo Molnar, (Mon Jul 14, 12:34 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Ingo Molnar, (Mon Jul 14, 12:07 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Avi Kivity, (Mon Jul 14, 11:53 am)