Home » Mailing list archives » linux-kernel » 2008 » July » 14

Re: usb-storage: quirk around v1.11 firmware on Nikon D4

Previous thread: Patch to add Broadcom TPM TIS device HID by eledisez on Friday, July 4, 2008 - 2:45 pm. (1 message)

Next thread: pata_it821x completely broken by Ondrej Zary on Friday, July 4, 2008 - 3:53 pm. (26 messages)
[view original message]
From: Dave Jones <davej@...>
To: Linux Kernel <linux-kernel@...>
Cc: <linux-usb@...>, <gregkh@...>
Subject: usb-storage: quirk around v1.11 firmware on Nikon D4
Date: Friday, July 4, 2008 - 3:33 pm

usb-storage: quirk around v1.11 firmware on Nikon D40


https://bugzilla.redhat.com/show_bug.cgi?id=454028

Just as in earlier firmware versions, we need to perform this

quirk for the latest version too.


Signed-off-by: Dave Jones <davej@redhat.com>


diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h

index 45fe366..cf03af1 100644

--- a/drivers/usb/storage/unusual_devs.h

+++ b/drivers/usb/storage/unusual_devs.h

@@ -364,6 +364,13 @@ UNUSUAL_DEV(  0x04b0, 0x0411, 0x0100, 0x0110,

 		US_SC_DEVICE, US_PR_DEVICE, NULL,

 		US_FL_FIX_CAPACITY),


+/* Reported by https://bugzilla.redhat.com/show_bug.cgi?id=454028 */

+UNUSUAL_DEV(  0x04b0, 0x0413, 0x0110, 0x0111,

+		"NIKON",

+		"NIKON DSC D40",

+		US_SC_DEVICE, US_PR_DEVICE, NULL,

+		US_FL_FIX_CAPACITY),

+

 /* Reported by Ortwin Glueck <odi@odi.ch> */

 UNUSUAL_DEV(  0x04b0, 0x0413, 0x0110, 0x0110,

 		"NIKON",


--

http://www.codemonkey.org.uk

--
[view original message]
From: Matthew Dharm <mdharm-kernel@...>
To: Dave Jones <davej@...>, Linux Kernel <linux-kernel@...>, <linux-usb@...>, <gregkh@...>
Subject: Re: usb-storage: quirk around v1.11 firmware on Nikon D4
Date: Friday, July 4, 2008 - 3:42 pm

NAK.


Two entries should not have overlapping version ranges, unless

configuration options are involved.


Why not just extend the range of the existing entry?


Matt


--=20

Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.=

net=20

Maintainer, Linux USB Mass Storage Driver


P:  How about "Web Designer"?

DP: I'd like a name that people won't laugh at.

					-- Pitr and Dust Puppy

User Friendly, 12/6/1997
[view original message]
From: Dave Jones <davej@...>
To: Linux Kernel <linux-kernel@...>, <linux-usb@...>, <gregkh@...>
Subject: Re: usb-storage: quirk around v1.11 firmware on Nikon D4
Date: Friday, July 4, 2008 - 3:59 pm

usb-storage: quirk around v1.11 firmware on Nikon D40


https://bugzilla.redhat.com/show_bug.cgi?id=454028

Just as in earlier firmware versions, we need to perform this

quirk for the latest version too.


Signed-off-by: Dave Jones <davej@redhat.com>


diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h

index 39a7c11..1a497e9 100644

--- a/drivers/usb/storage/unusual_devs.h

+++ b/drivers/usb/storage/unusual_devs.h

@@ -358,7 +358,7 @@ UNUSUAL_DEV(  0x04b0, 0x040f, 0x0100, 0x0200,

 		US_FL_FIX_CAPACITY),


 /* Reported by Emil Larsson <emil@swip.net> */

-UNUSUAL_DEV(  0x04b0, 0x0411, 0x0100, 0x0110,

+UNUSUAL_DEV(  0x04b0, 0x0411, 0x0100, 0x0111,

 		"NIKON",

 		"NIKON DSC D80",

 		US_SC_DEVICE, US_PR_DEVICE, NULL,


--

http://www.codemonkey.org.uk

--
[view original message]
From: Alan Stern <stern@...>
To: Dave Jones <davej@...>
Cc: Linux Kernel <linux-kernel@...>, <linux-usb@...>, <gregkh@...>
Subject: Re: usb-storage: quirk around v1.11 firmware on Nikon D4
Date: Friday, July 4, 2008 - 6:09 pm

You updated the entry for the D80, not the D40.  Maybe they both need

to be updated?


Alan Stern


--
[view original message]
From: Dave Jones <davej@...>
To: Alan Stern <stern@...>
Cc: Linux Kernel <linux-kernel@...>, <linux-usb@...>, <gregkh@...>
Subject: Re: usb-storage: quirk around v1.11 firmware on Nikon D4
Date: Monday, July 14, 2008 - 1:28 pm

On Fri, Jul 04, 2008 at 06:09:25PM -0400, Alan Stern wrote:

 > On Fri, 4 Jul 2008, Dave Jones wrote:

 >

 > > usb-storage: quirk around v1.11 firmware on Nikon D40

 > ...

 > > -UNUSUAL_DEV(  0x04b0, 0x0411, 0x0100, 0x0110,

 > > +UNUSUAL_DEV(  0x04b0, 0x0411, 0x0100, 0x0111,

 > >  		"NIKON",

 > >  		"NIKON DSC D80",

 >

 > You updated the entry for the D80, not the D40.  Maybe they both need

 > to be updated?


usb-storage: quirk around v1.11 firmware on Nikon D40


https://bugzilla.redhat.com/show_bug.cgi?id=454028

Just as in earlier firmware versions, we need to perform this

quirk for the latest version too.


Speculatively do the entry for the D80 too, as they seem to

have the same firmware problems historically.


Signed-off-by: Dave Jones <davej@redhat.com>


diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h

index 39a7c11..c0b9d10 100644

--- a/drivers/usb/storage/unusual_devs.h

+++ b/drivers/usb/storage/unusual_devs.h

@@ -358,14 +358,14 @@ UNUSUAL_DEV(  0x04b0, 0x040f, 0x0100, 0x0200,

 		US_FL_FIX_CAPACITY),


 /* Reported by Emil Larsson <emil@swip.net> */

-UNUSUAL_DEV(  0x04b0, 0x0411, 0x0100, 0x0110,

+UNUSUAL_DEV(  0x04b0, 0x0411, 0x0100, 0x0111,

 		"NIKON",

 		"NIKON DSC D80",

 		US_SC_DEVICE, US_PR_DEVICE, NULL,

 		US_FL_FIX_CAPACITY),


 /* Reported by Ortwin Glueck <odi@odi.ch> */

-UNUSUAL_DEV(  0x04b0, 0x0413, 0x0110, 0x0110,

+UNUSUAL_DEV(  0x04b0, 0x0413, 0x0110, 0x0111,

 		"NIKON",

 		"NIKON DSC D40",

 		US_SC_DEVICE, US_PR_DEVICE, NULL,


--

http://www.codemonkey.org.uk

--
[view original message]
From: <gregkh@...>
To: <davej@...>, <gregkh@...>, <johannes@...>, <linux-kernel@...>, <stable@...>, <stern@...>
Subject: patch usb-usb-storage-quirk-around-v1.11-firmware-on-nikon-d4.patch added to gregkh-2.6 tree
Date: Thursday, July 31, 2008 - 3:58 pm

This is a note to let you know that I've just added the patch titled


     Subject: USB: usb-storage: quirk around v1.11 firmware on Nikon D4


to my gregkh-2.6 tree.  Its filename is


     usb-usb-storage-quirk-around-v1.11-firmware-on-nikon-d4.patch


This tree can be found at

    http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/


From davej@redhat.com  Thu Jul 31 10:32:27 2008

From: Dave Jones <davej@redhat.com>

Date: Mon, 14 Jul 2008 13:28:34 -0400

Subject: USB: usb-storage: quirk around v1.11 firmware on Nikon D4

To: Alan Stern <stern@rowland.harvard.edu>

Cc: Linux Kernel <linux-kernel@vger.kernel.org>, linux-usb@vger.kernel.org, gregkh@suse.de

Message-ID: <20080714172834.GA23016@redhat.com>

Content-Disposition: inline


usb-storage: quirk around v1.11 firmware on Nikon D40


https://bugzilla.redhat.com/show_bug.cgi?id=454028

Just as in earlier firmware versions, we need to perform this

quirk for the latest version too.


Speculatively do the entry for the D80 too, as they seem to

have the same firmware problems historically.


Signed-off-by: Dave Jones <davej@redhat.com>

Cc: Johannes Berg <johannes@sipsolutions.net>

Cc: Alan Stern <stern@rowland.harvard.edu>

Cc: stable <stable@kernel.org>

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>


---

 drivers/usb/storage/unusual_devs.h |    4 ++--

 1 file changed, 2 insertions(+), 2 deletions(-)


--- a/drivers/usb/storage/unusual_devs.h

+++ b/drivers/usb/storage/unusual_devs.h

@@ -356,14 +356,14 @@ UNUSUAL_DEV(  0x04b0, 0x040f, 0x0100, 0x

 		US_FL_FIX_CAPACITY),


 /* Reported by Emil Larsson <emil@swip.net> */

-UNUSUAL_DEV(  0x04b0, 0x0411, 0x0100, 0x0110,

+UNUSUAL_DEV(  0x04b0, 0x0411, 0x0100, 0x0111,

 		"NIKON",

 		"NIKON DSC D80",

 		US_SC_DEVICE, US_PR_DEVICE, NULL,

 		US_FL_FIX_CAPACITY),


 /* Reported by Ortwin Glueck <odi@odi.ch> */

-UNUSUAL_DEV(  0x04b0, 0x0413, 0x0110, 0x0110,

+UNUSUAL_DEV(  0x04b0, 0x0413, 0x01...
[ message continues ]
[view original message]
From: Dave Jones <davej@...>
To: Alan Stern <stern@...>
Cc: Linux Kernel <linux-kernel@...>, <linux-usb@...>, <gregkh@...>
Subject: Re: usb-storage: quirk around v1.11 firmware on Nikon D4
Date: Friday, July 4, 2008 - 6:20 pm

On Fri, Jul 04, 2008 at 06:09:25PM -0400, Alan Stern wrote:

 > On Fri, 4 Jul 2008, Dave Jones wrote:

 >

 > > usb-storage: quirk around v1.11 firmware on Nikon D40

 > ...

 > > -UNUSUAL_DEV(  0x04b0, 0x0411, 0x0100, 0x0110,

 > > +UNUSUAL_DEV(  0x04b0, 0x0411, 0x0100, 0x0111,

 > >  		"NIKON",

 > >  		"NIKON DSC D80",

 >

 > You updated the entry for the D80, not the D40.


argh.


 >  Maybe they both need to be updated?


Maybe. I'm not familiar with how similar the firmware is between

those two cameras.  The version numbering would certainly suggest that

is the case, but should we take a chance and guess, or wait

until a user complains?


	Dave


--

http://www.codemonkey.org.uk

--
Previous thread: Patch to add Broadcom TPM TIS device HID by eledisez on Friday, July 4, 2008 - 2:45 pm. (1 message)

Next thread: pata_it821x completely broken by Ondrej Zary on Friday, July 4, 2008 - 3:53 pm. (26 messages)