Re: [git pull] core, x86: make LIST_POISON less deadly

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Avi Kivity <avi@...>
Cc: Ingo Molnar <mingo@...>, Linux Kernel Mailing List <linux-kernel@...>, Andrew Morton <akpm@...>
Date: Monday, July 14, 2008 - 12:26 pm

On Mon, 14 Jul 2008, Avi Kivity wrote:

I wouldn't worry too much - it's going to be pretty visible anyway.

The only thing I _would_ worry about is the AMD prefetch bug - some AMD 
cores raise a spurious page fault for prefetch instructions, and we ignore 
it.

I _think_ that bug is a pure TLB issue and would never trigger for an 
address that doesn't do page fault handling at all because it gets caught 
in the "is the address valid" code, but it does make me go "Hmm".

See

	http://lkml.org/lkml/2003/9/10/397

from Rich Brunner. The AMD errata listing does say just page fault, and 
does talk about speculative TLB reloads, so I think we're all good.

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[git pull] core, x86: make LIST_POISON less deadly, Ingo Molnar, (Mon Jul 14, 10:48 am)
Re: [git pull] core, x86: make LIST_POISON less deadly, Linus Torvalds, (Mon Jul 14, 11:03 am)
Re: [git pull] core, x86: make LIST_POISON less deadly, Linus Torvalds, (Mon Jul 14, 2:42 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Ingo Molnar, (Mon Jul 14, 11:12 am)
Re: [git pull] core, x86: make LIST_POISON less deadly, Linus Torvalds, (Mon Jul 14, 11:59 am)
Re: [git pull] core, x86: make LIST_POISON less deadly, Linus Torvalds, (Mon Jul 14, 2:42 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Linus Torvalds, (Mon Jul 14, 3:30 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Avi Kivity, (Mon Jul 14, 12:08 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Linus Torvalds, (Mon Jul 14, 12:26 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Ingo Molnar, (Mon Jul 14, 12:34 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Ingo Molnar, (Mon Jul 14, 12:07 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Avi Kivity, (Mon Jul 14, 11:53 am)