Re: [git pull] core, x86: make LIST_POISON less deadly

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: Linux Kernel Mailing List <linux-kernel@...>, Andrew Morton <akpm@...>, Avi Kivity <avi@...>
Date: Monday, July 14, 2008 - 11:03 am

On Mon, 14 Jul 2008, Ingo Molnar wrote:

This looks like a singularly bad pointer value on x86-64.

Why not pick something that is *guaranteed* to fault? The above looks like 
any future setup that supports 41 bits of addressing and has extended the 
page tables (yes, it will happen eventually) will find that to be a 
perfectly valid address?

It's also visually confusing, since it's visually very close to a real 
kernel pointer too.

Grr.

Why not use something sane like 0xdead000000000000, which has the high bit 
set but very fundamentally isn't a valid pointer, and never will be? And 
which is a *lot* more visually obvious too!

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[git pull] core, x86: make LIST_POISON less deadly, Ingo Molnar, (Mon Jul 14, 10:48 am)
Re: [git pull] core, x86: make LIST_POISON less deadly, Linus Torvalds, (Mon Jul 14, 11:03 am)
Re: [git pull] core, x86: make LIST_POISON less deadly, Linus Torvalds, (Mon Jul 14, 2:42 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Ingo Molnar, (Mon Jul 14, 11:12 am)
Re: [git pull] core, x86: make LIST_POISON less deadly, Linus Torvalds, (Mon Jul 14, 11:59 am)
Re: [git pull] core, x86: make LIST_POISON less deadly, Linus Torvalds, (Mon Jul 14, 2:42 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Linus Torvalds, (Mon Jul 14, 3:30 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Avi Kivity, (Mon Jul 14, 12:08 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Linus Torvalds, (Mon Jul 14, 12:26 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Ingo Molnar, (Mon Jul 14, 12:34 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Ingo Molnar, (Mon Jul 14, 12:07 pm)
Re: [git pull] core, x86: make LIST_POISON less deadly, Avi Kivity, (Mon Jul 14, 11:53 am)