Re: Multiple MSI, take 3

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <benh@...>
Cc: Suresh Siddha <suresh.b.siddha@...>, Matthew Wilcox <matthew@...>, linux-pci@vger.kernel.org <linux-pci@...>, linux-kernel@vger.kernel.org <linux-kernel@...>, grundler@parisc-linux.org <grundler@...>, mingo@elte.hu <mingo@...>, tglx@linutronix.de <tglx@...>, jgarzik@pobox.com <jgarzik@...>, linux-ide@vger.kernel.org <linux-ide@...>, jbarnes@virtuousgeek.org <jbarnes@...>, rdunlap@xenotime.net <rdunlap@...>, mtk.manpages@gmail.com <mtk.manpages@...>
Date: Sunday, July 13, 2008 - 7:29 pm

Ben.  Multi-MSI is a crap hardware design.  Why do you think we have
MSI-X?  MSI-X as specced is a properly operating irq controller that
we don't need kludges to support.  Multi-MSI with a full set of
kludges almost work but not quite fits the linux irq model.

Any hardware designer who choose to implement Multi-MSI instead of
MSI-X was not really concerned about having a high performance device.

If we can find a way to model the portable capabilities of Multi-MSI
cleanly then we can support it, and our drivers and our users and our
intermediate layers won't get surprised.

So far we have too close fits but neither model really works.

Further this is all about driver optimization, so none of this is
necessary to have working hardware.  Which makes kludges much less
appropriate.  Modelling Multi-MSI irqs as normal irqs requires a lot
of nasty kludges.

One of the kludges is allocating a continuous chunk of irq targets,
and the resulting fragmentation issues that you get when you start
allowing different sized allocations.

Overall if Multi-MSI was to become common I think we would really
regret it.

Eric
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Multiple MSI, take 3, Matthew Wilcox, (Thu Jul 10, 8:57 pm)
Re: Multiple MSI, take 3, Jike Song, (Fri Sep 26, 1:30 am)
Re: Multiple MSI, take 3, Matthew Wilcox, (Sat Sep 27, 3:04 pm)
Re: Multiple MSI, take 3, Eric W. Biederman, (Fri Jul 11, 6:06 am)
Re: Multiple MSI, take 3, Suresh Siddha, (Fri Jul 11, 5:59 pm)
Re: Multiple MSI, take 3, Eric W. Biederman, (Fri Jul 11, 6:59 pm)
Re: Multiple MSI, take 3, Benjamin Herrenschmidt, (Fri Jul 11, 11:52 pm)
Re: Multiple MSI, take 3, Eric W. Biederman, (Sat Jul 12, 12:41 am)
Re: Multiple MSI, take 3, Benjamin Herrenschmidt, (Sat Jul 12, 3:36 am)
Re: Multiple MSI, take 3, Eric W. Biederman, (Sun Jul 13, 6:30 pm)
Re: Multiple MSI, take 3, Benjamin Herrenschmidt, (Sun Jul 13, 6:44 pm)
Re: Multiple MSI, take 3, Eric W. Biederman, (Sun Jul 13, 7:29 pm)
Re: Multiple MSI, take 3, Benjamin Herrenschmidt, (Sun Jul 13, 8:17 pm)
Re: Multiple MSI, take 3, David Miller, (Sun Jul 13, 8:44 pm)
Re: Multiple MSI, take 3, Eric W. Biederman, (Sun Jul 13, 10:03 pm)
Re: Multiple MSI, take 3, David Miller, (Sun Jul 13, 11:19 pm)
Re: Multiple MSI, take 3, Suresh Siddha, (Fri Jul 11, 7:15 pm)
Re: Multiple MSI, take 3, Eric W. Biederman, (Fri Jul 11, 7:59 pm)
Re: Multiple MSI, take 3, Matthew Wilcox, (Fri Jul 11, 6:23 am)
Re: Multiple MSI, take 3, Eric W. Biederman, (Fri Jul 11, 7:34 am)
Re: Multiple MSI, take 3, Matthew Wilcox, (Fri Jul 11, 8:17 am)
Re: Multiple MSI, take 3, Matthew Wilcox, (Fri Jul 11, 11:10 am)
Re: Multiple MSI, take 3, Eric W. Biederman, (Fri Jul 11, 7:05 am)
Re: Multiple MSI, take 3, David Miller, (Fri Jul 11, 6:32 am)
Re: Multiple MSI, take 3, Matthew Wilcox, (Fri Jul 11, 6:41 am)
[PATCH] Rewrite MSI-HOWTO, Matthew Wilcox, (Thu Jul 10, 9:00 pm)
Re: [PATCH] Rewrite MSI-HOWTO, Grant Grundler, (Fri Sep 26, 2:42 am)
[PATCH] PCI: Add support for multiple MSI, Matthew Wilcox, (Thu Jul 10, 8:59 pm)
Re: [PATCH] PCI: Add support for multiple MSI, Hidetoshi Seto, (Fri Jul 11, 4:28 am)
Re: [PATCH] PCI: Add support for multiple MSI, Benjamin Herrenschmidt, (Fri Jul 11, 11:45 pm)
Re: [PATCH] PCI: Add support for multiple MSI, Matthew Wilcox, (Fri Jul 11, 5:45 am)
[PATCH] AHCI: Request multiple MSIs, Matthew Wilcox, (Thu Jul 10, 9:00 pm)
[PATCH] PCI MSI: Replace 'type' with 'is_msix', Matthew Wilcox, (Thu Jul 10, 8:59 pm)
[PATCH] x86-64: Support for multiple MSIs, Matthew Wilcox, (Thu Jul 10, 9:00 pm)
Re: [PATCH] x86-64: Support for multiple MSIs, Kenji Kaneshige, (Fri Jul 11, 12:50 am)
Re: [PATCH] x86-64: Support for multiple MSIs, Matthew Wilcox, (Fri Jul 11, 4:50 am)
Re: [PATCH] x86-64: Support for multiple MSIs, Kenji Kaneshige, (Sun Jul 13, 9:08 pm)