Re: Multiple MSI, take 3

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <benh@...>
Cc: Suresh Siddha <suresh.b.siddha@...>, Matthew Wilcox <matthew@...>, linux-pci@vger.kernel.org <linux-pci@...>, linux-kernel@vger.kernel.org <linux-kernel@...>, grundler@parisc-linux.org <grundler@...>, mingo@elte.hu <mingo@...>, tglx@linutronix.de <tglx@...>, jgarzik@pobox.com <jgarzik@...>, linux-ide@vger.kernel.org <linux-ide@...>, jbarnes@virtuousgeek.org <jbarnes@...>, rdunlap@xenotime.net <rdunlap@...>, mtk.manpages@gmail.com <mtk.manpages@...>
Date: Sunday, July 13, 2008 - 6:30 pm

Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:


You are correct.  Using the existing irq handling logic will cause us
to drop irqs and to loose information if two messages are sent close
to each other.  Which is very nasty.

With a little care we can avoid that problem by having a 32 bit bitmap
of which sub irqs have fired so we can make all of them pending
without loosing information.  That does requires a new handle_irq method.

One of the primary purposes of masking irqs in hardware is to prevent
them from screaming.  Unlikely with edge triggered irqs but not a capability
I would like to give up.

Multi-msi has the problem that cpu affinity can not be changed on a
per message basis without an iommu.  Which is a portability problem
and a problem on common architectures.

Therefore to support multi-msi it must be handled as a special case, we can not
treat the individual messages like normal irqs.

Eric
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Multiple MSI, take 3, Matthew Wilcox, (Thu Jul 10, 8:57 pm)
Re: Multiple MSI, take 3, Jike Song, (Fri Sep 26, 1:30 am)
Re: Multiple MSI, take 3, Matthew Wilcox, (Sat Sep 27, 3:04 pm)
Re: Multiple MSI, take 3, Eric W. Biederman, (Fri Jul 11, 6:06 am)
Re: Multiple MSI, take 3, Suresh Siddha, (Fri Jul 11, 5:59 pm)
Re: Multiple MSI, take 3, Eric W. Biederman, (Fri Jul 11, 6:59 pm)
Re: Multiple MSI, take 3, Benjamin Herrenschmidt, (Fri Jul 11, 11:52 pm)
Re: Multiple MSI, take 3, Eric W. Biederman, (Sat Jul 12, 12:41 am)
Re: Multiple MSI, take 3, Benjamin Herrenschmidt, (Sat Jul 12, 3:36 am)
Re: Multiple MSI, take 3, Eric W. Biederman, (Sun Jul 13, 6:30 pm)
Re: Multiple MSI, take 3, Benjamin Herrenschmidt, (Sun Jul 13, 6:44 pm)
Re: Multiple MSI, take 3, Eric W. Biederman, (Sun Jul 13, 7:29 pm)
Re: Multiple MSI, take 3, Benjamin Herrenschmidt, (Sun Jul 13, 8:17 pm)
Re: Multiple MSI, take 3, David Miller, (Sun Jul 13, 8:44 pm)
Re: Multiple MSI, take 3, Eric W. Biederman, (Sun Jul 13, 10:03 pm)
Re: Multiple MSI, take 3, David Miller, (Sun Jul 13, 11:19 pm)
Re: Multiple MSI, take 3, Suresh Siddha, (Fri Jul 11, 7:15 pm)
Re: Multiple MSI, take 3, Eric W. Biederman, (Fri Jul 11, 7:59 pm)
Re: Multiple MSI, take 3, Matthew Wilcox, (Fri Jul 11, 6:23 am)
Re: Multiple MSI, take 3, Eric W. Biederman, (Fri Jul 11, 7:34 am)
Re: Multiple MSI, take 3, Matthew Wilcox, (Fri Jul 11, 8:17 am)
Re: Multiple MSI, take 3, Matthew Wilcox, (Fri Jul 11, 11:10 am)
Re: Multiple MSI, take 3, Eric W. Biederman, (Fri Jul 11, 7:05 am)
Re: Multiple MSI, take 3, David Miller, (Fri Jul 11, 6:32 am)
Re: Multiple MSI, take 3, Matthew Wilcox, (Fri Jul 11, 6:41 am)
[PATCH] Rewrite MSI-HOWTO, Matthew Wilcox, (Thu Jul 10, 9:00 pm)
Re: [PATCH] Rewrite MSI-HOWTO, Grant Grundler, (Fri Sep 26, 2:42 am)
[PATCH] PCI: Add support for multiple MSI, Matthew Wilcox, (Thu Jul 10, 8:59 pm)
Re: [PATCH] PCI: Add support for multiple MSI, Hidetoshi Seto, (Fri Jul 11, 4:28 am)
Re: [PATCH] PCI: Add support for multiple MSI, Benjamin Herrenschmidt, (Fri Jul 11, 11:45 pm)
Re: [PATCH] PCI: Add support for multiple MSI, Matthew Wilcox, (Fri Jul 11, 5:45 am)
[PATCH] AHCI: Request multiple MSIs, Matthew Wilcox, (Thu Jul 10, 9:00 pm)
[PATCH] PCI MSI: Replace 'type' with 'is_msix', Matthew Wilcox, (Thu Jul 10, 8:59 pm)
[PATCH] x86-64: Support for multiple MSIs, Matthew Wilcox, (Thu Jul 10, 9:00 pm)
Re: [PATCH] x86-64: Support for multiple MSIs, Kenji Kaneshige, (Fri Jul 11, 12:50 am)
Re: [PATCH] x86-64: Support for multiple MSIs, Matthew Wilcox, (Fri Jul 11, 4:50 am)
Re: [PATCH] x86-64: Support for multiple MSIs, Kenji Kaneshige, (Sun Jul 13, 9:08 pm)