Re: [PATCH] x86_64: fix delayed signals

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andi Kleen <andi@...>
Cc: Ingo Molnar <mingo@...>, Roland McGrath <roland@...>, Thomas Gleixner <tglx@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, Elias Oltmanns <eo@...>, Török Edwin <edwintorok@...>, Arjan van de Ven <arjan@...>
Date: Sunday, July 13, 2008 - 3:08 pm

On Sun, 13 Jul 2008, Andi Kleen wrote:

I didn't take a look at the source, but I literally think that the 'ls' 
SIGINT handler is something like

	static void sigint(int signr)
	{
		exit_with_sigint = 1;
	}

and then in the output routine it does a

	if (exit_with_sigint) {
		signal(SIGINT, SIG_DFL);
		kill(-1, SIGINT);
	}

at the end because that's the only thing that explains that it always 
exits after printing the _first_ line of output (ignoring the header - it 
obviously doesn't have that "if (exit_with_sigint)" test in that 
code-path).

Sad. Horrible crap. It means that it totally disables the kernels ability 
to make fatal signals break out of disk wait etc. It's also totally 
_unnecessary_, because 'ls' shouldn't even bother to block signals until 
just before it starts doing the printout.

Oh well. You can't expect too much of user level programmers.

			Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] x86_64: fix delayed signals, Roland McGrath, (Thu Jul 10, 5:50 pm)
Re: [PATCH] x86_64: fix delayed signals, Ingo Molnar, (Fri Jul 11, 1:46 am)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Fri Jul 11, 1:58 pm)
Re: [PATCH] x86_64: fix delayed signals, Andi Kleen, (Sat Jul 12, 8:27 am)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Sat Jul 12, 1:41 pm)
Re: [PATCH] x86_64: fix delayed signals, Andi Kleen, (Sun Jul 13, 5:38 am)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Sun Jul 13, 1:32 pm)
Re: [PATCH] x86_64: fix delayed signals, Andi Kleen, (Sun Jul 13, 2:59 pm)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Sun Jul 13, 3:08 pm)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Fri Jul 11, 2:10 pm)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Fri Jul 11, 4:37 pm)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Fri Jul 11, 7:22 pm)
Re: [PATCH] x86_64: fix delayed signals, Török Edwin, (Sat Jul 12, 6:32 am)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Sat Jul 12, 1:29 pm)
Re: [PATCH] x86_64: fix delayed signals, Török Edwin, (Sat Jul 12, 4:26 pm)
Re: [PATCH] x86_64: fix delayed signals, Denys Vlasenko, (Sat Jul 12, 4:57 pm)
Re: [PATCH] x86_64: fix delayed signals, Oleg Nesterov, (Sun Jul 13, 6:46 am)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Sun Jul 13, 2:36 pm)
Re: [PATCH] x86_64: fix delayed signals, Peter T. Breuer, (Sun Jul 13, 2:45 pm)
Re: [PATCH] x86_64: fix delayed signals, Denys Vlasenko, (Sun Jul 13, 8:34 am)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Sat Jul 12, 4:47 pm)
Re: [PATCH] x86_64: fix delayed signals, Török Edwin, (Sat Jul 12, 9:42 am)
Re: [PATCH] x86_64: fix delayed signals, Arjan van de Ven, (Sat Jul 12, 10:55 am)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Sat Jul 12, 2:00 pm)
Re: [PATCH] x86_64: fix delayed signals, Arjan van de Ven, (Sat Jul 12, 2:15 pm)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Sat Jul 12, 2:28 pm)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Fri Jul 11, 2:31 pm)
Re: [PATCH] x86_64: fix delayed signals, Arjan van de Ven, (Fri Jul 11, 6:53 pm)
Re: [PATCH] x86_64: fix delayed signals, Török Edwin, (Sat Jul 12, 6:33 am)
Re: [PATCH] x86_64: fix delayed signals, Roland McGrath, (Fri Jul 11, 2:07 pm)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Fri Jul 11, 2:16 pm)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Fri Jul 11, 2:17 pm)
Re: [PATCH] x86_64: fix delayed signals, Elias Oltmanns, (Fri Jul 11, 8:24 am)
Re: [PATCH] x86_64: fix delayed signals, Török Edwin, (Fri Jul 11, 7:13 am)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Thu Jul 10, 6:06 pm)
Re: [PATCH] x86_64: fix delayed signals, Roland McGrath, (Thu Jul 10, 6:42 pm)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Thu Jul 10, 6:51 pm)
Re: [PATCH] x86_64: fix delayed signals, Roland McGrath, (Thu Jul 10, 8:52 pm)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Thu Jul 10, 9:48 pm)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Thu Jul 10, 10:02 pm)
Re: [PATCH] x86_64: fix delayed signals, Andi Kleen, (Sat Jul 12, 8:24 am)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Thu Jul 10, 10:22 pm)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Thu Jul 10, 10:26 pm)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Thu Jul 10, 9:18 pm)
Re: [PATCH] x86_64: fix delayed signals, Roland McGrath, (Thu Jul 10, 9:27 pm)
Re: [PATCH] x86_64: fix delayed signals, Linus Torvalds, (Thu Jul 10, 7:02 pm)