Re: [PATCH 9/12] ipv4: assign PDE->data before gluing PDE into /proc tree

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Stoyan Gaydarov <stoyboyker@...>

Cc: <akpm@...>, <linux-kernel@...>, Alexey Dobriyan <adobriyan@...>, Eric W. Biederman <ebiederm@...>, David S. Miller <davem@...>

Subject: Re: [PATCH 9/12] ipv4: assign PDE->data before gluing PDE into /proc tree

Date: Saturday, July 12, 2008 - 10:55 am

On Fri, 2008-07-11 at 22:12 -0500, Stoyan Gaydarov wrote:
quoted text> First off, sorry to bring such an old email back but I can seem to get
> a bad feeling when looking back over it.
> 
> On Tue, Apr 29, 2008 at 6:13 AM, Denis V. Lunev <den@openvz.org> wrote:
> > The check for PDE->data != NULL becomes useless after the replacement
> > of proc_net_fops_create with proc_create_data.
> >
> > Signed-off-by: Denis V. Lunev <den@openvz.org>
> > Cc: Alexey Dobriyan <adobriyan@openvz.org>
> > Cc: Eric W. Biederman <ebiederm@xmission.com>
> > Cc: David S. Miller <davem@davemloft.net>
> > ---
> >  net/ipv4/tcp_ipv4.c |   10 +++-------
> >  net/ipv4/udp.c      |    7 +++----
> >  2 files changed, 6 insertions(+), 11 deletions(-)
> >
> > diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
> > index 7766151..4d97b28 100644
> > --- a/net/ipv4/tcp_ipv4.c
> > +++ b/net/ipv4/tcp_ipv4.c
> > @@ -2214,9 +2214,6 @@ static int tcp_seq_open(struct inode *inode, struct file *file)
> >        struct tcp_iter_state *s;
> >        int err;
> >
> > -       if (unlikely(afinfo == NULL))
> > -               return -EINVAL;
> I think that this check needs to stay in some form, reason below.
> > -
> >        err = seq_open_net(inode, file, &afinfo->seq_ops,
> >                          sizeof(struct tcp_iter_state));
> >        if (err < 0)
> > @@ -2241,10 +2238,9 @@ int tcp_proc_register(struct net *net, struct tcp_seq_afinfo *afinfo)
> >        afinfo->seq_ops.next            = tcp_seq_next;
> >        afinfo->seq_ops.stop            = tcp_seq_stop;
> >
> > -       p = proc_net_fops_create(net, afinfo->name, S_IRUGO, &afinfo->seq_fops);
> > -       if (p)
> > -               p->data = afinfo;
> > -       else
> > +       p = proc_create_data(afinfo->name, S_IRUGO, net->proc_net,
> 
> When you try to pass in afinfo->name (and also the seq_fops) you are
> assuming that afinfo is not null meaning in the unlikely(as shown
> above) even that it is null you get a very bad null pointer problem.
> If I am just way off do let me know because this just seams to me like
> a bad idea. This is also still present in 2.6.26-rc9.

The reason to remove the check is simple - afinfo comes in the form of
the static pointer during init time. It is impossible to face NULL
pointer the problem in the reality. It can come as the programmer
mistake, but the OOPS will be immediate and straightforward. Namely, the
kernel will not boot/work at all.

Regards,
	Den

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 0/12] Further PDE->data assignments cleanups, Denis V. Lunev, (Tue Apr 29, 7:12 am)

[PATCH 8/12] powerpc: assign PDE->data before gluing PDE ..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

[PATCH 7/12] cciss: assign PDE->data before gluing PDE in..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

RE: [PATCH 7/12] cciss: assign PDE->data before gluing PD..., Miller, Mike (OS Dev), (Tue Apr 29, 11:26 am)

[PATCH 9/12] ipv4: assign PDE->data before gluing PDE int..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

Re: [PATCH 9/12] ipv4: assign PDE->data before gluing PDE..., Stoyan Gaydarov, (Fri Jul 11, 11:12 pm)

Re: [PATCH 9/12] ipv4: assign PDE->data before gluing PDE..., Denis V. Lunev, (Sat Jul 12, 10:55 am)

Re: [PATCH 9/12] ipv4: assign PDE->data before gluing PDE..., Eric W. Biederman, (Fri Jul 11, 11:42 pm)

Re: [PATCH 9/12] ipv4: assign PDE->data before gluing PDE..., David Miller, (Fri May 2, 7:10 am)

[PATCH 3/12] net: assign PDE->data before gluing PDE into..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

Re: [PATCH 3/12] net: assign PDE->data before gluing PDE ..., David Miller, (Fri May 2, 5:46 am)

[PATCH 5/12] atm: assign PDE->data before gluing PDE into..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

Re: [PATCH 5/12] atm: assign PDE->data before gluing PDE ..., David Miller, (Fri May 2, 7:08 am)

[PATCH 4/12] ipv6: assign PDE->data before gluing PDE int..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

Re: [PATCH 4/12] ipv6: assign PDE->data before gluing PDE..., David Miller, (Fri May 2, 5:47 am)

[PATCH 11/12] netfilter: assign PDE->data before gluing P..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

Re: [PATCH 11/12] netfilter: assign PDE->data before glui..., David Miller, (Fri May 2, 7:12 am)

Re: [PATCH 11/12] netfilter: assign PDE->data before glui..., Patrick McHardy, (Tue Apr 29, 8:01 am)

[PATCH 10/12] netfilter: assign PDE->fops before gluing P..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

Re: [PATCH 10/12] netfilter: assign PDE->fops before glui..., David Miller, (Fri May 2, 7:11 am)

[PATCH 6/12] vlan: assign PDE->data before gluing PDE int..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

Re: [PATCH 6/12] vlan: assign PDE->data before gluing PDE..., David Miller, (Fri May 2, 7:09 am)

[PATCH 2/12] netfilter: assign PDE->data before gluing PD..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

Re: [PATCH 2/12] netfilter: assign PDE->data before gluin..., David Miller, (Fri May 2, 5:45 am)

[PATCH 12/12] netns: assign PDE->data before gluing entry..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

Re: [PATCH 12/12] netns: assign PDE->data before gluing e..., David Miller, (Fri May 2, 7:12 am)

[PATCH 1/12] sunrpc: assign PDE->data before gluing PDE i..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

Re: [PATCH 1/12] sunrpc: assign PDE->data before gluing P..., David Miller, (Fri May 2, 5:44 am)


linux-kernel:
Paul Jackson	Re: cpuset-remove-sched-domain-hooks-from-cpusets
James Bottomley	Re: Announce: Linux-next (Or Andrew's dream :-))
David Miller	Slow DOWN, please!!!
Masami Hiramatsu	Re: [RFC PATCH v4] Unified trace buffer
git:

linux-netdev:
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Parag Warudkar	Re: 2.6.29-rc3: tg3 dead after resume

Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
openbsd-misc:

Re: [PATCH 9/12] ipv4: assign PDE->data before gluing PDE into /proc tree

Online users