Re: Multiple MSI, take 3

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <benh@...>
Cc: Suresh Siddha <suresh.b.siddha@...>, Matthew Wilcox <matthew@...>, linux-pci@vger.kernel.org <linux-pci@...>, linux-kernel@vger.kernel.org <linux-kernel@...>, grundler@parisc-linux.org <grundler@...>, mingo@elte.hu <mingo@...>, tglx@linutronix.de <tglx@...>, jgarzik@pobox.com <jgarzik@...>, linux-ide@vger.kernel.org <linux-ide@...>, jbarnes@virtuousgeek.org <jbarnes@...>, rdunlap@xenotime.net <rdunlap@...>, mtk.manpages@gmail.com <mtk.manpages@...>
Date: Saturday, July 12, 2008 - 12:41 am

Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:


It is edge triggered so it won't refire when unmasked (especially if we don't know).
So it is easy to wind up in a state where the device is waiting for the software
and the software is waiting for the device because an irq gets dropped.

There are enough places that have problems that we have a fairly standard work around
to the problem (listed above) by just taking the first irq (after we have disabled the
irq) and setting it pending in software and then actually masking it in hardware.

That works, but it is still isn't quite correct.  Because we can run the
interrupt handler once to often.  For interrupts that are never shared and
always in order with the DMA, generally don't require reading a status
register on the card, and are otherwise highly optimized that might actually
be a problem.

Which is why I said that it doesn't look like even using an iommu can
fix all of the issues with treating msi multi message mode messages
as individual irqs.  We can get very close but not quite there.

Eric
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Multiple MSI, take 3, Matthew Wilcox, (Thu Jul 10, 8:57 pm)
Re: Multiple MSI, take 3, Jike Song, (Fri Sep 26, 1:30 am)
Re: Multiple MSI, take 3, Matthew Wilcox, (Sat Sep 27, 3:04 pm)
Re: Multiple MSI, take 3, Eric W. Biederman, (Fri Jul 11, 6:06 am)
Re: Multiple MSI, take 3, Suresh Siddha, (Fri Jul 11, 5:59 pm)
Re: Multiple MSI, take 3, Eric W. Biederman, (Fri Jul 11, 6:59 pm)
Re: Multiple MSI, take 3, Benjamin Herrenschmidt, (Fri Jul 11, 11:52 pm)
Re: Multiple MSI, take 3, Eric W. Biederman, (Sat Jul 12, 12:41 am)
Re: Multiple MSI, take 3, Benjamin Herrenschmidt, (Sat Jul 12, 3:36 am)
Re: Multiple MSI, take 3, Eric W. Biederman, (Sun Jul 13, 6:30 pm)
Re: Multiple MSI, take 3, Benjamin Herrenschmidt, (Sun Jul 13, 6:44 pm)
Re: Multiple MSI, take 3, Eric W. Biederman, (Sun Jul 13, 7:29 pm)
Re: Multiple MSI, take 3, Benjamin Herrenschmidt, (Sun Jul 13, 8:17 pm)
Re: Multiple MSI, take 3, David Miller, (Sun Jul 13, 8:44 pm)
Re: Multiple MSI, take 3, Eric W. Biederman, (Sun Jul 13, 10:03 pm)
Re: Multiple MSI, take 3, David Miller, (Sun Jul 13, 11:19 pm)
Re: Multiple MSI, take 3, Suresh Siddha, (Fri Jul 11, 7:15 pm)
Re: Multiple MSI, take 3, Eric W. Biederman, (Fri Jul 11, 7:59 pm)
Re: Multiple MSI, take 3, Matthew Wilcox, (Fri Jul 11, 6:23 am)
Re: Multiple MSI, take 3, Eric W. Biederman, (Fri Jul 11, 7:34 am)
Re: Multiple MSI, take 3, Matthew Wilcox, (Fri Jul 11, 8:17 am)
Re: Multiple MSI, take 3, Matthew Wilcox, (Fri Jul 11, 11:10 am)
Re: Multiple MSI, take 3, Eric W. Biederman, (Fri Jul 11, 7:05 am)
Re: Multiple MSI, take 3, David Miller, (Fri Jul 11, 6:32 am)
Re: Multiple MSI, take 3, Matthew Wilcox, (Fri Jul 11, 6:41 am)
[PATCH] Rewrite MSI-HOWTO, Matthew Wilcox, (Thu Jul 10, 9:00 pm)
Re: [PATCH] Rewrite MSI-HOWTO, Grant Grundler, (Fri Sep 26, 2:42 am)
[PATCH] PCI: Add support for multiple MSI, Matthew Wilcox, (Thu Jul 10, 8:59 pm)
Re: [PATCH] PCI: Add support for multiple MSI, Hidetoshi Seto, (Fri Jul 11, 4:28 am)
Re: [PATCH] PCI: Add support for multiple MSI, Benjamin Herrenschmidt, (Fri Jul 11, 11:45 pm)
Re: [PATCH] PCI: Add support for multiple MSI, Matthew Wilcox, (Fri Jul 11, 5:45 am)
[PATCH] AHCI: Request multiple MSIs, Matthew Wilcox, (Thu Jul 10, 9:00 pm)
[PATCH] PCI MSI: Replace 'type' with 'is_msix', Matthew Wilcox, (Thu Jul 10, 8:59 pm)
[PATCH] x86-64: Support for multiple MSIs, Matthew Wilcox, (Thu Jul 10, 9:00 pm)
Re: [PATCH] x86-64: Support for multiple MSIs, Kenji Kaneshige, (Fri Jul 11, 12:50 am)
Re: [PATCH] x86-64: Support for multiple MSIs, Matthew Wilcox, (Fri Jul 11, 4:50 am)
Re: [PATCH] x86-64: Support for multiple MSIs, Kenji Kaneshige, (Sun Jul 13, 9:08 pm)