Re: [PATCH 9/12] ipv4: assign PDE->data before gluing PDE into /proc tree

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Stoyan Gaydarov
Date: Friday, July 11, 2008 - 8:12 pm

First off, sorry to bring such an old email back but I can seem to get
a bad feeling when looking back over it.

On Tue, Apr 29, 2008 at 6:13 AM, Denis V. Lunev <den@openvz.org> wrote:
I think that this check needs to stay in some form, reason below.

When you try to pass in afinfo->name (and also the seq_fops) you are
assuming that afinfo is not null meaning in the unlikely(as shown
above) even that it is null you get a very bad null pointer problem.
If I am just way off do let me know because this just seams to me like
a bad idea. This is also still present in 2.6.26-rc9.

-Stoyan G

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/12] Further PDE-&gt;data assignments cleanups, Denis V. Lunev, (Tue Apr 29, 4:12 am)
RE: [PATCH 7/12] cciss: assign PDE-&gt;data before gluing PDE ..., Miller, Mike (OS Dev), (Tue Apr 29, 8:26 am)
Re: [PATCH 9/12] ipv4: assign PDE->data before gluing PDE ..., Stoyan Gaydarov, (Fri Jul 11, 8:12 pm)