Home » Mailing list archives » linux-kernel » 2008 » June » 9

Re: [PATCH 11/15] x86: move enabling of io_apic to prepare_cpus

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Maciej W. Rozycki
Subject: Re: [PATCH 11/15] x86: move enabling of io_apic to prepare_cpus
Date: Monday, June 9, 2008 - 1:12 pm

On Mon, 9 Jun 2008, Glauber Costa wrote:


 Hmm, it looks a little bit better, but why do you want to call
enable_IO_APIC() separately in the first place?  There is a comment
stating: "Enable IO APIC before setting up error vector," but why is it
needed on 64-bit systems?  Especially as the very same system may run a
32-bit kernel and then it suddenly would not have to do this anymore?  
Strange...

 Also since you are cleaning up this code -- why don't you actually take
the opportunity and get rid of the horrible #ifdefs interspersed
throughout?

  Maciej
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 11/15] x86: move enabling of io_apic to prepare_cpus, Glauber Costa, (Mon Jun 9, 7:16 am)
[PATCH 12/15] x86: change naming to match x86_64, Glauber Costa, (Mon Jun 9, 7:16 am)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare ..., Maciej W. Rozycki, (Mon Jun 9, 8:23 am)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare ..., Glauber Costa, (Mon Jun 9, 8:52 am)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare ..., Glauber Costa, (Mon Jun 9, 12:44 pm)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare ..., Maciej W. Rozycki, (Mon Jun 9, 1:12 pm)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare ..., Yinghai Lu, (Mon Jun 9, 1:53 pm)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare ..., Maciej W. Rozycki, (Mon Jun 9, 2:00 pm)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare ..., Glauber Costa, (Mon Jun 9, 2:02 pm)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare ..., Maciej W. Rozycki, (Mon Jun 9, 7:46 pm)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare ..., Yinghai Lu, (Mon Jun 9, 10:08 pm)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare ..., Glauber Costa, (Tue Jun 10, 6:00 am)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare ..., Maciej W. Rozycki, (Tue Jun 10, 6:30 am)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare ..., Yinghai Lu, (Tue Jun 10, 12:09 pm)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare ..., Maciej W. Rozycki, (Tue Jun 10, 12:36 pm)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare ..., Yinghai Lu, (Tue Jun 10, 12:49 pm)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare ..., Maciej W. Rozycki, (Tue Jun 10, 5:29 pm)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare ..., Yinghai Lu, (Tue Jun 10, 7:32 pm)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare ..., Maciej W. Rozycki, (Wed Jun 11, 5:57 am)