Re: [Cbe-oss-dev] [regression/bisected] corrupt CD data after media change and delay

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Geert Uytterhoeven <Geert.Uytterhoeven@...>
Cc: David Martin <tasio@...>, <linux-scsi@...>, Linux Kernel Development <linux-kernel@...>, Maarten Bressers <mbres@...>, Daniel Drake <dsd@...>, Cell Broadband Engine OSS Development <cbe-oss-dev@...>
Date: Monday, June 9, 2008 - 11:05 am

On Mon, 2008-06-09 at 15:54 +0200, Geert Uytterhoeven wrote:

Well, we have the taxonomy.  It's something to do with the media change
trigger.  Could you try getting the output of this patch and correlate
the prints with your success and failure cases?

Thanks,

James

---

diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
index 7ee86d4..2b58772 100644
--- a/drivers/scsi/sr.c
+++ b/drivers/scsi/sr.c
@@ -212,6 +212,8 @@ static int sr_media_change(struct cdrom_device_info *cdi, int slot)
 	if (retval || (scsi_sense_valid(sshdr) &&
 		       /* 0x3a is medium not present */
 		       sshdr->asc == 0x3a)) {
+		printk("+10+ the result = 0x%x, skip size update ", retval);
+		scsi_show_sense_hdr(&sshdr);
 		/* Media not present or unable to test, unit probably not
 		 * ready. This usually means there is no disc in the drive.
 		 * Mark as changed, and we will figure it out later once
@@ -232,7 +234,7 @@ static int sr_media_change(struct cdrom_device_info *cdi, int slot)
 		sr_cd_check(cdi);
 		get_sectorsize(cd);
 	}
-
+	printk("+11+ Return forcing update is %d\n", retval);
 out:
 	/* Notify userspace, that media has changed. */
 	if (retval != cd->previous_state)


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[regression/bisected] corrupt CD data after media change and..., Geert Uytterhoeven, (Fri Jun 6, 10:06 am)
Re: [Cbe-oss-dev] [regression/bisected] corrupt CD data afte..., Geert Uytterhoeven, (Fri Jun 13, 1:33 pm)
Re: [Cbe-oss-dev] [regression/bisected] corrupt CD data afte..., Alessandro Suardi, (Wed Jun 18, 4:47 am)
Re: [Cbe-oss-dev] [regression/bisected] corrupt CD data afte..., Geert Uytterhoeven, (Wed Jun 18, 7:13 am)
Re: [Cbe-oss-dev] [regression/bisected] corrupt CD data afte..., Alessandro Suardi, (Wed Jun 18, 8:15 am)
Re: [Cbe-oss-dev] [regression/bisected] corrupt CD data afte..., Alessandro Suardi, (Sat Jun 21, 10:18 am)
Re: [Cbe-oss-dev] [regression/bisected] corrupt CD data afte..., Geert Uytterhoeven, (Sun Jun 22, 4:18 am)
Re: [Cbe-oss-dev] [regression/bisected] corrupt CD data afte..., Alessandro Suardi, (Sun Jun 22, 9:14 am)
Re: [Cbe-oss-dev] [regression/bisected] corrupt CD data afte..., Alessandro Suardi, (Fri Jul 11, 5:25 pm)
Re: [Cbe-oss-dev] [regression/bisected] corrupt CD data afte..., Alessandro Suardi, (Sat Jul 12, 8:08 am)
Re: [Cbe-oss-dev] [regression/bisected] corrupt CD data afte..., Alessandro Suardi, (Wed Jul 23, 4:25 pm)
Re: [regression/bisected] corrupt CD data after media change..., Geert Uytterhoeven, (Mon Jun 9, 8:54 am)
Re: [Cbe-oss-dev] [regression/bisected] corrupt CD data afte..., Geert Uytterhoeven, (Mon Jun 9, 9:54 am)
Re: [Cbe-oss-dev] [regression/bisected] corrupt CD data afte..., James Bottomley, (Mon Jun 9, 11:05 am)
Re: [Cbe-oss-dev] [regression/bisected] corrupt CD data afte..., Geert Uytterhoeven, (Mon Jun 9, 11:27 am)
Re: [regression/bisected] corrupt CD data after media change..., Geert Uytterhoeven, (Fri Jun 6, 1:27 pm)