[PATCH 12/15] x86: change naming to match x86_64

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-kernel@...>
Cc: <akpm@...>, <tglx@...>, <mingo@...>, <hugh@...>, Glauber de Oliveira Costa <gcosta@...>
Date: Monday, June 9, 2008 - 10:16 am

Change unmap_cpu_to_logical_apicid to numa_remove_cpu.
Besides being shorter, it is the same name x86_64 uses. We
can save an ifdef in the code this way.

Signed-off-by: Glauber de Oliveira Costa <gcosta@redhat.com>
---
 arch/x86/kernel/smpboot.c |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 49d2900..6316d30 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -181,13 +181,12 @@ static void map_cpu_to_logical_apicid(void)
 	map_cpu_to_node(cpu, node);
 }
 
-static void unmap_cpu_to_logical_apicid(int cpu)
+static void numa_remove_cpu(int cpu)
 {
 	cpu_2_logical_apicid[cpu] = BAD_APICID;
 	unmap_cpu_to_node(cpu);
 }
 #else
-#define unmap_cpu_to_logical_apicid(cpu) do {} while (0)
 #define map_cpu_to_logical_apicid()  do {} while (0)
 #endif
 
@@ -945,10 +944,7 @@ restore_state:
 
 	if (boot_error) {
 		/* Try to put things back the way they were before ... */
-		unmap_cpu_to_logical_apicid(cpu);
-#ifdef CONFIG_X86_64
 		numa_remove_cpu(cpu); /* was set by numa_add_cpu */
-#endif
 		cpu_clear(cpu, cpu_callout_map); /* was set by do_boot_cpu() */
 		cpu_clear(cpu, cpu_initialized); /* was set by cpu_init() */
 		cpu_clear(cpu, cpu_possible_map);
@@ -1246,7 +1242,7 @@ void cpu_exit_clear(void)
 	cpu_clear(cpu, cpu_callout_map);
 	cpu_clear(cpu, cpu_callin_map);
 
-	unmap_cpu_to_logical_apicid(cpu);
+	numa_remove_cpu(cpu);
 }
 #  endif /* CONFIG_X86_32 */
 
-- 
1.5.4.5

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare_c..., Maciej W. Rozycki, (Mon Jun 9, 11:23 am)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare_c..., Maciej W. Rozycki, (Mon Jun 9, 10:46 pm)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare_c..., Maciej W. Rozycki, (Tue Jun 10, 9:30 am)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare_c..., Maciej W. Rozycki, (Tue Jun 10, 3:36 pm)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare_c..., Maciej W. Rozycki, (Tue Jun 10, 8:29 pm)
Re: [PATCH 11/15] x86: move enabling of io_apic to prepare_c..., Maciej W. Rozycki, (Wed Jun 11, 8:57 am)
[PATCH 12/15] x86: change naming to match x86_64, Glauber Costa, (Mon Jun 9, 10:16 am)