On 159, 06 07, 2008 at 03:54:36 +0100, Matthew Garrett wrote:
quoted text
> Nvidia-based Apple Macbook Pros don't appear to handle backlight control=
=20
quoted text
> through the graphics card registers or ACPI, but instead trigger changes=
=20
quoted text
> via SMI calls. This driver registers a generic backlight device that=20
> lets existing userspace deal with it. Code derived from Julien Blache's=
=20
quoted text
> Pommed application.
>=20
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
>=20
> ---
>=20
> Lennart - as far as I could tell from your description, the DMI=20
> autoloading code for this should be correct. However, it's not working=20
> for me on F9. Have I missed something, or does it just not work there?

BTW do we have any documentation to help ordinary human understand and gene=
rate
these aliases ?

quoted text
> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kc=
onfig
quoted text
> index dcd8073..56f4572 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -112,3 +112,11 @@ config BACKLIGHT_CARILLO_RANCH
>  	help
>  	  If you have a Intel LE80578 (Carillo Ranch) say Y to enable the
>  	  backlight driver.
> +
> +config BACKLIGHT_MBP_NVIDIA
> +       tristate "Macbook Pro Nvidia Backlight Driver"
> +       depends on BACKLIGHT_CLASS_DEVICE && X86
> +       default n
> +       help
> +         If you have an Apple Macbook Pro with Nvidia graphics hardware =
say Y
quoted text
> +	 to enable a driver for its backlight
> diff --git a/drivers/video/backlight/Makefile b/drivers/video/backlight/M=
akefile
quoted text
> index 33f6c7c..5b91515 100644
> --- a/drivers/video/backlight/Makefile
> +++ b/drivers/video/backlight/Makefile
> @@ -10,3 +10,4 @@ obj-$(CONFIG_BACKLIGHT_LOCOMO)	+=3D locomolcd.o
>  obj-$(CONFIG_BACKLIGHT_OMAP1)	+=3D omap1_bl.o
>  obj-$(CONFIG_BACKLIGHT_PROGEAR) +=3D progear_bl.o
>  obj-$(CONFIG_BACKLIGHT_CARILLO_RANCH) +=3D cr_bllcd.o
> +obj-$(CONFIG_BACKLIGHT_MBP_NVIDIA) +=3D mbp_nvidia_bl.o
> diff --git a/drivers/video/backlight/mbp_nvidia_bl.c b/drivers/video/back=
light/mbp_nvidia_bl.c
quoted text
> new file mode 100644
> index 0000000..c622d22
> --- /dev/null
> +++ b/drivers/video/backlight/mbp_nvidia_bl.c
> @@ -0,0 +1,114 @@
> +/*
> + *  Backlight Driver for Nvidia 8600 in Macbook Pro
> + *
> + *  Copyright (c) Red Hat <mjg@redhat.com>
> + *  Based on code from Pommed:
> + *  Copyright (C) 2006 Nicolas Boichat <nicolas @boichat.ch>
> + *  Copyright (C) 2006 Felipe Alfaro Solana <felipe_alfaro @linuxmail.or=
g>
quoted text
> + *  Copyright (C) 2007 Julien BLACHE <jb@jblache.org>
> + *
> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License version 2 as
> + *  published by the Free Software Foundation.
> + *
> + *  This driver triggers SMIs which cause the firmware to change the
> + *  backlight brightness. This is icky in many ways, but it's impractica=
l to
quoted text
> + *  get at the firmware code in order to figure out what it's actually d=
oing.
quoted text
> + */
> +
> +#include <linux/module.h>
> +#include <linux/kernel.h>
> +#include <linux/init.h>
> +#include <linux/platform_device.h>
> +#include <linux/backlight.h>
> +#include <linux/err.h>
> +#include <linux/dmi.h>
> +#include <linux/io.h>
> +
> +struct backlight_device *mbp_backlight_device;

Missing static ?

quoted text
> +
> +static struct dmi_system_id __initdata mbp_device_table[] =3D {
> +	{
> +		.ident =3D "3,1",
> +		.matches =3D {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro3,1"),
> +		},
> +	},
> +	{
> +		.ident =3D "3,2",
> +		.matches =3D {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro3,2"),
> +		},
> +	},
> +	{
> +		.ident =3D "4,1",
> +		.matches =3D {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro4,1"),
> +		},
> +	},
> +	{ }
> +};
> +
> +static int mbp_send_intensity(struct backlight_device *bd)
> +{
> +	int intensity =3D bd->props.brightness;
> +
> +	outb(0x04 | (intensity << 4), 0xb3);
> +	outb(0xbf, 0xb2);
> +
> +	return 0;
> +}
> +
> +static int mbp_get_intensity(struct backlight_device *bd)
> +{
> +	outb(0x03, 0xb3);
> +	outb(0xbf, 0xb2);
> +	return inb(0xb3) >> 4;
> +}
> +
> +static struct backlight_ops mbp_ops =3D {
> +	.get_brightness =3D mbp_get_intensity,
> +	.update_status  =3D mbp_send_intensity,
> +};
> +
> +static int __init mbp_init(void)
> +{
> +	if (!dmi_check_system(mbp_device_table))
> +		return -ENODEV;
> +
> +	if (!request_region(0xb2, 2, "Macbook Pro backlight"))
> +		return -ENXIO;
> +
> +	mbp_backlight_device =3D backlight_device_register("mbp_backlight",
> +							 NULL, NULL,
> +							 &mbp_ops);
> +	if (IS_ERR(mbp_backlight_device))
> +		return PTR_ERR(mbp_backlight_device);

You leak ioport region here.

quoted text
> +
> +	mbp_backlight_device->props.max_brightness =3D 15;
> +	mbp_backlight_device->props.brightness =3D
> +		mbp_get_intensity(mbp_backlight_device);
> +	backlight_update_status(mbp_backlight_device);
> +
> +	return 0;
> +}
> +
> +static void __exit mbp_exit(void)
> +{
> +	backlight_device_unregister(mbp_backlight_device);
> +
> +	release_region(0xb2, 2);
> +}
> +
> +module_init(mbp_init);
> +module_exit(mbp_exit);
> +
> +MODULE_AUTHOR("Matthew Garrett <mjg@redhat.com>");
> +MODULE_DESCRIPTION("Nvidia-based Macbook Pro Backlight Driver");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("dmi:*:svnApple Inc.:pnMacBookPro3,1:*");
> +MODULE_ALIAS("dmi:*:svnApple Inc.:pnMacBookPro3,2:*");
> +MODULE_ALIAS("dmi:*:svnApple Inc.:pnMacBookPro4,1:*");

--=20
Andrey Panin		| Linux and UNIX system administrator
pazke@donpac.ru		| PGP key: wwwkeys.pgp.net