login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
June
»
6
Re: [PATCH] isdn divas: fix proc creation
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Alexey Dobriyan <adobriyan@...>
To: Armin Schindler <armin@...>
Cc: <akpm@...>, <linux-kernel@...>
Subject:
Re: [PATCH] isdn divas: fix proc creation
Date: Friday, June 6, 2008 - 2:17 am
On Thu, Jun 05, 2008 at 12:25:06PM +0200, Armin Schindler wrote:
quoted text
> On Sat, 31 May 2008, Alexey Dobriyan wrote: >> 1. creating proc entry and not saving pointer to PDE and checking it >> is not going to work. > > I don't know where you found this. I have look even in older versions, but > the pointer divas_proc_entry is set by proc_create(). The patch to > divasproc.c is wrong, it exists from the beginning of the driver. > (2.6.25.4 doesn't contain the bug you describe).
Check mainline kernel, namely, 2.6.26-rc5.
quoted text
>> --- a/drivers/isdn/hardware/eicon/divasproc.c >> +++ b/drivers/isdn/hardware/eicon/divasproc.c >> @@ -125,8 +125,8 @@ static const struct file_operations divas_fops = { >> >> int create_divas_proc(void) >> { >> - proc_create(divas_proc_name, S_IFREG | S_IRUGO, proc_net_eicon, >> - &divas_fops); >> + divas_proc_entry = proc_create(divas_proc_name, S_IFREG | S_IRUGO, >> + proc_net_eicon, &divas_fops); >> if (!divas_proc_entry) >> return (0);
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] isdn divas: fix proc creation
, Alexey Dobriyan
, (Fri May 30, 7:34 pm)
Re: [PATCH] isdn divas: fix proc creation
, Armin Schindler
, (Thu Jun 5, 6:25 am)
Re: [PATCH] isdn divas: fix proc creation
, Alexey Dobriyan
, (Fri Jun 6, 2:17 am)
Re: [PATCH] isdn divas: fix proc creation
, Armin Schindler
, (Fri Jun 6, 2:44 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg KH
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman
[PATCH 005/196] Chinese: add translation of SubmittingDrivers
Adrian Bunk
[1/6] 2.6.21-rc2: known regressions
Paul Jackson
Re: cpuset-remove-sched-domain-hooks-from-cpusets
git
:
linux-netdev
:
Linus Torvalds
Re: [GIT]: Networking
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Andrew Morton
Re: [BUG] New Kernel Bugs
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
3 users
and
669 guests
online.
Online users
primalforce
Nelson
shirleybarry82
Syndicate