| From | Subject | Date |
|---|---|---|
| Kevin Winchester | Re: [X86][BISECTED] WARNING: at kernel/lockdep.c:2680
I didn't manage to get through a bisection run for the warning - thanks
to Sitsofe for doing it. The patch does eliminate the warning for me.
Thanks,
--
Kevin Winchester
--
| Jun 5, 4:53 pm 2008 |
| OGAWA Hirofumi | [PATCH] fat: Relax the permission check of fat_setattr()
New chmod() allows only acceptable permission, and if not acceptable,
it returns -EPERM. Old one allows even if it can't store permission to
on disk inode. But it seems too strict for users.
E.g. https://bugzilla.redhat.com/show_bug.cgi?id=449080: With new one,
rsync couldn't create the temporary file.
So, this patch allows like old one, but now it doesn't change the
permission if it can't store, and it returns 0.
Also, this patch fixes missing check.
Signed-off-by: OGAWA Hirofumi ...
| Jun 5, 4:32 pm 2008 |
| Keika Kobayashi | [PATCH 2/3 v2] per-task-delay-accounting: update tasksta ...
Add members for memory reclaim delay to taskstats,
and accumulate them in __delayacct_add_tsk() .
Signed-off-by: Keika Kobayashi <kobayashi.kk@ncos.nec.co.jp>
---
include/linux/taskstats.h | 4 ++++
kernel/delayacct.c | 3 +++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/include/linux/taskstats.h b/include/linux/taskstats.h
index 5d69c07..87aae21 100644
--- a/include/linux/taskstats.h
+++ b/include/linux/taskstats.h
@@ -81,6 +81,10 @@ struct taskstats {
...
| Jun 5, 4:32 pm 2008 |
| Keika Kobayashi | [PATCH 3/3 v2] per-task-delay-accounting: update documen ...
Update document and make getdelays.c show delay accounting for memory reclaim.
For making a distinction between "swapping in pages" and "memory reclaim"
in getdelays.c, MEM is changed to SWAP.
Signed-off-by: Keika Kobayashi <kobayashi.kk@ncos.nec.co.jp>
---
Documentation/accounting/delay-accounting.txt | 11 ++++++++---
Documentation/accounting/getdelays.c | 8 ++++++--
2 files changed, 14 insertions(+), 5 deletions(-)
diff --git ...
| Jun 5, 4:33 pm 2008 |
| Keika Kobayashi | [PATCH 0/3 v2] per-task-delay-accounting: add memory rec ...
Hi.
This is v2 of accounting memory reclaim patch series.
Thanks to Kosaki-san, Kamezawa-san, Andrew for comments and advice!
These patches were fixed about the following.
Against: next-20080605
1) Change Log
o Add accounting memory reclaim delay from memcgroup.
For accounting both global and cgroup memory reclaim,
accounting point was moved from try_to_free_pages() to do_try_to_free_pages.
o Drop the patch regarding /proc export for memory reclaim delay.
Because it seems ...
| Jun 5, 4:27 pm 2008 |
| Keika Kobayashi | [PATCH 1/3 v2] per-task-delay-accounting: add memory rec ...
Sometimes, application responses become bad under heavy memory load.
Applications take a bit time to reclaim memory.
The statistics, how long memory reclaim takes, will be useful to
measure memory usage.
This patch adds accounting memory reclaim to per-task-delay-accounting
for accounting the time of do_try_to_free_pages().
<i.e>
- When System is under low memory load,
memory reclaim may not occur.
$ free
total used free shared buffers cached
Mem: ...
| Jun 5, 4:31 pm 2008 |
| Johannes Weiner | [PATCH -mm 14/14] bootmem: replace node_boot_start in st ...
Almost all users of this field need a PFN instead of a physical
address, so replace node_boot_start with node_min_pfn.
Signed-off-by: Johannes Weiner <hannes@saeureba.de>
CC: linux-arch@vger.kernel.org
---
arch/alpha/mm/numa.c | 2 +-
arch/arm/plat-omap/fb.c | 4 +---
arch/avr32/mm/init.c | 3 +--
arch/ia64/mm/discontig.c | 19 ++++++++++---------
arch/m32r/mm/discontig.c | 3 +--
arch/m32r/mm/init.c | 4 +---
arch/mn10300/mm/init.c | 6 +++---
...
| Jun 5, 3:49 pm 2008 |
| Johannes Weiner | [PATCH -mm 13/14] bootmem: revisit alloc_bootmem_section
Since alloc_bootmem_core does no goal-fallback anymore and just
returns NULL if the allocation fails, we might now use it in
alloc_bootmem_section without all the fixup code for a misplaced
allocation.
Also, the limit can be the first PFN of the next section as the
semantics is that the limit is _above_ the allocated region, not
within.
Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
CC: Yasunori Goto <y-goto@jp.fujitsu.com>
---
mm/bootmem.c | 27 ++++++---------------------
1 ...
| Jun 5, 3:49 pm 2008 |
| Johannes Weiner | [PATCH -mm 12/14] bootmem: Make __alloc_bootmem_low_node ...
__alloc_bootmem_node already does this, make the interface consistent.
Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
CC: Ingo Molnar <mingo@elte.hu>
CC: Yinghai Lu <yhlu.kernel@gmail.com>
CC: Andi Kleen <andi@firstfloor.org>
---
mm/bootmem.c | 25 ++++++++++++++++---------
1 file changed, 16 insertions(+), 9 deletions(-)
--- a/mm/bootmem.c
+++ b/mm/bootmem.c
@@ -610,6 +610,19 @@ void * __init __alloc_bootmem_low(unsign
return ___alloc_bootmem(size, align, goal, ...
| Jun 5, 3:49 pm 2008 |
| Johannes Weiner | [PATCH -mm 11/14] bootmem: respect goal more likely
The old node-agnostic code tried allocating on all nodes starting from
the one with the lowest range. alloc_bootmem_core retried without the
goal if it could not satisfy it and so the goal was only respected at
all when it happened to be on the first (lowest page numbers) node (or
theoretically if allocations failed on all nodes before to the one
holding the goal).
Introduce a non-panicking helper that starts allocating from the node
holding the goal and falls back only after all thes tries ...
| Jun 5, 3:49 pm 2008 |
| Johannes Weiner | [PATCH -mm 10/14] bootmem: factor out the marking of a P ...
Introduce new helpers that mark a range that resides completely on a
node or node-agnostic ranges that might also span node boundaries.
The free/reserve API functions will then directly use these helpers.
Note that the free/reserve semantics become more strict: while the
prior code took basically arbitrary range arguments and marked the
PFNs that happen to fall into that range, the new code requires
node-specific ranges to be completely on the node. The node-agnostic
requests might span node ...
| Jun 5, 3:49 pm 2008 |
| Johannes Weiner | [PATCH -mm 09/14] bootmem: free/reserve helpers
Factor out the common operation of marking a range on the bitmap.
Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
CC: Ingo Molnar <mingo@elte.hu>
CC: Yinghai Lu <yhlu.kernel@gmail.com>
CC: Andi Kleen <andi@firstfloor.org>
---
mm/bootmem.c | 65 +++++++++++++++++++++++++++++++++++++++--------------------
1 file changed, 43 insertions(+), 22 deletions(-)
--- a/mm/bootmem.c
+++ b/mm/bootmem.c
@@ -225,6 +225,44 @@ unsigned long __init free_all_bootmem(vo
return ...
| Jun 5, 3:49 pm 2008 |
| Johannes Weiner | [PATCH -mm 08/14] bootmem: clean up alloc_bootmem_core
alloc_bootmem_core has become quite nasty to read over time. This is
a clean rewrite that keeps the semantics.
bdata->last_pos has been dropped.
bdata->last_success has been renamed to hint_idx and it is now an
index relative to the node's range. Since further block searching
might start at this index, it is now set to the end of a succeeded
allocation rather than its beginning.
bdata->last_offset has been renamed to last_end_off to be more clear
that it represents the ending address of ...
| Jun 5, 3:49 pm 2008 |
| Johannes Weiner | [PATCH -mm 07/14] bootmem: clean up free_all_bootmem_core
Rewrite the code in a more concise way using less variables.
Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
CC: Ingo Molnar <mingo@elte.hu>
CC: Yinghai Lu <yhlu.kernel@gmail.com>
CC: Andi Kleen <andi@firstfloor.org>
---
mm/bootmem.c | 83 +++++++++++++++++++++++++++--------------------------------
1 file changed, 38 insertions(+), 45 deletions(-)
--- a/mm/bootmem.c
+++ b/mm/bootmem.c
@@ -144,66 +144,59 @@ unsigned long __init init_bootmem(unsign
static unsigned long __init ...
| Jun 5, 3:49 pm 2008 |
| Johannes Weiner | [PATCH -mm 06/14] bootmem: revisit bootmem descriptor li ...
link_bootmem handles an insertion of a new descriptor into the sorted
list in more or less three explicit branches; empty list, insert in
between and append. These cases can be expressed implicite.
Also mark the sorted list as initdata as it can be thrown away after
boot as well.
Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
---
mm/bootmem.c | 23 ++++++++++-------------
1 file changed, 10 insertions(+), 13 deletions(-)
--- a/mm/bootmem.c
+++ b/mm/bootmem.c
@@ -23,7 +23,6 ...
| Jun 5, 3:49 pm 2008 |
| Johannes Weiner | [PATCH -mm 05/14] bootmem: revisit bitmap size calculations
Reincarnate get_mapsize as bootmap_bytes and implement
bootmem_bootmap_pages on top of it.
Adjust users of these helpers and make free_all_bootmem_core use
bootmem_bootmap_pages instead of open-coding it.
Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
---
mm/bootmem.c | 27 +++++++++------------------
1 file changed, 9 insertions(+), 18 deletions(-)
--- a/mm/bootmem.c
+++ b/mm/bootmem.c
@@ -50,17 +50,11 @@ early_param("bootmem_debug", bootmem_deb
__FUNCTION__, ## ...
| Jun 5, 3:49 pm 2008 |
| Johannes Weiner | [PATCH -mm 04/14] bootmem: add debugging framework
Introduce the bootmem_debug kernel parameter that enables very verbose
diagnostics regarding all range operations of bootmem as well as the
initialization and release of nodes.
Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
---
mm/bootmem.c | 51 ++++++++++++++++++++++++++++++++++++++++++++-------
1 file changed, 44 insertions(+), 7 deletions(-)
--- a/mm/bootmem.c
+++ b/mm/bootmem.c
@@ -34,6 +34,22 @@ unsigned long saved_max_pfn;
bootmem_data_t ...
| Jun 5, 3:49 pm 2008 |
| Johannes Weiner | [PATCH -mm 03/14] bootmem: add documentation to API functions
Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
---
mm/bootmem.c | 150 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 149 insertions(+), 1 deletion(-)
--- a/mm/bootmem.c
+++ b/mm/bootmem.c
@@ -47,7 +47,10 @@ static unsigned long __init get_mapsize(
return ALIGN(mapsize, sizeof(long));
}
-/* return the number of _pages_ that will be allocated for the boot bitmap */
+/**
+ * bootmem_bootmap_pages - calculate bitmap size in pages
+ * @pages: number ...
| Jun 5, 3:49 pm 2008 |
| Johannes Weiner | [PATCH -mm 02/14] bootmem: clean up bootmem.c file header
Change the description, move a misplaced comment about the allocator
itself and add me to the list of copyright holders.
Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
CC: Ingo Molnar <mingo@elte.hu>
---
mm/bootmem.c | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
--- a/mm/bootmem.c
+++ b/mm/bootmem.c
@@ -1,12 +1,12 @@
/*
- * linux/mm/bootmem.c
+ * bootmem - A boot-time physical memory allocator and configurator
*
* Copyright (C) 1999 Ingo ...
| Jun 5, 3:49 pm 2008 |
| Johannes Weiner | [PATCH -mm 01/14] bootmem: reorder code to match new boo ...
This only reorders functions so that further patches will be easier to
read. No code changed.
Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
---
include/linux/bootmem.h | 79 ++++-----
mm/bootmem.c | 413 +++++++++++++++++++++++-------------------------
2 files changed, 246 insertions(+), 246 deletions(-)
--- a/mm/bootmem.c
+++ b/mm/bootmem.c
@@ -38,6 +38,19 @@ unsigned long saved_max_pfn;
bootmem_data_t bootmem_node_data[MAX_NUMNODES] __initdata;
+/*
+ * ...
| Jun 5, 3:49 pm 2008 |
| Johannes Weiner | [PATCH -mm 00/14] bootmem rewrite v4
Hi,
This is a complete overhaul of the bootmem allocator while preserving
most of its original functionality.
free_bootmem and reserve_bootmem become a bit stricter than they are
right now, callsites have to make sure that the PFN range is
contiguous but it might go across node boundaries.
alloc_bootmem satisfying the allocation goal is more likely as the
routines will try to allocate on the node holding the goal first
before falling back as opposed to the original behaviour ...
| Jun 5, 3:49 pm 2008 |
| Michał Kudła | [2.6.26-rc5] iwlwifi 4965 not working - last on 2.6.23
Hello,
according to http://www.kernel.org/pub/linux/docs/lkml/reporting-bugs.html
[1.] One line summary of the problem:
[2.6.26-rc5] iwlwifi 4965 not working - last on 2.6.23
[2.] Full description of the problem/report:
linux: gentoo
kernel vanilla-sources-2-6-26-rc5
laptop: Asus S96S
WiFi: intel 4695
WiFi not working.
In the same config, but with gentoo-sources-2.6.23 WiFi working well.
dmesg - 2.6.23
iwl4965: Intel(R) Wireless WiFi Link 4965AGN driver for Linux, 1.2.25ds
iwl4965: ...
| Jun 5, 3:39 pm 2008 |
| Kok, Auke | bug? acpi p-state + ondemand keeps dropping max freq
I've consistently experienced the following bizarre problem since 2.6.20, all the
way up to 2.6.25.3 (regressed yesterday and each of these kernels exposes this
behaviour):
/sys/devices/system/cpu/cpu0/cpufreq # grep . *
affected_cpus:0
cpuinfo_cur_freq:800000
cpuinfo_max_freq:1866000
cpuinfo_min_freq:800000
scaling_available_frequencies:1866000 1600000 1333000 1066000 800000
scaling_available_governors:ondemand ...
| Jun 5, 3:30 pm 2008 |
| Randy Dunlap | x86_64 boot hang when CONFIG_NUMA=n
On 2.6.26-rc[2345], I am seeing a hang during boot with CONFIG_NUMA=n, but changing
to CONFIG_NUMA=y allows successful boot.
This is on a 4-way AMD64 (HP) server with 8 GB RAM.
Using initcall_debug, the last output on a hang is from arch/x86/pci/k8-bus_64.c:
calling early_fill_mp_bus_info+0x0/0x7b2
node 0 link 1: io port [1000, 3fff]
node 1 link 2: io port [4000, ffff]
TOM: 0000000080000000 aka 2048M
node 0 link 1: mmio [e8000000, fddfffff]
node 1 link 2: mmio [fde00000, fdffffff]
node ...
| Jun 5, 2:50 pm 2008 |
| Mauro Carvalho Chehab | [GIT PATCHES for 2.6.26] V4L/DVB fixes
Hi Linus,
This is another series of fixes for V4L/DVB. This series is a little bigger,
since I got some days in vacation, and, after that, it took me some time to
process tons of emails and merge requests.
Please pull from:
ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git master
For several fixes (most are trivial ones):
- Fix compat32 for ivtv and cx18;
- several fixes on the newer cx18 and au0828 drivers;
- several Kbuild fixes;
- fix several ...
| Jun 5, 2:14 pm 2008 |
| Justin Mattock | GPE storm detected, disabling EC GPE
FWIW I noticed a post where the person had changed 5 to 20, and it
seemed to work for them;
So with that in mind I decide to give that a go, here is the location:
drivers/acpi/ec.c
@@ -527,47 +488,51 @@ static u32 acpi_ec_gpe_handler(void *data)
{
acpi_status status = AE_OK;
struct acpi_ec *ec = data;
u8 state = acpi_ec_read_status(ec);
pr_debug(PREFIX "~~~> interrupt\n");
atomic_inc(&ec->irq_count);
- if (atomic_read(&ec->irq_count) > 5) {
+ ...
| Jun 5, 2:01 pm 2008 |
| Steven Rostedt | [PATCH] ftrace: disable function tracing bringing up new CPU
Peter Zijlstra found that taking down and bringing up a new CPU caused
ftrace to crash the kernel. This was due to some arch calls that were
being traced by the function tracer before the smp_processor_id was set
up. Since the function tracer uses smp_processor_id it caused a triple
fault.
Instead of adding notrace all over the architecture code to prevent
this problem, it is easier to simply disable the function tracer
when bringing up a new CPU.
Signed-off-by: Steven Rostedt ...
| Jun 5, 1:54 pm 2008 |
| Steven Rostedt | [PATCH -v2] ftrace: disable function tracing bringing up ...
[
I noticed that I left a "unsigned long flags" in the version I sent out.
That was due to my first faulty implementation that used a spin lock.
Please use this patch instead. The only difference between this patch
and the one I sent out is that I removed the unused flags variables
from ftrace_enable() and ftrace_disable().
]
Peter Zijlstra found that taking down and bringing up a new CPU caused
ftrace to crash the kernel. This was due to some arch calls that were
being traced by ...
| Jun 5, 4:19 pm 2008 |
| Marcin Obara | [PATCH] tpm:increase size of internal TPM response buffers
This patch increases size of driver internal response buffers.
Some TPM responses defined in TCG TPM Specification Version 1.2 Revision 103
have increased size and do not fit previously defined buffers.
Some TPM responses do not have fixed size, so bigger response buffers
have to be allocated. 200B buffers should be enough.
Signed-off-by: Marcin Obara <marcin_obara@users.sourceforge.net>
--- linux/drivers/char/tpm/tpm.c 2008-06-05 22:12:47.000000000 +0200
+++ ...
| Jun 5, 1:23 pm 2008 |
| Marcin Obara | [PATCH] tpm:correct tpm timeouts to jiffies conversion
This patch fixes timeouts conversion to jiffies,
by replacing msecs_to_jiffies() calls with usecs_to_jiffies().
According to TCG TPM Specification Version 1.2 Revision 103 (pages 166, 167)
TPM timeouts and durations are returned in microseconds (usec)
not in miliseconds (msec).
Signed-off-by: Marcin Obara <marcin_obara@users.sourceforge.net>
--- linux/drivers/char/tpm/tpm.c 2008-06-05 20:57:06.000000000 +0200
+++ linux_tpm/drivers/char/tpm/tpm.c 2008-06-05 20:54:52.000000000 +0200
@@ -524,19 ...
| Jun 5, 1:19 pm 2008 |
| Scott Wiersdorf | [PATCH 2.6.25-4] getdelays.c: signal handling for log rotation
This adds a USR1 signal handler to getdelays.c, which causes getdelays
to close its logfile and reopen it (if '-w logfile' is
specified). This is useful in situations when getdelays is running for
a long time (i.e, the log file growing) and you need to rotate the
logs but don't want to lose any log data.
Signed-off-by: Scott Wiersdorf <scott@perlcode.org>
---
--- Documentation/accounting/getdelays.c 2008-05-15 09:00:12.000000000 -0600
+++ Documentation/accounting/getdelays.c 2008-06-05 ...
| Jun 5, 12:43 pm 2008 |
| Scott Wiersdorf | [PATCH] getdelays.c
File: Documentation/accounting/getdelays.c
Linux version: 2.6.25-4
Description:
This patch adds a USR1 signal handler to getdelays.c, which causes
getdelays to close its logfile and reopen it (if '-w logfile' is
specified). This is useful in situations when getdelays is running for
a long time (i.e, the log file growing) and you need to rotate the
logs but don't want to lose any log data.
Sample usage:
1 # ./getdelays -m0,1,2,3 -l -w getdelays.log &
(time passes)
2 # mv ...
| Jun 5, 12:30 pm 2008 |
| 胡育茹 | 2008/6/6 - 4:3:36
2008-6-6 - 4:3
山p鉧t科y技C網v頁2設s計
我L們m的K宗f旨c:客戶的每ㄧ件小事情,都是山鉧的大事情
我9們6S在r推出企業形象網站包含前台網頁美工+後台管理程式
限P時L限o量b專案價 只要$24,900 (在送ㄧ年100MB 不限流量網站空間)
我l們k做a的8不W只0是l網X站,而m是9您N企y業Z的z入I口
ㄧv個t好Y的s企k業j網e站3資9料d即M時R更J新w的Z速6度X是P很U重7要l的
企C業e化N高M品3質D團l隊,打w造x您a的D網t路K門y面
選5擇4山F鉧C成V就4您o的H夢36想
歡迎來電洽詢黃專員:0_9_8_0_1_1_9_8_1_2
←4×v℃b+E∴
| Jun 5, 1:03 pm 2008 |
| Daniel Walker | Re: [patch] sched: prevent bound kthreads from changing ...
I'm all for it .. I've crashed test systems just by migrating tasks that
are suppose to stay bound while using cpusets ..
Daniel
--
| Jun 5, 1:52 pm 2008 |
| David Rientjes | Re: [patch] sched: prevent bound kthreads from changing ...
Not in the drivers/pci/pci-driver.c case because the setting of
cpus_allowed to nodecpumask is only temporary (as is the disabling of the
mempolicy). It's just done for the probe callback and then reset to the
old cpumask. So any migration here would be lost.
I can't speculate about the net/sunrpc/svc.c case because I don't know if
user migration is harmful or discouraged. The behavior with my patch is
the same for any calls to set_cpus_allowed_ptr() for tasks that haven't
called ...
| Jun 5, 2:12 pm 2008 |
| Paul Jackson | Re: [patch] sched: prevent bound kthreads from changing ...
A couple of questions on this:
1) Sometimes threads are bound to a set of CPUs, such as the CPUs
on a particular node:
drivers/pci/pci-driver.c: set_cpus_allowed_ptr(current, nodecpumask);
net/sunrpc/svc.c: set_cpus_allowed_ptr(current, nodecpumask);
Such cases can't invoke kthread_bind(), as that only binds to a single CPU.
I only see one place in your patch that sets PF_THREAD_BOUND; would it make
sense for such multi-CPU binds as above to be ...
| Jun 5, 1:29 pm 2008 |
| David Rientjes | [patch] sched: prevent bound kthreads from changing cpus ...
Kthreads that have called kthread_bind() are bound to specific cpus, so
other tasks should not be able to change their cpus_allowed from under
them. Otherwise, it is possible to move kthreads, such as the migration
or software watchdog threads, so they are not allowed access to the cpu
they work on.
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Menage <menage@google.com>
Cc: Paul Jackson <pj@sgi.com>
Signed-off-by: David Rientjes <rientjes@google.com>
---
include/linux/sched.h | 1 ...
| Jun 5, 12:57 pm 2008 |
| Paul Jackson | Re: [patch] sched: prevent bound kthreads from changing ...
Ok - looks good to me. (I too have shot my foot off
moving tasks that shouldn't be moved - thanks.)
Reviewed-by: Paul Jackson <pj@sgi.com>
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.940.382.4214
--
| Jun 5, 2:47 pm 2008 |
| Nicholas A. Bellinger | RE: Vpools and v3.0-UPSTREAM LIO
Having central servers (and having to worry about the redundancy of said
Hmm, not bad. I usually have to go for a walk or two to come up with
good project names.. :-)
--
| Jun 5, 12:36 pm 2008 |
| Andrew Morton | Re: [PATCH] ext2: Use page_mkwrite vma_operations to get ...
On Thu, 5 Jun 2008 22:35:12 +0530
Whoa. You didn't copy anything like enough mailing lists for a change
of this magnitude. I added some.
This is a large change in behaviour!
a) applications will now get a synchronous SIGBUS when modifying a
page over an ENOSPC filesystem. Whereas previously they could have
proceeded to completion and then detected the error via an fsync().
It's going to take more than one skimpy little paragraph to
justify this, and to demonstrate that it ...
| Jun 5, 12:30 pm 2008 |
| Jaroslav Franek | [PATCH] sound: emu10k1 - fix system hang with Audigy2 ZS ...
from: Jaroslav Franek
When the Linux kernel is compiled with CONFIG_DEBUG_SHIRQ=y,
the Soundblaster Audigy2 ZS Notebook PCMCIA card causes the
system hang during boot (udev stage) or when the card is hot-plug.
The CONFIG_DEBUG_SHIRQ flag is by default 'y' with all Fedora
kernels since 2.6.23. The problem was reported as
https://bugzilla.redhat.com/show_bug.cgi?id=326411
The issue was hunted down to the snd_emu10k1_create() routine:
/* pseudo-code */
snd_emu10k1_create(...) ...
| Jun 5, 12:13 pm 2008 |
| Jesse Barnes | Re: [PATCH] OLPC: pci: fix up PCI stuff so that PCI_GOAN ...
Heh, yeah I've been taking quite a few x86 PCI patches (Ingo actually has a
queue of them for me now), so I can pick this one up and put it in what I
hope will be my final 2.6.26 pull request.
Jesse
--
| Jun 5, 1:34 pm 2008 |
| Andres Salomon | Re: [PATCH] OLPC: pci: fix up PCI stuff so that PCI_GOAN ...
On Thu, 5 Jun 2008 13:07:35 -0700 (PDT)
The options above GOANY are included in GOANY.
Previously, GOANY did not support GOOLPC, so GOOLPC was listed after it.
Now that GOANY supports GOOLPC, it can be listed above w/ the others.
Plus, _I_ think it looks nicer. :) That hunk can easily be removed from
the patch if others disagree.
--
| Jun 5, 1:27 pm 2008 |
| Andres Salomon | [PATCH] OLPC: pci: fix up PCI stuff so that PCI_GOANY su ...
Previously, one would have to specifically choose CONFIG_OLPC and
CONFIG_PCI_GOOLPC in order to enable PCI_OLPC. That doesn't really
work for distro kernels, so this patch allows one to choose
CONFIG_OLPC and CONFIG_PCI_GOANY in order to build in OLPC support in
a generic kernel (as requested by Robert Millan).
This also moves GOOLPC before GOANY in the menuconfig list.
Finally, make pci_access_init return early if we detect OLPC hardware.
There's no need to continue probing stuff, and ...
| Jun 5, 12:29 pm 2008 |
| Thomas Gleixner | Re: [PATCH] OLPC: pci: fix up PCI stuff so that PCI_GOAN ...
So the Salomonic solution is:
You pick it up and send it either to Jesse or x86@kernel.org :)
I put it into my urgent bucket just to be on the safe side.
Thanks,
tglx
--
| Jun 5, 1:49 pm 2008 |
| Andrew Morton | Re: [PATCH] OLPC: pci: fix up PCI stuff so that PCI_GOAN ...
On Thu, 5 Jun 2008 15:29:14 -0400
But I never know whether arch/x86/pci is a Jesse thing or an Ingo
thing. Usual answer: it's an everyone thing and we all make a big mess ;)
--
| Jun 5, 12:42 pm 2008 |
| Randy.Dunlap | Jun 5, 1:07 pm 2008 | |
| Thomas Tuttle | [PATCH 4/4] pagemap: Add documentation for pagemap
Just a quick explanation of the pagemap interface from a userspace point
of view, and an example of how to use it (in English, not code).
Signed-off-by: Thomas Tuttle
---
Documentation/vm/pagemap.txt | 77 ++++++++++++++++++++++++++++++++++++++++++
1 files changed, 77 insertions(+), 0 deletions(-)
create mode 100644 Documentation/vm/pagemap.txt
diff --git a/Documentation/vm/pagemap.txt b/Documentation/vm/pagemap.txt
new file mode 100644
index 0000000..b33a5e4
--- /dev/null
+++ ...
| Jun 5, 11:40 am 2008 |
| Thomas Tuttle | [PATCH 3/4] pagemap: Return EINVAL, not EIO, for unalign ...
If the user tries to read from a position that is not a multiple of 8, or
read a number of bytes that is not a multiple of 8, they have passed an
invalid argument to read, for the purpose of reading these files. It's
not an IO error because we didn't encounter any trouble finding the data
they asked for.
Signed-off-by: Thomas Tuttle
---
fs/proc/proc_misc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/proc/proc_misc.c b/fs/proc/proc_misc.c
index ...
| Jun 5, 11:40 am 2008 |
| Matt Mackall | Re: [PATCH 3/4] pagemap: Return EINVAL, not EIO, for una ...
Hmm. I seem to recall choosing EIO because that's what unaligned reads
with direct I/O report. I don't particularly care though.
Acked-by: Matt Mackall <mpm@selenic.com>
--
Mathematics is the supreme nostalgia of our time.
--
| Jun 5, 11:49 am 2008 |
| Thomas Tuttle | [PATCH 2/4] pagemap: Return map count, not reference cou ...
Since pagemap is all about examining pages mapped into processes' memory
spaces, it makes sense for kpagecount to return the map counts, not the
reference counts.
Signed-off-by: Thomas Tuttle
---
fs/proc/proc_misc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/proc/proc_misc.c b/fs/proc/proc_misc.c
index 32dc14c..5a16090 100644
--- a/fs/proc/proc_misc.c
+++ b/fs/proc/proc_misc.c
@@ -726,7 +726,7 @@ static ssize_t kpagecount_read(struct file *file,
char ...
| Jun 5, 11:39 am 2008 |
| Thomas Tuttle | [PATCH 1/4] pagemap: Require reads of /proc/pid/pagemap ...
This matches the behavior of /proc/kpage{count,flags}, and simplifies
the logic a bit.
I also changed out and end in struct pagemapread to be u64* instead of
char*, which makes put_user work the way it was intended. (Before, it
was only copying the bottom byte of a pagemap entry, because the target
of the copy was a char*.)
Signed-off-by: Thomas Tuttle
---
fs/proc/task_mmu.c | 28 +++++++++-------------------
1 files changed, 9 insertions(+), 19 deletions(-)
diff --git ...
| Jun 5, 11:38 am 2008 |
| Andrew Morton | Re: [PATCH 1/4] pagemap: Require reads of /proc/pid/page ...
On Thu, 5 Jun 2008 14:38:10 -0400
This one is for 2.6.25.x?
Is so, the maintainers are going to wonder why the heck we sent it to
them. It does fix a bug, but it is far from clear what that bug is.
Please include <ttuttle@google.com> in the signoffs.
--
| Jun 5, 12:37 pm 2008 |
| Andrew Morton | Re: [PATCH 1/4] pagemap: Require reads of /proc/pid/page ...
On Thu, 05 Jun 2008 15:51:59 -0500
OK. I can't merge that I guess, so could someome please prepare a
formal patch for the stable guys? Preferably one which remembers
to add __user to that cast :)
--
| Jun 5, 3:05 pm 2008 |
| Matt Mackall | Re: [PATCH 1/4] pagemap: Require reads of /proc/pid/page ...
This one is for 2.6.26. Something more like this for 2.6.25.x:
Because put_user bases its copy size on the size of the target pointer,
not the source, it was copying only 1 byte rather than the intended 8.
Spotted-by: Thomas Tuttle <ttuttle@google.com>
Signed-off-by: Matt Mackall <mpm@selenic.com>
diff -r 5030869d9ded fs/proc/task_mmu.c
--- a/fs/proc/task_mmu.c Thu Jun 05 04:01:40 2008 +0000
+++ b/fs/proc/task_mmu.c Thu Jun 05 15:45:00 2008 -0500
@@ -531,7 +531,7 @@
return ...
| Jun 5, 1:51 pm 2008 |
| Adrian Bunk | [2.6 patch] include/linux/ssb/ssb_driver_gige.h typo fix
This patch fixes a typo in the name of a config variable.
Reported-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
2aab8eeb46b30baf987c344e1b144caec365373a diff --git a/include/linux/ssb/ssb_driver_gige.h b/include/linux/ssb/ssb_driver_gige.h
index 01fbdf5..942e387 100644
--- a/include/linux/ssb/ssb_driver_gige.h
+++ b/include/linux/ssb/ssb_driver_gige.h
@@ -100,7 +100,7 @@ extern char * nvram_get(const char *name);
/* Get the device MAC ...
| Jun 5, 11:29 am 2008 |
| Michael Buesch | Re: [2.6 patch] include/linux/ssb/ssb_driver_gige.h typo fix
--
Greetings Michael.
--
| Jun 5, 11:42 am 2008 |
| Robert P. J. Day | Re: [2.6 patch] include/linux/ssb/ssb_driver_gige.h typo fix
just FYI, there are more (admittedly aesthetic) references to
BCM947XX in the MIPS directory:
$ grep -r "BCM947XX" *
include/linux/ssb/ssb_driver_gige.h:#ifdef CONFIG_BCM947XX
include/asm-mips/mach-bcm47xx/war.h:#ifndef __ASM_MIPS_MACH_BCM947XX_WAR_H
include/asm-mips/mach-bcm47xx/war.h:#define __ASM_MIPS_MACH_BCM947XX_WAR_H
include/asm-mips/mach-bcm47xx/war.h:#endif /* __ASM_MIPS_MACH_BCM947XX_WAR_H */
$
whether you want to do anything about those is up to ...
| Jun 5, 11:34 am 2008 |
| Adrian Bunk | [2.6 patch] m68k: remove AP1000 code
Unless I miss something that's code for a sparc machine even the sparc
code no longer supports that got copied to m68k when these files were
copied.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
arch/m68k/sun3/prom/console.c | 4 ----
arch/m68k/sun3/prom/init.c | 9 ---------
arch/m68k/sun3/prom/printf.c | 5 -----
include/asm-m68k/oplib.h | 1 -
4 files changed, 19 deletions(-)
0bae6d3f656139602f96e0ace2766a40d9da5725 diff --git ...
| Jun 5, 11:26 am 2008 |
| Andrew Morton | Re: [PATCH 0/2] Remove BKL from the bfs driver
On Thu, 5 Jun 2008 21:26:35 +0300
How well tested was this? With lockdep enabled?
Because the new mutex cannot be taken recursively, whereas the BKL can.
And there's potential for ab/ba deadlocks with, for example, i_mutex.
However I don't see any such problems from a moderately intensive
review.
--
| Jun 5, 11:42 am 2008 |
| Dmitri Vorobiev | [PATCH 0/2] Remove BKL from the bfs driver
Hi Andrew,
This removes quite a few instances of BKL usage in the bfs
driver. Given the purpose and the user base of this driver,
I do not believe that a finer-granularity lock than the big
fat filesystem-wide mutex I have implemented here is needed.
Please consider.
Thanks,
Dmitri
--
| Jun 5, 11:26 am 2008 |
| Vorobiev Dmitri | Re: [PATCH 0/2] Remove BKL from the bfs driver
Frankly speaking, I performed just some basic tests like mounting
a BFS partition, creating a few files on it, reading and writing
OK, thank you for the review and for picking up the patches.
Dmitri
--
| Jun 5, 2:11 pm 2008 |
| Dmitri Vorobiev | [PATCH 1/2] bfs: assorted cleanups
This patch makes the following cleanups:
o removing an unused variable from bfs_fill_super();
o removing unneeded blank spaces from pointer
definitions.
Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
---
fs/bfs/bfs.h | 4 ++--
fs/bfs/inode.c | 3 +--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/bfs/bfs.h b/fs/bfs/bfs.h
index 70f5d3a..d1a6cd1 100644
--- a/fs/bfs/bfs.h
+++ b/fs/bfs/bfs.h
@@ -16,8 +16,8 @@ struct bfs_sb_info {
unsigned ...
| Jun 5, 11:26 am 2008 |
| Dmitri Vorobiev | [PATCH 2/2] bfs: kill BKL
This patch replaces the BKL-based locking scheme used in the
bfs driver by a private filesystem-wide mutex.
Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
---
fs/bfs/bfs.h | 1 +
fs/bfs/dir.c | 46 ++++++++++++++++++++++++++--------------------
fs/bfs/file.c | 4 ++--
fs/bfs/inode.c | 24 +++++++++++++++---------
4 files changed, 44 insertions(+), 31 deletions(-)
diff --git a/fs/bfs/bfs.h b/fs/bfs/bfs.h
index d1a6cd1..7109e45 100644
--- a/fs/bfs/bfs.h
+++ ...
| Jun 5, 11:26 am 2008 |
| Adrian Bunk | [2.6 patch] ocfs2/cluster/tcp.c: make some functions static
Commit 0f475b2abed6cbccee1da20a0bef2895eb2a0edd
(ocfs2/net: Silence build warnings) made sense
as far as it fixed compile warnings, but it was
not required that it made the functions global.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
fs/ocfs2/cluster/tcp.c | 44 ++++++++++++++++++++++++++------
fs/ocfs2/cluster/tcp_internal.h | 32 -----------------------
2 files changed, 37 insertions(+), 39 deletions(-)
dd88fbb63c1952663eed2f1d93b85a95938cf37c diff --git ...
| Jun 5, 11:25 am 2008 |
| Rafael J. Wysocki | Re: [2.6 patch] remove include/linux/pm_legacy.h
--
"Premature optimization is the root of all evil." - Donald Knuth
--
| Jun 5, 1:19 pm 2008 |
| Adrian Bunk | [2.6 patch] remove include/linux/pm_legacy.h
This patch removes the obsolete and no longer used
include/linux/pm_legacy.h
Reported-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
BTW: arch/arm/mach-sa1100/h3600.c:h3800_pm_callback() still tries to
handle PM_{SUSPEND,RESUME}, but that's not touched by this patch.
arch/frv/kernel/pm.c | 1
arch/mips/au1000/common/power.c | 1
arch/x86/kernel/apm_32.c | 1
include/linux/pm_legacy.h | 35 ...
| Jun 5, 11:23 am 2008 |
| Adrian Bunk | [2.6 patch] m68k: make multi_defconfig the default defconfig
It seems to match the intention behind multi_defconfig to make it the
default defconfig.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
55c8d7ed853df41c5fe97a1e529a2ddeeded98ef diff --git a/arch/m68k/Makefile b/arch/m68k/Makefile
index b15173f..8133dbc 100644
--- a/arch/m68k/Makefile
+++ b/arch/m68k/Makefile
@@ -13,7 +13,7 @@
# Copyright (C) 1994 by Hamish Macdonald
#
-KBUILD_DEFCONFIG := amiga_defconfig
+KBUILD_DEFCONFIG := multi_defconfig
# override top level makefile
AS ...
| Jun 5, 11:22 am 2008 |
| Randy.Dunlap | [PATCH -next] x86: fix longstanding setup.c printk forma ...
From: Randy Dunlap <randy.dunlap@oracle.com>
Note: for -next only, not mainline.
Fix setup.c printk format warning:
linux-next-20080605/arch/x86/kernel/setup.c: In function 'setup_per_cpu_areas':
linux-next-20080605/arch/x86/kernel/setup.c:173: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'ssize_t'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
arch/x86/kernel/setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- ...
| Jun 5, 11:10 am 2008 |
| Thomas Backlund | iwl4965 oops in 2.6.25-rc5 x86_64
Hi,
(please cc me on replies as I'm not subscribed)
booting a 2.6.26-rc5 x86_64 kernel on a Acer TravelMate 6720G laptop
and shortly after the system locks up hard...
Config is here:
http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/kernel-linus/current/SOURCE...
So far I have tested 2.6.26-rc3,rc4,rc5 and all ends up with this oops
If I remove the wlan0 config the kernel will boot, but as soon as I try
to configure it, I get a ...
| Jun 5, 10:55 am 2008 |
| Thomas Backlund | Re: iwl4965 oops in 2.6.25-rc5 x86_64
Yep. will do...
I'll report back as soon as I have tried..
--
Thomas
--
| Jun 5, 11:09 am 2008 |
| Thomas Backlund | Re: iwl4965 oops in 2.6.25-rc5 x86_64
And for reference I also tried 2.6.25.4 wich works as it should
--
Thomas
--
| Jun 5, 1:10 pm 2008 |
| Tomas Winkler | Re: iwl4965 oops in 2.6.25-rc5 x86_64
Can you please verify with latest wireless-testing. git
Thanks
--
| Jun 5, 11:03 am 2008 |
| Thomas Backlund | Re: iwl4965 oops in 2.6.26-rc5 x86_64
And I have now tested 2.6.26-rc1 wich also has the oops, so I guess it's
--
| Jun 5, 2:48 pm 2008 |
| Khaled Al-Hamwi | SMP Affinity Issue with IRQ#
Hi list,
I am trying to evaluate the performance of a Linux box when working as
IP forwarder.
I have a hardware traffic generator IXIA T400 on one end.
On the other end, I have a Linux box with kernel 2.6.16 and quad-core xeon CPU.
These two systems are connected through two crossover Gigabit cables and NICs.
The traffic is sent from IXIA through one NIC to the forwarding machine
and then it is forwarded back through the other NIC to IXIA.
I have two issues related to SMP affinity.
The ...
| Jun 5, 10:13 am 2008 |
| Stas Sergeev | [patch][resend] pcspkr: undepend of snd-pcsp
Hello.
It should be possible to build
pcspkr driver together with snd-pcsp.
Even though right now there is no
good plan to get these drivers to
work together, some things were done,
namely:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=16dc42e018...
and
https://bugzilla.redhat.com/show_bug.cgi?id=448425
which looks more or less sufficient.
And there was a discussion ...
| Jun 5, 9:48 am 2008 |
| Grant Likely | Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the m ...
On Thu, Jun 5, 2008 at 10:16 AM, Anton Vorontsov
Personally I think your v2 was better, and if I'm interpreting
Pierre's comments correctly I think his main point is that instead of
using the 'stock' probe/remove hooks for the spi mmc driver, the
driver should be mildly reworked to provide a common block of code
that can be used by both the OF and non-OF versions of the
probe/remove routines. I also think that is the way to go.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab ...
| Jun 5, 9:45 am 2008 |
| Anton Vorontsov | [PATCH] [RFC v3] OF: OpenFirmware bindings for the mmc_s ...
Here is v3. I'm out of ideas if you won't like it. :-)
v3:
- Now these bindings are using bus notifiers chain, thus we adhere to the
spi bus.
By the way, this scheme (IMO) looks good for I2C devices which needs
platform_data extracted from the device tree too (Cc'ing Jochen).
- Plus changed the OF bindings themselves, implemented voltage-range
property. (Pierre, please take a look at vddrange_to_ocrmask(). I
wonder if you would like this in the MMC core instead, with a kernel
...
| Jun 5, 9:16 am 2008 |
| Anton Vorontsov | Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the m ...
Well, I mentioned the usb_add_hcd()-alike approach for the mmc_spi
host... The absence of enthusiasm I equaled to "no".
Heh.
p.s.
Btw, you forgot another downside of v2 approach: struct spi_driver
duplication... Not sure if everyone will be happy about it.
Though, v2 is only version where we can make modular OF_MMC_SPI.
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
--
| Jun 5, 10:27 am 2008 |
| Grant Likely | Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the m ...
On Thu, Jun 5, 2008 at 11:27 AM, Anton Vorontsov
I think we've got our wires crossed. I'm not referring to the option
of an of_mmc_spi driver registering an mmc_spi device (which can then
be probed by the mmc_spi_driver). I'm referring to refactoring the
probe/remove code so that common stuff is callable by both the mmc_spi
and of_mmc_spi drivers without the oddity of the of_mmc_spi probe hook
calling the mmc_spi probe hook.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab ...
| Jun 5, 10:36 am 2008 |
| Anton Vorontsov | Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the m ...
Ok, I also mentioned drivers/ata/pata_of_platform.c (OF version is using
common code from drivers/ata/pata_platform.c).
Please look there, and tell me if this is what you have in mind. (ignore
_probe in the __pata_platform_probe name. Imagine
I understand this.
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
--
| Jun 5, 11:00 am 2008 |
| Grant Likely | Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the m ...
On Thu, Jun 5, 2008 at 12:00 PM, Anton Vorontsov
Yes, I like that. I've done something very similar for drivers with
both of and non-of bindings. For another example, this time all
Okay, I'm confused then. Where is the duplication of struct spi_driver?
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
| Jun 5, 11:18 am 2008 |
| Anton Vorontsov | Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the m ...
Here it is http://lkml.org/lkml/2008/5/23/299
+ static struct spi_driver of_mmc_spi_driver = {
^^^ That reminds me v1.
Here http://lkml.org/lkml/2008/5/25/5 you answered though, but there
was no bottom line.
I hope the bottom line is that we're now all happy to create another
spi_driver to handle "OF MMC-o-SPI" devices..?
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
--
| Jun 5, 11:31 am 2008 |
| Grant Likely | Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the m ...
On Thu, Jun 5, 2008 at 12:31 PM, Anton Vorontsov
Right; I was going down the wrong thought path. I have no problem with this.
BTW, while on that topic, I think it is reasonable to roll the members
of of_mmc_spi into either the mmc_spi_platform_data or the
mmc_spi_host structure. It is just 2 integers and that would
Yeah; I'm not fond of that approach. It incurs runtime cost of
Yes, I'm cool with it.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
| Jun 5, 11:42 am 2008 |
| David Howells | [PATCH] FRV: ip_fast_csum() requires a memory clobber on ...
ip_fast_csum() requires a memory clobber on its inline asm as it accesses
memory in a fashion that gcc can't predict.
The GCC manual says:
If your assembler instructions access memory in an unpredictable
fashion, add `memory' to the list of clobbered registers. This will
cause GCC to not keep memory values cached in registers across the
assembler instruction and not optimize stores or loads to that memory.
The bug hasn't been noticed in FRV, but it has been seen in ...
| Jun 5, 9:07 am 2008 |
| Matthew Wilcox | Re: [PATCH] FRV: ip_fast_csum() requires a memory clobbe ...
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
| Jun 5, 11:57 am 2008 |
| Andrea Arcangeli | Re: [PATCH 2 of 3] mm_take_all_locks
From: Andrea Arcangeli <andrea@qumranet.com>
Indeed, I meant mm_all_locks_mutex, this will fix it, or if you prefer
a resubmit of the 2/3 let me know. Thanks!
Signed-off-by: Andrea Arcangeli <andrea@qumranet.com>
---
diff -r 082f312bc682 mm/mmap.c
--- a/mm/mmap.c Thu Jun 05 17:30:17 2008 +0200
+++ b/mm/mmap.c Thu Jun 05 18:40:23 2008 +0200
@@ -2263,7 +2263,7 @@ static void vm_lock_anon_vma(struct anon
if (!test_bit(0, (unsigned long *) &anon_vma->head.next)) {
/*
* The LSB of ...
| Jun 5, 9:44 am 2008 |
| Linus Torvalds | Re: [PATCH 2 of 3] mm_take_all_locks
Just a small comment fix.
There's no global_mm_spinlock, you mean the 'mm_all_locks_mutex'.
(There was at least one other case where you had that comment issue).
Linus
--
| Jun 5, 9:15 am 2008 |
| Andrea Arcangeli | [PATCH 3 of 3] mmu-notifier-core
From: Andrea Arcangeli <andrea@qumranet.com>
With KVM/GFP/XPMEM there isn't just the primary CPU MMU pointing to
pages. There are secondary MMUs (with secondary sptes and secondary
tlbs) too. sptes in the kvm case are shadow pagetables, but when I say
spte in mmu-notifier context, I mean "secondary pte". In GRU case
there's no actual secondary pte and there's only a secondary tlb
because the GRU secondary MMU has no knowledge about sptes and every
secondary tlb miss event in the MMU always ...
| Jun 5, 8:36 am 2008 |
| Andrea Arcangeli | [PATCH 2 of 3] mm_take_all_locks
From: Andrea Arcangeli <andrea@qumranet.com>
mm_take_all_locks holds off reclaim from an entire mm_struct. This allows mmu
notifiers to register into the mm at any time with the guarantee that no mmu
operation is in progress on the mm.
This operation locks against the VM for all pte/vma/mm related operations that
could ever happen on a certain mm. This includes vmtruncate, try_to_unmap, and
all page faults.
The caller must take the mmap_sem in write mode before calling
mm_take_all_locks(). ...
| Jun 5, 8:36 am 2008 |
| Andrea Arcangeli | [PATCH 0 of 3] mmu notifier v18
This splits the list.h changes in patch number 1, mm_take_all_locks patch 2,
and mmu-notifier-core becomes patch 3 as requested.
mm_take/drop_all_locks have been cleaned up as requested to move the bitflips
in proper methods outside the main vma loop.
--
| Jun 5, 8:36 am 2008 |
| Andrea Arcangeli | [PATCH 1 of 3] list_del_init_rcu
From: Andrea Arcangeli <andrea@qumranet.com>
Introduces list_del_init_rcu and documents it (fixes a comment for
list_del_rcu too).
Signed-off-by: Andrea Arcangeli <andrea@qumranet.com>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
---
diff -r 86e3ce291996 -r becc195598f8 include/linux/list.h
--- a/include/linux/list.h Wed Jun 04 10:35:03 2008 -0700
+++ b/include/linux/list.h Thu Jun 05 17:30:14 2008 +0200
@@ -747,7 +747,7 @@ static inline void hlist_del(struct hlis
* or ...
| Jun 5, 8:36 am 2008 |
| Jan Beulich | Re: [PATCH] x86: set PAE PHYSICAL_MASK_SHIFT to match 64-bit
Hmm? There's 11 bits available - why would anyone want to assign bits
from the sufficiently official (at least as far as AMD is concerned, I'm not
sure I saw a precise statement on Intel's side) frame number bits? And
even if they would, it would certainly take some control register bit to
enable the feature, so shrinking the mask if that would ever happen
would seem more appropriate.
Bottom line - I'd suggest pushing both 32- and 64-bits up to 52.
Jan
--
| Jun 5, 8:34 am 2008 |
| Jeremy Fitzhardinge | Re: [PATCH] x86: set PAE PHYSICAL_MASK_SHIFT to match 64-bit
I'm more concerned that it might not be possible. I'm trying to think
how many places have compile-time constants derived from this mask.
You mean, if new bits appear we can just adjust the mask accordingly to
I don't see any relationship between the physical and virtual size.
Certainly virtual is fixed at 48 bits (4*9+12), but I don't think
there's any deep reason why physical needs to be within 3 bits.
J
--
| Jun 5, 2:14 pm 2008 |
| Jeremy Fitzhardinge | [PATCH] x86: set PAE PHYSICAL_MASK_SHIFT to match 64-bit
When a 64-bit x86 processor runs in 32-bit PAE mode, a pte can
potentially have the same number of physical address bits as the
64-bit host ("Enhanced Legacy PAE Paging").
This is a bugfix for two cases:
1. running a 32-bit PAE kernel on a machine with
more than 64GB RAM.
2. running a 32-bit PAE Xen guest on a host machine with
more than 64GB RAM
In both cases, a pte could need to have more than 36 bits of physical,
and masking it to 36-bits will cause fairly severe havoc.
The ...
| Jun 5, 8:21 am 2008 |
| Jeremy Fitzhardinge | Re: [PATCH] x86: set PAE PHYSICAL_MASK_SHIFT to match 64-bit
The Intel docs list those 11 bits as available to software, and are not
reserved for any future flags they may want to add. I was a bit
We could have an auction:
Do I hear 46? 47? 48? 50? 52! Going once, twice, 52 bits!
Anyway, we can fix it later in a separate patch. This is a
change-as-little-as-possible bugfix patch.
J
--
| Jun 5, 8:42 am 2008 |
| H. Peter Anvin | Re: [PATCH] x86: set PAE PHYSICAL_MASK_SHIFT to match 64-bit
It should either be 52 bits or dynamic based on CPUID information. The
latter is very expensive.
If there end up being additional control bits assigned in this space we
won't use them since we know the size of the address space (which won't
include the control bits) and thus will leave them at zero.
It's largely theoretical, since I believe Linux on x86-64 relies on
virtual >= physical+N, where I believe N is about 3 bits, and the page
table format or page size need to change to ...
| Jun 5, 9:45 am 2008 |
| Thomas Tuttle | [PATCH 5/5] pagemap: Wrote some userspace-oriented docum ...
This is just a quick bit of documentation for pagemap from a userspace
perspective, so users of the interface don't have to dig in to the
source code. It describes the three interfaces (pagemap, kpagecount,
kpageflags), and explains how they might be used.
| Jun 5, 8:09 am 2008 |
| Thomas Tuttle | [PATCH 4/5] pagemap: Make /proc/kpage{count,flags} retur ...
If a process tries to read at a position that's not a multiple of 8,
or for a count that's not a multiple of 8, they've passed an invalid
argument to read (for this file), so we should return EINVAL.
| Jun 5, 8:07 am 2008 |
| Matt Mackall | Re: [PATCH 4/5] pagemap: Make /proc/kpage{count,flags} r ...
This patch should probably precede your 3/5.
--
Mathematics is the supreme nostalgia of our time.
--
| Jun 5, 9:24 am 2008 |
| Matt Mackall | Re: [PATCH 3/5] pagemap: Make pagemap_read enforce readi ...
I suppose you're right, people usually don't check those return codes.
--
Mathematics is the supreme nostalgia of our time.
--
| Jun 5, 9:21 am 2008 |
| Thomas Tuttle | [PATCH 3/5] pagemap: Make pagemap_read enforce reading i ...
Since kpagecount and kpageflags require reads in multiples of 8, and
it simplifies add_to_pagemap significantly, I added the same
requirement to /proc/pid/pagemap.
| Jun 5, 8:06 am 2008 |
| Thomas Tuttle | Re: [PATCH 3/5] pagemap: Make pagemap_read enforce readi ...
This doesn't require that they read exactly 8 bytes, just that they
read some multiple of 8 bytes. (They can read 8, 16, 24, etc..., just
not something like 12.)
--ttuttle
--
| Jun 5, 9:05 am 2008 |
| Matt Mackall | Re: [PATCH 3/5] pagemap: Make pagemap_read enforce readi ...
I'm generally fine with this. Another approach that's perhaps more
friendly is when someone tries to do a 24-byte read, do a 16-byte read,
leaving the file pointer aligned. Not sure if that's completely kosher
though.
--
Mathematics is the supreme nostalgia of our time.
--
| Jun 5, 9:03 am 2008 |
| Thomas Tuttle | Re: [PATCH 3/5] pagemap: Make pagemap_read enforce readi ...
Oh. I would seriously question doing that, because it would allow
reads that are improperly split up to fail silently. What happens if
someone tries to read 40 bytes, and (for some reason) it gets split
into two 20-byte reads? Instead of "12345" they'll get "12.34."
(where . is 4 zero or garbage bytes). I'd rather they get an error.
--ttuttle
--
| Jun 5, 9:14 am 2008 |
| Matt Mackall | Re: [PATCH 3/5] pagemap: Make pagemap_read enforce readi ...
Yes, I got that, I'm just mathematically impaired this morning. Read
that as "when someone tries to do a *20* byte read, do a 16-byte read.."
In other words, round down to the nearest multiple of 8.
--
Mathematics is the supreme nostalgia of our time.
--
| Jun 5, 9:09 am 2008 |
| Lior Dotan | Re: Linux 2.6.26-rc5
I also got these after upgrading from 2.6.25.4 and also these messages:
Jun 5 16:26:58 ps3 [ 20.763385] AER service couldn't init device
0000:00:02.0:pcie01 - no _OSC support
Jun 5 16:26:58 ps3 [ 20.763385] AER service couldn't init device
0000:00:03.0:pcie01 - no _OSC support
Jun 5 16:26:58 ps3 [ 20.763385] AER service couldn't init device
0000:00:04.0:pcie01 - no _OSC support
Jun 5 16:26:58 ps3 [ 20.763385] AER service couldn't init device
0000:00:05.0:pcie01 - no _OSC support
Jun ...
| Jun 5, 8:04 am 2008 |
| Matt Mackall | Re: [PATCH 2/5] pagemap: Change kpagecount to return the ...
I'm pretty sure this has been suggested before and I was just too
thick-skulled to get it. Yes, the reference count is less useful.
Acked-by: Matt Mackall <mpm@selenic.com>
ps: It's much prefered to send patches inline.
--
Mathematics is the supreme nostalgia of our time.
--
| Jun 5, 9:01 am 2008 |
| Thomas Tuttle | [PATCH 2/5] pagemap: Change kpagecount to return the map ...
When trying to use pagemap to calculate the "proportional set size"
[1] of a process, I discovered that there were often references to
pages that could not be discovered by kpagecount. I changed
kpagecount to return the number of times a page is mapped, rather than
referenced, so kpagecount is more useful for determining how many
processes are using a page.
[1] PSS is the amount of memory used by a process, weighted by 1 / the
number of processes sharing the memory -- so a 128K library ...
| Jun 5, 8:04 am 2008 |
| Thomas Tuttle | Re: [PATCH 2/5] pagemap: Change kpagecount to return the ...
Oh. Sorry about that. (It's been a while since I sent patches to LKML.)
--ttuttle
--
| Jun 5, 9:03 am 2008 |
| Andrew Morton | Re: [PATCH 1/5] pagemap: Modify add_to_pagemap to use co ...
On Thu, 5 Jun 2008 11:04:21 -0400
so... afaict we have some fairly significant problems in here and a
version 2 of the patchset is in order?
If so, when preparing that patchset please do have a think about which
of the fixes you believe should be backported into 2.6.25.x and prepare
the patches so that those fixes come first, to ease that backporting.
Thanks.
--
| Jun 5, 12:02 pm 2008 |
| Matt Mackall | Re: [PATCH 1/5] pagemap: Modify add_to_pagemap to use co ...
For 2.6.25.x, we should probably just add a cast to the put_user dest.
Thomas?
--
Mathematics is the supreme nostalgia of our time.
--
| Jun 5, 12:06 pm 2008 |
| Thomas Tuttle | [PATCH 1/5] pagemap: Modify add_to_pagemap to use copy_t ...
While fiddling with pagemap, I discovered a bug in add_to_pagemap.
When it is copying an entry that is not at the end of the buffer, it
uses put_user to copy a u64 into a char* buffer. The problem is that
put_user determines how much to copy based on the size of the
*destination*, not the source, so it only copied one byte. To fix
this, I replaced the call to put_user with a call to copy_to_user, as
is used when copying the last (possibly partial) PFN into the buffer.
| Jun 5, 8:04 am 2008 |
| Thomas Tuttle | Re: [PATCH 1/5] pagemap: Modify add_to_pagemap to use co ...
No, my 3/5 further keeps the use of copy_to_user instead of put_user,
but eliminates entirely the code for partial reads. 3/5 depends on
1/5.
--ttuttle
--
| Jun 5, 9:01 am 2008 |
| Thomas Tuttle | Re: [PATCH 1/5] pagemap: Modify add_to_pagemap to use co ...
Okay, I've written a new patchset. Patch 1/4 simply changes things to
use u64 pointers. It's not that big a patch, but if you're really
uncomfortable backporting it, just stick a (u64*) before pm->out in
2.6.25.x.
Other than that, I don't believe any of the other fixes need to be
backported. They just tweak a couple of things (error code on
unaligned reads, and which values show up in kpagecount), but don't
repair any particularly broken bits.
Please take a look at the new patchset and ...
| Jun 5, 12:09 pm 2008 |
| Matt Mackall | Re: [PATCH 1/5] pagemap: Modify add_to_pagemap to use co ...
This looks fine to me, so:
Acked-by: Matt Mackall <mpm@selenic.com>
But your 3/5 undoes this, right? So we should just take one or the other
route. While I like going the simplifying route, it's not very pretty
from the user interface point of view. But it does have plenty of
precedent in direct-I/O-like things.
--
Mathematics is the supreme nostalgia of our time.
--
| Jun 5, 8:57 am 2008 |
| Matt Mackall | Re: [PATCH 1/5] pagemap: Modify add_to_pagemap to use co ...
Hmm, I read this backwards the first time through then. Rather than
finding a small bug at the end of the buffer, you've found a REALLY BIG
WEAR-A-BROWN-PAPER-BAG-ON-MY-HEAD BUG.
Sigh. Some clever person (me?) probably removed a cast or changed a
pointer type somewhere along the way and didn't notice the fallout
because the MSBs still came through.
I'm pretty sure we want to do the put_user because it's faster. On a
64-bit system, it boils down to a simple assignment. If we ...
| Jun 5, 9:20 am 2008 |
| Haavard Skinnemoen | Re: AT32 ASoC Driver Patches on alsa-devel
Still, both plug into the same VFS layer...
Reiser4 tried to invent its own plugin system. IIRC that didn't fly
particularly well.
Haavard
--
| Jun 5, 10:06 am 2008 |
| Haavard Skinnemoen | Re: AT32 ASoC Driver Patches on alsa-devel
But if the low-level driver has to handle all that, what are all the
Well, I did try to implement it as an ALSA driver, but a) it didn't
work, b) it was impossible to debug, and c) it ended up at about 10x
the size of the OSS driver. So I figured it wasn't really worth the
Hmm...I take it you're talking about the SSC driver? That is supposed
to be usable on AT91 as well, so perhaps the right thing to do is
porting the AT91 driver over to use it.
I see you've added a few SSC-related ...
| Jun 5, 9:24 am 2008 |
| Haavard Skinnemoen | Re: AT32 ASoC Driver Patches on alsa-devel
Hmm. For something that depends on a metric shitload of middle layers,
it is surprisingly large...
I have to admit I don't understand the current sound situation at all.
With this driver, we now have:
* An OSS driver for the AP7000 Audio Bitstream DAC
* A "regular" ALSA driver for the AC97C (not based on ASoC)
* Two different "generic" AC97 layers: one in sound/pci/ac97 and one
in sound/soc/ac97 (the AC97C driver uses the former)
* An i2s driver for the AT73C213 chip using the ...
| Jun 5, 7:22 am 2008 |
| Mark Brown | Re: AT32 ASoC Driver Patches on alsa-devel
There is AC97 support in ASoC but there's no sound/soc/ac97? Briefly,
the generic ALSA AC97 support is focused on handling standard AC97 parts
without additional features while the ASoC layer requires more per-board
setup but supports codecs with large extensions to the AC97 standard
such as the additional of secondary I2S interfaces that can't readily be
accomodated in the vanilla AC97 driver.
For systems using only AC97 codecs with only small non-standard features
the vanilla AC97 driver ...
| Jun 5, 8:22 am 2008 |
| Geoffrey Wossum | Re: AT32 ASoC Driver Patches on alsa-devel
I quote that a lot. Along with Philip K. Dicks's "Sometimes an appropriate
Yes, the SSC code. It'd be cool if it abstracted out even more, but I
I wasn't sure if having these in atmel-ssc.h fit with ya'lls plans for it, but
The PDC interface is closer (if not exactly the same). One issue is the SSC
interface, which you have said could be used on the AT91. After that, the
main differences are that the DMA buffer has to be allocated differently, and
Please don't take my answer as ...
| Jun 5, 10:10 am 2008 |
| Takashi Iwai | Re: AT32 ASoC Driver Patches on alsa-devel
At Thu, 5 Jun 2008 18:24:09 +0200,
Mostly because of the difference of the target hardware design. From
the very beginning, ASoC is designed specifically for mobile devices
while ALSA is designed as a more generic abstraction.
Ideally, more fusion would be possible, but practically it's not
always worth. I don't think you want to merge codes between ext3 and
reiserfs although both have similar "design goals" :)
Takashi
--
| Jun 5, 9:54 am 2008 |
| Geoffrey Wossum | Re: AT32 ASoC Driver Patches on alsa-devel
Partly because the code attempts to handle every contingency an application
might throw at (different sample rates, formats, clocking options, etc.).
To paraphrase Andy Tanenbaum, the great thing about standards is there's so
Strongly coupled to the AT73C213, not the chip I'm using, although it did
provide a good example of working code. This is where I figured out I needed
This IS sort of confusing. It's really more of a generic SSC / PDC driver
than a "PCM layer". Its existence is ...
| Jun 5, 8:00 am 2008 |
| Haavard Skinnemoen | Re: AT32 ASoC Driver Patches on alsa-devel
Ok, but why write a whole new driver instead of extending the existing
Sounds like it could be solved by a thin adapter layer on top of a more
Again, that sounds very useful in general, not only for SoCs. Power
consumption is perhaps _more_ important on embedded systems than PCs,
but I very much doubt that anyone would complain if their laptop
The SSC hardware is essentially identical on the two platforms, and
there's also a common driver of sorts in drivers/misc/atmel-ssc.c. So
it ...
| Jun 5, 9:40 am 2008 |
| Umu Support Team | Account Update
Dear User,
We wrote to you on 28th April 2008 advising
that you
change the password on your account in
order to prevent any
unauthorised account access following the
network intrusion we
previously communicated.
we have found the vulnerability that caused
this issue,
and have instigated a system wide security
audit to improve and
enhance our current security, in order to
continue using our services
you are require to update you account
details below.
To complete your ...
| Jun 5, 5:14 am 2008 |
| Frans Pop | Re: ARM on qemu: running kernel 2.6.20 or newer?
The daily built armel versatile D-I images [1] worked fine for me in qemu
just a few days ago. They use 2.6.24. There's one issue [2] related to
serial console, but graphics mode works fine.
Cheers,
FJP
[1] http://wiki.debian.org/ArmEabiHowto
[2] http://bugs.debian.org/484366
--
| Jun 5, 7:44 am 2008 |
| Thomas Bleher | ARM on qemu: running kernel 2.6.20 or newer?
Is anyone testing ARM kernels on qemu?
I'm trying to run an ARM kernel on qemu (0.9.1-5) on a Debian AMD64
system. 2.6.19 worked fine, but all newer kernel releases[1] result in
qemu consuming 100% of the CPU without ever outputting anything to the
console.
I did a bisect, and the failing commit is
1c69d921ed9cc6593ad4f60c0f9951cb0d62b0b4 (v2.6.19-1675-g1c69d92)
[PATCH] rcu: add a prefetch() in rcu_do_batch()
but I have no idea what could make the boot fail there.
The kernel is ...
| Jun 5, 6:53 am 2008 |
| Manish Katiyar | [PATCH] : Fix unused variable 'loops' warning in arch/x8 ...
Following patch fixes the below warning message :
arch/x86/boot/a20.c:118: warning: unused variable 'loops'
=================================================
Signed-off-by : Manish Katiyar <mkatiyar@gmail.com>
diff --git a/arch/x86/boot/a20.c b/arch/x86/boot/a20.c
index 90943f8..d9f13bf 100644
--- a/arch/x86/boot/a20.c
+++ b/arch/x86/boot/a20.c
@@ -115,8 +115,6 @@ static void enable_a20_fast(void)
int enable_a20(void)
{
- int loops = A20_ENABLE_LOOPS;
-
#if ...
| Jun 5, 6:44 am 2008 |
| Martin Willi | Re: [PATCH 2.6.26rc5] xfrm: SHA-256/384/512 HMAC support ...
We could do that, but SADB_X_AALG_SHA2_256HMAC (5) actually refers to
128 bit truncation. 96 bit truncation is a leftover of
draft-ietf-ipsec-ciph-sha-256-00 and has been replaced by 128 bit
truncation in draft-ietf-ipsec-ciph-sha-256-01.
draft-kelly-ipsec-ciph-sha2 and the resulting RFC4868 define 128 bit
truncation for SADB_X_AALG_SHA2_256HMAC (5), so 96 bit truncation is
really obsolete. We could define a new PF_KEY algorithm for 96 bit
truncation, but it is not really usable as it is ...
| Jun 5, 7:45 am 2008 |
| Adrian-Ken Rüegsegger | Re: [PATCH 2.6.26rc5] xfrm: SHA-256/384/512 HMAC support ...
I agree that 96bit truncation is obsolete and 128 bit should be used.
However people might be using the current implementation and this patch
could cause trouble for them. The question is if anybody really depends
on the current behavior.
Adrian
--
| Jun 5, 7:58 am 2008 |
| Martin Willi | [PATCH 2.6.26rc5] xfrm: SHA-256/384/512 HMAC support for IPsec
RFC4868 defines the use of SHA256, SHA384 and SHA512 in HMAC using 128,
192 and 256 bits truncation. This patch replaces the outdated SHA256
algorithm with 96 bits truncation by the 128 bit variant and adds the
SHA384/512 algorithms.
Signed-off-by: Martin Willi <martin@strongswan.org>
---
Replacing the 96 bit truncation SHA256 algorithm might be problematic,
but it is obsolete in IPsec and I don't see a way to register two
different truncation lengths in XFRM.
--- a/net/xfrm/xfrm_algo.c ...
| Jun 5, 6:06 am 2008 |
| Adrian-Ken Rüegsegger | Re: [PATCH 2.6.26rc5] xfrm: SHA-256/384/512 HMAC support ...
You could register a new SADB algorithm id in pfkeyv2.h and add a new
entry to the aalg_list analogous to how GCM is doing that in the aead_list.
--
| Jun 5, 7:07 am 2008 |
| ciaby | about 2.6.25.4-rt5 (missing
Small patch to make it compile (missing global_rt_runtime function):
diff -uNr linux-2.6.25.4.orig/kernel/sched.c linux-2.6.25.4/kernel/sched.c
--- linux-2.6.25.4.orig/kernel/sched.c 2008-06-05 14:12:30.000000000 +0200
+++ linux-2.6.25.4/kernel/sched.c 2008-06-05 13:58:48.000000000 +0200
@@ -671,6 +671,15 @@
*/
#define RUNTIME_INF ((u64)~0ULL)
+static u64 global_rt_runtime(void)
+{
+ if (sysctl_sched_rt_period < 0)
+ return RUNTIME_INF;
+ return ...
| Jun 5, 5:18 am 2008 |
| Vitaly Mayatskikh | different conditions in arch_get_unmapped_area_topdown
Hi!
Here's do-while loop from generic arch_get_unmapped_area_topdown() from mm/mmap.c:
do {
/*
* Lookup failure means no vma is above this address,
* else if new region fits below vma->vm_start,
* return with success:
*/
vma = find_vma(mm, addr);
if (!vma || addr+len <= vma->vm_start)
/* remember the address as a hint for next time */
...
| Jun 5, 5:43 am 2008 |
| Jan Kara | [PATCH 0/2] New split of quota headers
Hello Andrew,
after Adrian's comments and a bit of thinking, I've decided to split
quota headers differently which also solves the issue with new header file
which should be exported. I found out it is enough to move some functions
into quotaops.h where they logically also fit nicely. So please replace
my patches:
+ ext4-add-explicit-include-of-linux-quotah-into-ext4_jbd2h.patch
+ ext2-add-explicit-include-of-linux-quotah-into-superc.patch
+ ...
| Jun 5, 5:42 am 2008 |
| Jan Kara | Re: [PATCH 2/2] quota: Convert macros to inline functions
Signed-off-by: Jan Kara <jack@suse.cz>
---
include/linux/quota.h | 5 +++-
include/linux/quotaops.h | 65 +++++++++++++++++++++++++++++++++++----------
2 files changed, 54 insertions(+), 16 deletions(-)
diff --git a/include/linux/quota.h b/include/linux/quota.h
index f9983ea..4e004fe 100644
--- a/include/linux/quota.h
+++ b/include/linux/quota.h
@@ -223,7 +223,10 @@ struct super_block;
#define DQF_INFO_DIRTY (1 << DQF_INFO_DIRTY_B) /* Is info dirty? */
extern void ...
| Jun 5, 5:49 am 2008 |
| Jan Kara | [PATCH 1/2] quota: Move function-macros from quota.h to ...
Move declarations of some macros, which should be in fact functions
to quotaops.h. This way they can be later converted to inline functions
because we can now use declarations from quota.h. Also add necessary
includes of quotaops.h to a few files.
Signed-off-by: Jan Kara <jack@suse.cz>
---
fs/ext2/super.c | 1 +
fs/quota_v1.c | 1 +
fs/quota_v2.c | 1 +
include/linux/quota.h | 22 +++-------------------
include/linux/quotaops.h | 25 ...
| Jun 5, 5:48 am 2008 |
| S.Çağlar | [hpwdt] BUG: unable to handle kernel paging request
Hi;
One of our buildfarm servers (HP Proliant DL380g5) gaves following BUG output
and fails to boot while trying to "modprobe hpwdt" module with 2.6.25.4 +
current stable-queue patchset + and some distro specific patches (but none of
the patches touches drivers/watchdog/hpwdt.c)
[...]
hpwdt: New timer passed in is 30 seconds.
BUG: unable to handle kernel paging request at 003ac122
IP: [<c0100009>]
*pde = 00000000·
Oops: 0000 [#1] SMP·
Modules linked in: bnx2(+) joydev ipmi_si(+) ...
| Jun 5, 5:37 am 2008 |
| Mingarelli, Thomas | RE: [hpwdt] BUG: unable to handle kernel paging request
Please turn off the kernel's nmi watchdog by placing nmi_watchdog=0 in your menu.lst file. Let me know if this solves your problem.
Tom
-----Original Message-----
From: S.Çağlar Onur [mailto:caglar@pardus.org.tr]
Sent: Thursday, June 05, 2008 7:37 AM
To: wim@iguana.be
Cc: Mingarelli, Thomas; linux-kernel@vger.kernel.org
Subject: [hpwdt] BUG: unable to handle kernel paging request
Hi;
One of our buildfarm servers (HP Proliant DL380g5) gaves following BUG output
and fails to boot while ...
| Jun 5, 9:03 am 2008 |
| Alan D. Brunelle | [PATCH] Added in user-injected messages into blk traces
[Empty message]
| Jun 5, 5:21 am 2008 |
| Denys Fedoryshchenko | strange timestamp in dmesg
I notice that timestamp shifting back in dmesg.
Probably it is because machine is dual CPU opteron. I am not sure that such
behaviour is good, and i think even dangerous, and maybe affect something else.
Here is dmesg example
[ 7.065265] sky2 eth1: enabling interface
[ 7.093844] nf_conntrack version 0.5.0 (16384 buckets, 65536 max)
[ 8.308842] Fusion MPT base driver 3.04.06
[ 8.308850] Copyright (c) 1999-2007 LSI Corporation
[ 7.719943] Fusion MPT SAS Host driver 3.04.06
[ ...
| Jun 5, 4:54 am 2008 |
| David Woodhouse | Re: [PATCH] firmware: convert Ambassador ATM driver to r ...
For now, I'm keen to keep the firmware within the kernel, in the
firmware/ directory where it can be included directly with no
'regressions'. I don't want the potential debate about firmware being in
the kernel tree to get in the way of the real cleanups -- so if it's OK
with you, I'll apply your patch and also move the firmware into the
firmware/ directory?
--
dwmw2
--
| Jun 5, 11:13 am 2008 |
| Chas Williams (CONTR ... | Re: [PATCH] firmware: convert Ambassador ATM driver to r ...
In message <1212689632.32207.283.camel@pmac.infradead.org>,David Woodhouse writ
it would need to be converted to the binary form first, or the patch
will need to rewritten to use the s-record format.
--
| Jun 5, 11:20 am 2008 |
| Chas Williams (CONTR ... | Re: [PATCH] firmware: convert Ambassador ATM driver to r ...
In message <1212667633.32207.205.camel@pmac.infradead.org>,David Woodhouse writ
yes, it is troubling. along the same lines, this patch removes the
pca200e/sba200e firmware from the kernel. the firmware will be in the
next release of the userspace atm tools. i could move the ambassador
firmware there as well if you would like.
commit 7c3f98c136041deb6b9c02bed4481860b1e515d1
Author: Chas Williams - CONTRACTOR <chas@relax.cmf.nrl.navy.mil>
Date: Thu Jun 5 12:01:03 2008 -0400
atm: ...
| Jun 5, 9:06 am 2008 |
| David Woodhouse | Re: [PATCH] firmware: convert Ambassador ATM driver to r ...
We can do binary form. We just run it through objcopy -Ibinary -Oihex
for convenience of handling it (and that's different to the ones we
actually hand to the kernel in the form of records).
--
dwmw2
--
| Jun 5, 11:28 am 2008 |
| David Woodhouse | [PATCH] firmware: convert Ambassador ATM driver to reque ...
Since it had various regions to be loaded to separate addresses, and it
wanted to do them in fairly small chunks anyway, switch it to use the
new ihex code. Encode the start address in the first record.
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
---
Not entirely sure how we can claim that the firmware is under GPL
without providing its source in the preferred form for modification --
but transplanted the copyright blurb to the HEX file unmolested,
nonetheless.
drivers/atm/Kconfig ...
| Jun 5, 5:07 am 2008 |
| Andreas Herrmann | Re: [PATCH] x86: fix compile warning in io_apic_{32,64}.c
Sure. It's currently dead code. I use it from time to time for debugging.
At least you have to do something like
diff --git a/arch/x86/kernel/io_apic_64.c b/arch/x86/kernel/io_apic_64.c
index ef1a8df..ddfdabd 100644
--- a/arch/x86/kernel/io_apic_64.c
+++ b/arch/x86/kernel/io_apic_64.c
@@ -1045,7 +1045,6 @@ void __apicdebuginit print_IO_APIC(void)
return;
}
-#if 0
static __apicdebuginit void print_APIC_bitfield (int base)
{
@@ -1181,7 +1180,6 @@ void __apicdebuginit ...
| Jun 5, 7:35 am 2008 |
| Andreas Herrmann | [PATCH] x86: fix compile warning in io_apic_{32,64}.c
Commit 05f2d12c3563dea8c81b301f9f3cf7919af23b13
(x86: change GET_APIC_ID() from an inline function to an out-of-line function)
introduced a compile warning
arch/x86/kernel/io_apic_64.c: In function 'print_local_APIC':
arch/x86/kernel/io_apic_64.c:1152: warning: 'v' is used uninitialized in this function
in some debug code -- which is not enabled by default.
This patch reverts the code changes in print_local_APIC.
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
--
diff ...
| Jun 5, 5:05 am 2008 |
| Jack Steiner | Re: [PATCH] x86: fix compile warning in io_apic_{32,64}.c
I don't think this work on UV systems. Because of processor limitations, not
all of the APICID bits are contained in the hardware APIC_ID register. See
read_apic_id() in arch/x86/kernel/genapic_64.c.
--- jack
--
| Jun 5, 5:39 am 2008 |
| Andrej Hocevar | PROBLEM with kernel
I got this right after resuming from hibernation. Unfortunatelly, I
don't have the kernel-sources anymore as I've actually upgraded to
2.6.25.4.
Buffer I/O error on device sda1, logical block 0
lost page write due to I/O error on sda1
scsi 1:0:0:0: Direct-Access WD 5000AAKS Externa 106a PQ: 0
ANSI: 4
sd 1:0:0:0: [sdb] 976773168 512-byte hardware sectors (500108 MB)
sd 1:0:0:0: [sdb] Write Protect is off
sd 1:0:0:0: [sdb] Mode Sense: 11 00 00 00
sd 1:0:0:0: [sdb] Assuming drive ...
| Jun 5, 4:23 am 2008 |
| Richard Kennedy | [PATCH] Net: reorder udp_iter_state to remove padding on ...
reorder udp_iter_state to remove padding on 64bit builds
shrinks from 24 to 16 bytes, moving to a smaller slab when CONFIG_NET_NS
is undefined & seq_net_private = {}
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
---
static analysis found this padding in udp_iter_state.
I've boot tested 2.6.26-rc4 + patch on desktop AMD64, and successfully
run a simple UDP test case.
Richard
diff --git a/include/net/udp.h b/include/net/udp.h
index ccce837..7a86848 100644
--- ...
| Jun 5, 3:33 am 2008 |
| Nick Piggin | [rfc][patch] mm: vmap rewrite
Hi. RFC.
Rewrite the vmap allocator to use rbtrees and lazy tlb flushing, and provide a
fast, scalable percpu frontend for small vmaps.
XEN and PAT and such do not like deferred TLB flushing. They just need to call
vm_unmap_aliases() in order to flush any deferred mappings. That call is very
expensive (well, actually not a lot more expensive than a single vunmap under
the old scheme), however it should be OK if not called too often.
The existing vmalloc API is implemented on top of the ...
| Jun 5, 3:20 am 2008 |
| Ingo Molnar | Re: RFC [PATCH] x86: make generic arch support NUMAQ
Yinghai, please get rid of the NUMAQ build option altogether and
eliminate the subarch.
We should keep a compatibility CONFIG_X86_NUMAQ that selects
X86_GENERICARCH, so that 'make oldconfig' on a NUMAQ config does the
right thing - but it's not a subarch anymore nor anything
user-configurable.
All that together would be a very nice simplification.
Ingo
--
| Jun 5, 5:39 am 2008 |
| Yinghai Lu | RFC [PATCH] x86: make generic arch support NUMAQ
so it could fallback to normal numa.
also decouple genericarch numa with acpi.
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 3105e40..ef48cb9 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -310,12 +310,12 @@ config X86_VISWS
and vice versa. See <file:Documentation/sgi-visws.txt> for details.
config X86_GENERICARCH
- bool "Generic architecture (Summit, bigsmp, ES7000, default)"
+ bool "Generic ...
| Jun 5, 3:09 am 2008 |
| Yinghai Lu | Re: RFC [PATCH] x86: make generic arch support NUMAQ
how about the Summit, and ES7000? You still have the two entries for them.
Anyway, will remove entry in the list and make CONFIG_X86_NUMAQ select
X86_GENERICARCH
and make the those ifdef only use X86_GENERICARCH...
YH
--
| Jun 5, 10:33 am 2008 |
| Sam Ravnborg | Re: RFC [PATCH] x86: make generic arch support NUMAQ
Hi Yinghai Lu.
Some random comments after skimming through the diff.
In general I like the simplification moving numaq.
But there is too much ifdef going on - and it
can be done better.
Part of this may belong in a followup patch - other parts
I counted several places where you test for the above.
Can we move these dependencies to Kconfig?
It should looks roughtly like this in the Makefile:
obj-$(CONFIG_X86_NUMAQ) += numaq_32.o
This ifdef should be found in a .h file ...
| Jun 5, 4:00 am 2008 |
| Yinghai Lu | Re: RFC [PATCH] x86: make generic arch support NUMAQ
Thanks, will check it.
YH
--
| Jun 5, 10:26 am 2008 |
| npiggin | [patch 3/7] mm: speculative page references
If we can be sure that elevating the page_count on a pagecache page will pin
it, we can speculatively run this operation, and subsequently check to see if
we hit the right page rather than relying on holding a lock or otherwise
pinning a reference to the page.
This can be done if get_page/put_page behaves consistently throughout the whole
tree (ie. if we "get" the page after it has been used for something else, we
must be able to free it with a put_page).
Actually, there is a period where the ...
| Jun 5, 2:43 am 2008 |
| npiggin | [patch 7/7] powerpc: lockless get_user_pages_fast
Implement lockless get_user_pages_fast for powerpc. Page table existence is
guaranteed with RCU, and speculative page references are used to take a
reference to the pages without having a prior existence guarantee on them.
Signed-off-by: Nick Piggin <npiggin@suse.de>
---
Index: linux-2.6/include/asm-powerpc/uaccess.h
===================================================================
--- linux-2.6.orig/include/asm-powerpc/uaccess.h
+++ linux-2.6/include/asm-powerpc/uaccess.h
@@ -493,6 +493,12 ...
| Jun 5, 2:43 am 2008 |
| npiggin | [patch 2/7] radix-tree: add gang_lookup_slot, gang_looku ...
[Empty message]
| Jun 5, 2:43 am 2008 |
| npiggin | [patch 1/7] mm: readahead scan lockless
radix_tree_next_hole is implemented as a series of radix_tree_lookup()s. So
it can be called locklessly, under rcu_read_lock().
Signed-off-by: Nick Piggin <npiggin@suse.de>
---
Index: linux-2.6/mm/readahead.c
===================================================================
--- linux-2.6.orig/mm/readahead.c
+++ linux-2.6/mm/readahead.c
@@ -382,9 +382,9 @@ ondemand_readahead(struct address_space
if (hit_readahead_marker) {
pgoff_t start;
...
| Jun 5, 2:43 am 2008 |
| npiggin | [patch 5/7] mm: spinlock tree_lock
[Empty message]
| Jun 5, 2:43 am 2008 |
| npiggin | [patch 6/7] powerpc: implement pte_special
Implement PTE_SPECIAL for powerpc. At the moment I only have a spare bit for
the 4k pages config, but Ben has freed up another one for 64k pages that I
can use, so this patch should include that before it goes upstream.
Signed-off-by: Nick Piggin <npiggin@suse.de>
---
Index: linux-2.6/include/asm-powerpc/pgtable-ppc64.h
===================================================================
--- linux-2.6.orig/include/asm-powerpc/pgtable-ppc64.h
+++ linux-2.6/include/asm-powerpc/pgtable-ppc64.h
@@ ...
| Jun 5, 2:43 am 2008 |
| Linus Torvalds | Re: [patch 0/7] speculative page references, lockless pa ...
So I'd certainly like to see these early in the 2.6.27 series.
Nick, will you just re-send them once 2.6.26 is out? Or do they cause
problems for Andrew and he wants to be part of the chain? I'm fine with
either.
Linus
--
| Jun 5, 10:33 am 2008 |
| npiggin | [patch 0/7] speculative page references, lockless pageca ...
Hi,
I've decided to submit the speculative page references patch to get merged.
I think I've now got enough reasons to get it merged. Well... I always
thought I did, I just didn't think anyone else thought I did. If you know
what I mean.
cc'ing the powerpc guys specifically because everyone else who probably
cares should be on linux-mm...
So speculative page references are required to support lockless pagecache and
lockless get_user_pages (on architectures that can't use the x86 trick). ...
| Jun 5, 2:43 am 2008 |
| Nick Piggin | Re: [patch 0/7] speculative page references, lockless pa ...
Oh that's actually anothr thing I remember now that I posted the scalable
vmap code...
The lock I ended up hitting next in the XFS large directory workload that
improved so much with the vmap patches was tree_lock of the buffer cache.
So lockless pagecache gave a reasonable improvement there too IIRC :)
--
| Jun 5, 4:53 am 2008 |
| npiggin | [patch 4/7] mm: lockless pagecache
Combine page_cache_get_speculative with lockless radix tree lookups to
introduce lockless page cache lookups (ie. no mapping->tree_lock on
the read-side).
The only atomicity changes this introduces is that the gang pagecache
lookup functions now behave as if they are implemented with multiple
find_get_page calls, rather than operating on a snapshot of the pages.
In practice, this atomicity guarantee is not used anyway, and it is
difficult to see how it could be. Gang pagecache lookups are ...
| Jun 5, 2:43 am 2008 |
| Jeff Garzik | Re: [PATCH 00/18] firmware: moving drivers to request_fi ...
Well, I should ask, is this purely an internal build detail?
The developer (and user) should never ever see a .ihex file, outside of
an active kernel compile. Wrapping the original firmware makes it more
difficult to verify, compare and/or change. In-tree, we should see the
vendor firmware blobs as shipped, with no wrapping or modification or
anything.
Any metadata can be added as a separate file.
If .ihex is purely a temporary thing during compile, no big deal, ignore
me. ...
| Jun 5, 1:12 pm 2008 |
| David Woodhouse | Re: [PATCH 00/18] firmware: moving drivers to request_fi ...
It's just 'objcopy -Ibinary -Oihex foo foo.ihex'. It's purely for
convenience of handling the binary blobs in git (and it means we can
append licensing information after the EOF record too, if we want).
--
dwmw2
--
| Jun 5, 12:54 pm 2008 |
| Clemens Ladisch | Re: [PATCH 00/18] firmware: moving drivers to request_fi ...
I have an emi26/emi62 patch that I need to clean up a little ...
Regards,
Clemens
--
| Jun 5, 5:26 am 2008 |
| David Woodhouse | Re: [PATCH 00/18] firmware: moving drivers to request_fi ...
We've had that for a long time: MODULE_FIRMWARE().
--
dwmw2
--
| Jun 5, 3:09 am 2008 |
| Jeff Garzik | Re: [PATCH 00/18] firmware: moving drivers to request_fi ...
IMO, if-and-only-if you are touching driver firmwares, you should not do
anything but render them into their preferred form.
It is useless churn that increases maintenance annoyances to convert an
in-tree firmware to something other than the form it's in now, so you
might as well get it right.
Jeff
--
| Jun 5, 3:39 pm 2008 |
| Clemens Ladisch | Re: [PATCH 10/18] ihex.h: binary representation of ihex ...
At least in the case of EZ-USB-based devices, this is not a requirement.
It seems most tools just do not bother to order the records in Intel hex
files. Any firmware that is downloaded with the EZ-USB's "load
internal" request (0xa0) can be converted to a plain memory dump.
Regards,
Clemens
--
| Jun 5, 5:26 am 2008 |
| Jeff Garzik | Re: [PATCH 00/18] firmware: moving drivers to request_fi ...
Right. And now you are creating Yet Another Format, rather than
rendering the firmware back into the preferred format: binary blob.
_If_ you are changing form of current in-tree firmwares at all, there is
no excuse not use direct binary blob -- the least common denominator for
all relevant operations.
Storing the firmware in .ihex is just as bad as storing the firmware in
source code -- it's a pointless wrapper that makes firmware verification
and updates far more difficult than they ...
| Jun 5, 2:33 pm 2008 |
| Arkadiusz Miskiewicz | Re: [PATCH 00/18] firmware: moving drivers to request_fi ...
Will there be a way for userspace to know what firmware file is needed by
which driver?
So for example geninitrd/mkinitrd will be able to put only required firmware
files into initrd/initramfs (without a need to maintain separate database
with driver <-> firmware file name mapping).
--
Arkadiusz Miśkiewicz PLD/Linux Team
arekm / maven.pl http://ftp.pld-linux.org/
--
| Jun 5, 3:07 am 2008 |
| Jeff Garzik | Re: [PATCH 00/18] firmware: moving drivers to request_fi ...
If the sha1 sum of what is in the kernel tree differs from what the
vendor provided, then it is OBVIOUSLY more difficult to verify that you
have the original firmware as provided by the vendor.
Put the binary blobs into the git tree, __without modification or
wrapping__.
Jeff
--
| Jun 5, 2:01 pm 2008 |
| David Woodhouse | [PATCH 00/18] firmware: moving drivers to request_firmware()
Ignoring the set of 'make fw->data const' patches which have mostly
been already posted and are fairly trivial, this is the current content
of the firmware tree at git.infradead.org/users/dwmw2/firmware-2.6.git
It starts by giving a way to build arbitrary firmware blobs into the
kernel while letting request_firmware() find them there, and then sets
about converting drivers to use request_firmware() instead of static
data blobs, now that we can do that without forcing the users to
actually ...
| Jun 5, 2:52 am 2008 |
| David Woodhouse | Re: [PATCH 00/18] firmware: moving drivers to request_fi ...
It's a build-and-shipping detail, at least in the kernel source tree.
Rather than putting binary blobs into git (which admittedly we could,
but it's suboptimal), we just run them through 'objcopy -Oihex' first.
It's not 'wrapped'; it's not any more difficult to verify, compare or
change.
--
dwmw2
--
| Jun 5, 1:53 pm 2008 |
| Jeff Garzik | Re: [PATCH 00/18] firmware: moving drivers to request_fi ...
Here is my "ideal firmware world":
* do NOT remove ability to compile firmware into the kernel (or into a
module)
* firmware should be field-replaceable, even if one was compiled in
* the preferred form of firmware is one or more binary blobs, stored in
a regular [filesystem|git] binary file.
* the preferred form is NOT ascii C source, or any other format other
than the native format that the hardware wants. Remember, the vendor
only provided an ASCII-ized firmware because our ...
| Jun 5, 3:11 pm 2008 |
| Jeff Garzik | Re: [PATCH 00/18] firmware: moving drivers to request_fi ...
Why do we need the .ihex format?
We should be loading firmwares exactly as they come from the vendor,
without any wrappers.
Jeff
--
| Jun 5, 12:16 pm 2008 |
| Daniel Exner | linux-next Regression: Unable to locate IOAPIC
Hi!
(Added myself to CC, because I'm not subscribed)
with linux-next snapshot 20080604 my Laptop morphes into sitting duck and I
think this is due to this:
dmesg | grep "GSI 11"
ACPI: PCI Interrupt 0000:00:11.0[A] -> Link [LNKA] -> GSI 11 (level, low) ->
IRQ 11
ERROR: Unable to locate IOAPIC for GSI 11
ACPI: PCI Interrupt 0000:00:11.1[B] -> Link [LNKB] -> GSI 11 (level, low) ->
IRQ 11
ERROR: Unable to locate IOAPIC for GSI 11
ACPI: PCI Interrupt 0000:00:02.0[A] -> Link [LNKG] -> GSI ...
| Jun 5, 2:00 am 2008 |
| Pavel Emelyanov | [PATCH 2/2] devscgroup: make white list more compact in ...
Consider you added a 'c foo:bar r' permission to some cgroup and then
(a bit later) 'c'foo:bar w' for it. After this you'll see a
c foo:bar r
c foo:bar w
lines in a devices.list file.
Another example - consider you added 10 'c foo:bar r' permissions to
some cgroup (e.g. by mistake). After this you'll see 10
c foo:bar r
lines in a list file.
This is weird. This situation also has one more annoying consequence.
Having many items in a white list makes permissions checking slower,
sine it ...
| Jun 5, 1:45 am 2008 |
| Serge E. Hallyn | Re: [PATCH 2/2] devscgroup: make white list more compact ...
But a private email response preferred the each-entry-is-separate
semantics, so I retract that suggestion.
-serge
--
| Jun 5, 12:16 pm 2008 |
| Serge E. Hallyn | Re: [PATCH 2/2] devscgroup: make white list more compact ...
Acked-by: Serge Hallyn <serue@us.ibm.com>
Thanks. I suppose if it was deemed worth it, the other thing you could
do would be to detect when you have a rule
c foo:bar r
and you add a rule
c foo:(all) r
--
| Jun 5, 7:23 am 2008 |
| Jan Beulich | Re: operation ordering during pgd_alloc/pgd_free
It could be made so, but it doesn't at present - it exits the inner loop
when vmalloc_sync_one() returns NULL. The intention here is that if
the reference page table has a clear entry at some level, then there
shouldn't be any attempt to look at other page tables' entries mapping
the same va (and because it would be an error if page table other than
the reference one had a clear entry where the reference one didn't,
there was that BUG_ON() that your patch removed). Since the purpose
of ...
| Jun 5, 2:58 am 2008 |
| Jeremy Fitzhardinge | Re: operation ordering during pgd_alloc/pgd_free
Yes, I specifically wanted to make sure that the pgd was on the list
from before it had any entries until after it has any, to make sure that
no pmds escape visibility from xen_mm_pin_all(). (Note to self: put a
memory barrier to make sure the list update is complete before/after
I don't think so. When saving with preemption enabled, it first puts
all processes in the freezer before entering stop_machine_run(); a
process constructing a pagetable should be finished by the time it can ...
| Jun 5, 2:27 am 2008 |
| Jan Beulich | operation ordering during pgd_alloc/pgd_free
At present, pgd_ctor() adds a new pgd to pgd_list solely based on
!SHARED_KERNEL_PMD. For PAE && !SHARED_KERNEL_PMD (i.e. Xen)
this doesn't seem correct, as the pgd is still empty, which will confuse
vmalloc_sync_all(). So in this case, list insertion should only happen at
the end of pgd_prepopulate_pmd().
Likewise, pgd_free() calls pgd_mop_up_pmds() *before* pgd_dtor(),
with the former zeroing pgd entries as it goes and only the latter
removing the pgd from the list. Just as above this can ...
| Jun 5, 1:51 am 2008 |
| Eric Miao | RE: [PATCH] spi: fix list scan success verification in P ...
QWNrZWQtYnk6IEVyaWMgTWlhbyA8ZXJpYy5taWFvQG1hcnZlbGwuY29tPg0KDQpBbmQgdGhpcyBz
aG91bGQgcmVhbGx5IGdvIHRocm91Z2ggdGhlIEFSTSB0cmVlLCBwbGVhc2Ugc3VibWl0IHRoZSBw
YXRjaA0KdG8gUk1LJ3MgcGF0Y2ggc3lzdGVtLiBUaGFua3MuDQoNCkNoZWVycw0KLSBlcmljDQoN
Cj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogR3Vlbm5hZGkgTGlha2hvdmV0
c2tpIFttYWlsdG86Zy5saWFraG92ZXRza2lAcGVuZ3V0cm9uaXguZGVdDQo+IFNlbnQ6IFRodXJz
ZGF5LCBKdW5lIDA1LCAyMDA4IDQ6MzcgUE0NCj4gVG86IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5l
bC5vcmcNCj4gQ2M6IGRicm93bmVsbEB1c2Vycy5z ...
| Jun 5, 1:45 am 2008 |
| Pavel Emelyanov | [PATCH 1/2] devscgroup: check for device permissions at ...
Currently even if a task sits in an all-denied cgroup it can still
mount any block device in any mode it wants.
Put a proper check in do_open for block device to prevent this.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
fs/block_dev.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/fs/block_dev.c b/fs/block_dev.c
index a0e9596..7e1c7a3 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -24,6 +24,7 @@
#include <linux/namei.h>
#include ...
| Jun 5, 1:40 am 2008 |
| Serge E. Hallyn | Re: [PATCH 1/2] devscgroup: check for device permissions ...
Crud. Tested and confirmed, and this patches fixes it.
Acked-by: Serge Hallyn <serue@us.ibm.com>
Tested-by: Serge Hallyn <serue@us.ibm.com>
thanks,
--
| Jun 5, 8:49 am 2008 |
| Guennadi Liakhovetski | [PATCH] spi: fix list scan success verification in PXA s ...
The list search success check in arch/arm/mach-pxa/ssp.c is wrong: for
example, it didn't recognise failure for me when I requested port 0.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@pengutronix.de>
---
arch/arm/mach-pxa/ssp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/arch/arm/mach-pxa/ssp.c
===================================================================
--- linux-2.6.orig/arch/arm/mach-pxa/ssp.c 2008-06-04 12:11:26.000000000 +0200
+++ ...
| Jun 5, 1:37 am 2008 |
| eric miao | Re: [PATCH] spi: fix list scan success verification in P ...
Acked-by: Eric Miao <eric.miao@marvell.com>
And this should really go through the ARM tree, please submit the
patch to RMK's patch system. Thanks.
(I have to send this again through my gmail account, please ignore the
other copy if any,
sorry for this)
On Thu, Jun 5, 2008 at 4:37 PM, Guennadi Liakhovetski
--
Cheers
- eric
--
| Jun 5, 1:54 am 2008 |
| Johannes Weiner | Re: [PATCH -mm 11/14] bootmem: respect goal more likely
Hi,
Thank you very much. I think I spotted the bug and will provide an
explanation and a patch when I am awake again.
Hannes
--
| Jun 5, 1:22 am 2008 |
| Stephen Rothwell | linux-next: Tree for June 5
Hi all,
Changes since next-20080604:
The hid tree fixed the conflicts with Linus' tree.
The v4l-dvb tree no longer needed the fixup patch.
The galak tree gained a conflict with the net tree.
The wireless tree now has the same conflict (in the ps3_gelic driver) as
the semaphore-removal tree.
The rr tree gained a conflict with the net-current tree.
The ldp tree suffered from the v4l-dvb struct members renaming.
I have applied the following temporary patch for known build ...
| Jun 5, 12:52 am 2008 |
| c4p7n1 | [BUG or cosmic ray] WARNING: at net/sched/sch_generic.c: ...
I've got this on rc3. It's _not_ reproducible even on heavy load.
After that the Ethernet PCIe chip went into a borken state until next reboot.
[ 46.316926] r8169: eth0: link up
[ 48.901435] [drm] Initialized drm 1.1.0 20060810
[ 48.904771] PCI: Setting latency timer of device 0000:00:02.0 to 64
[ 48.908103] [drm] Initialized i915 1.6.0 20060119 on minor 0
[ 49.544674] NET: Registered protocol family 17
[ 125.004020] NETDEV WATCHDOG: eth0: transmit timed out
[ 125.004043] ...
| Jun 5, 12:27 am 2008 |
| Adrian Hunter | Re: [PATCH 4/4] [MTD] nandsim: add option to use a file ...
Ok. Patch follows:
Add a new optional module parameter 'cache_file' which causes
nandsim to use that file instead of memory to cache nand data.
Using a file allows the simulation of NAND that is bigger
than the available memory.
Signed-off-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
---
drivers/mtd/nand/nandsim.c | 214 +++++++++++++++++++++++++++++++++++++++-----
1 files changed, 190 insertions(+), 24 deletions(-)
diff --git a/drivers/mtd/nand/nandsim.c ...
| Jun 5, 12:28 am 2008 |
| Sitsofe Wheeler | Re: BUG: unable to handle kernel NULL pointer dereferenc ...
Hello,
The warning is:
[ 42.949862] ------------[ cut here ]------------
[ 42.949873] WARNING: at kernel/lockdep.c:2680 check_flags+0x8a/0x12d()
[ 42.949880] Modules linked in:
[ 42.949887] Pid: 5, comm: watchdog/0 Not tainted 2.6.26-rc4-next-20080604skw #178
[ 42.949898] [<c01226f0>] warn_on_slowpath+0x41/0x6a
[ 42.949917] [<c013c584>] ? trace_hardirqs_off+0xb/0xd
[ 42.949935] [<c013e3b4>] ? trace_hardirqs_on+0xb/0xd
[ 42.951740] [<c013e36d>] ? ...
| Jun 5, 12:08 am 2008 |
| Stéphane Charette | linux kernel debugging
Back in the 2.2.13 kernel days, I would hook up 2 computers via serial
ports and could use ddd/gdb to walk through the kernel on the 2nd
computer.
My old notes tells me I would enabled "Kernel Hacking -> Kernel
support for GDB" when running "make menuconfig", and then add "gdb
gdbttyS=1 gdbbaud=115200" when booting the 2nd computer.
Is this still the way to do it?
I'd like to play around with this again after many years of not having
looked at the kernel internals. One of the things I ...
| Jun 4, 11:21 pm 2008 |
| Paul Menage | Re: [PATCH] cgroup: anotate two variables with __read_mostly
Acked-by: Paul Menage <menage@google.com>
Thanks.
--
| Jun 4, 11:35 pm 2008 |
| Li Zefan | [PATCH] cgroup: anotate two variables with __read_mostly
- need_forkexit_callback will be read only after system boot.
- use_task_css_set_links will be read only after it's set.
And these 2 variables are checked when a new process is forked.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
kernel/cgroup.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 15ac0e1..f5a1273 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -118,7 +118,7 @@ static int root_count;
* extra ...
| Jun 4, 11:02 pm 2008 |
| Paul Menage | Re: [RFC][PATCH] introduce task cgroup (#task restrictio ...
Hi Kosaki,
The basic idea of a task-limiting subsystem is good, thanks.
On Wed, Jun 4, 2008 at 9:43 PM, KOSAKI Motohiro
I don't think this is the right way to handle this check. This isn't a
generic control groups callback, it's one that specific for a
particular subsystem. So the right way to handle it is to call
task_cgroup_can_fork() from the same place that the RLIM_NPROC limit
is checked.
If it later turned out that multiple cgroup subsystems wanted to be
able to prevent forking, ...
| Jun 5, 3:04 pm 2008 |
| KOSAKI Motohiro | Re: [RFC][PATCH] introduce task cgroup (#task restrictio ...
Hi Nishimura-san,
your are right.
Yes, of cource.
I'll fix it.
Thanks!
--
| Jun 5, 3:56 am 2008 |
| Daniel Hokka Zakrisson | Re: [RFC][PATCH] introduce task cgroup (#task restrictio ...
Would it make more sense to implement this as part of an rlimit subsystem,
which also supports limiting e.g. address space, CPU time, number of open
files, etc.? If we create one subsystem per resource, I'm afraid we're
going to see quite some time spent in all those loops, and the options for
cgroupfs is going to become pretty long if you want to exclude just one or
two of the subsystems for one particular mount point.
--
Daniel Hokka Zakrisson
--
| Jun 5, 2:52 pm 2008 |
| KAMEZAWA Hiroyuki | Re: [RFC][PATCH] introduce task cgroup (#task restrictio ...
On Thu, 05 Jun 2008 13:43:06 +0900
This will cause dead lock.
And it seems this doesn't handle "attach failure".
It will be helpful Documentation somewhere.
Thanks,
-Kame
--
| Jun 4, 10:13 pm 2008 |
| Daisuke Nishimura | Re: [RFC][PATCH] introduce task cgroup (#task restrictio ...
Hi.
I think this would be usefull.
I don't think it's needed.
need spin_unlock().
Thanks,
Daisuke Nishimura.
--
| Jun 4, 10:23 pm 2008 |
| KOSAKI Motohiro | Re: [RFC][PATCH] introduce task cgroup (#task restrictio ...
Oh, nice point out.
good idea :)
I'll fix it at next post.
--
| Jun 5, 3:53 am 2008 |
| KOSAKI Motohiro | Re: [RFC][PATCH] introduce task cgroup (#task restrictio ...
Hi
OK.
you are right.
No.
but I have plan to mesure it at nearly future.
Thanks.
--
| Jun 5, 3:51 am 2008 |
| Li Zefan | Re: [RFC][PATCH] introduce task cgroup (#task restrictio ...
You are not handling task migration between groups, i.e.:
# echo $$ > /cgroup/1/tasks
Maybe you need to add this in cgroup_init_subsys():
- need_forkexit_callback |= ss->fork || ss->exit;
+ need_forkexit_callback |= ss->fork || ss->exit || ss->can_fork;
and then we can do:
if (need_forkexit_callback) {
for (i = 0; i < CGROUP_SUBSYS_COUNT; i++) {
...
}
--
| Jun 4, 10:47 pm 2008 |
| KOSAKI Motohiro | [RFC][PATCH] introduce task cgroup (#task restrictioon f ...
Hi
I create new cgroup of number task restriction.
Please any comments!
benefit
========================================
1. prevent fork bomb.
We already have "/prox/sys/kernel/threads-max".
but it isn't perfect solution.
because threads-max prevent any process creation.
then, System-administrator can't login and restore trouble.
restrict of cgroup is better solution.
it can prevent fork by network service daemon, but allow fork interactive operation.
2. help implement batch ...
| Jun 4, 9:43 pm 2008 |
| Dhaval Giani | Re: [RFC][PATCH] introduce task cgroup (#task restrictio ...
How does this controller affect performance? Do you have some numbers?
Thanks,
--
regards,
Dhaval
--
| Jun 5, 2:27 am 2008 |
| Randy Dunlap | [PATCH] dev_set_name: fix missing kernel-doc
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix kernel-doc for new dev_set_name() function:
Warning(lin2626-rc5//drivers/base/core.c:767): No description found for parameter 'fmt'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/base/core.c | 1 +
1 file changed, 1 insertion(+)
--- lin2626-rc5.orig/drivers/base/core.c
+++ lin2626-rc5/drivers/base/core.c
@@ -762,6 +762,7 @@ static void device_remove_class_symlinks
/**
* dev_set_name - set a device name
* ...
| Jun 4, 9:40 pm 2008 |
| Bjorn Helgaas | Re: Linux 2.6.26-rc5
Yep, Tony Luck reported this yesterday as well. I'll work up a
patch this morning.
Bjorn
--
| Jun 5, 8:12 am 2008 |
| Linus Torvalds | Re: Linux 2.6.26-rc5
Umm. If I was a compiler, I'd be warning about this. You don't get a
warning about suggesting parentheses around the '&'?
Also, regardless of lack of warnings, the natural way to do this is to
just say
if (res->flags & (IORESOURCE_DISABLED | IORESOURCE_UNSET))
continue;
which is what any sane compiler would rewrite it to anyway, but since it's
not just more readable for computers, but for humans too, why not do it
that way?
Linus
--
| Jun 5, 9:19 am 2008 |
| Olaf Hering | Re: [PATCH] libata: fix G5 SATA broken on -rc5
Tested-by: Olaf Hering <olaf@aepfle.de>
--
| Jun 5, 7:45 am 2008 |
| Alan Cox | Re: Linux 2.6.26-rc5 (G5 SATA broken)
Its the right fix
ata_sff_check_altstatus() is a routine which does the altstatus
check and may or may not call the helper
ata_sff_check_status() is a default method for ap->ops->
This lunatic naming leads to mistakes 8(
--
| Jun 5, 5:54 am 2008 |
| Olaf Hering | Re: Linux 2.6.26-rc5
SATA on a dualcore G5 is broken, it happend between
c3b25b32e8bef526cca748e1ba023c6bdd705a99..53c8ba95402be65d412a806cda3430f0e72cd107
irq 18: nobody cared (try booting with the "irqpoll" option)
Disabling IRQ #18
ctrl alt del on the USB keyboard does not trigger a reboot.
Sometimes the cursor stops blinking, sometimes just nothing happens
after ctrl alt del.
Does 53c8ba95402be65d412a806cda3430f0e72cd107 work for others on G5?
--
| Jun 5, 4:24 am 2008 |
| Linus Torvalds | Re: Linux 2.6.26-rc5
.. repeated a lot ..
It's harmless but obviously irritating. The PnP resource manager changes
need a few cleanups still - it's getting confused about IORESOURCE_UNSET
vs IORESOURCE_DISABLED.
Björn?
Linus
--
| Jun 5, 7:54 am 2008 |
| Bjorn Helgaas | Re: Linux 2.6.26-rc5
Here's the patch. I reproduced the problem and verified that this
fixes it.
This should not add conflicts with any of the PNP patches that are
currently in -mm (let me know if it does, of course). After all
those patches, IORESOURCE_UNSET is never set by PNP, but it should
still be harmless to check for it.
PNP: skip UNSET MEM resources as well as DISABLED ones
We don't need to reserve "unset" resources. Trying to reserve
them results in messages like this, which are ugly but ...
| Jun 5, 9:12 am 2008 |
| Alan Cox | Re: Linux 2.6.26-rc5
On Thu, 5 Jun 2008 13:24:36 +0200
See the patch I just posted to Nick/Jeff should fix it. I always said
ata_sff_check_status() was asking for trouble as a name and neither I nor
Jeff nor Linus noticed the bug...
--
| Jun 5, 5:42 am 2008 |
| Ben Dooks | Re: Linux 2.6.26-rc5
Is it too early to ask how long before 2.6.26 is released?
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
--
| Jun 5, 7:43 am 2008 |
| Linus Torvalds | Linux 2.6.26-rc5
Another week, another batch of mostly pretty small fixes. Hopefully the
regression list is shrinking, and we've fixed at least a couple of the
oopses on Arjan's list.
As usual, the bulk of the changes are in drivers and arch code - together
they are about 70% of the diffstat. And the arch stats are bloated by some
new/updated SH and avr defconfig files, which is also fairly common at
this stage.
Perhaps unusually, 13% is in kernel/, almost all of it fixing up some
scheduler issues - ...
| Jun 4, 8:36 pm 2008 |
| Alejandro Riveira | Re: Linux 2.6.26-rc5
El Wed, 4 Jun 2008 20:36:24 -0700 (PDT)
I got this on my dmesg; is this expected/harmaless?
(btw The wireless driver oops that i reported is gone as it is the
bluetooth one ;)
[ 0.232963] system 00:08: ioport range 0x4d0-0x4d1 has been reserved
[ 0.233020] system 00:08: ioport range 0x4000-0x40bf could not be reserved
[ 0.233075] system 00:08: ioport range 0x40c0-0x40df has been reserved
[ 0.233131] system 00:08: ioport range 0x400-0x40f has been reserved
[ 0.233186] system ...
| Jun 5, 6:03 am 2008 |
| Bjorn Helgaas | Re: Linux 2.6.26-rc5
Geez, I dreamed about this very question last night, but forgot to
take care this morning.
Actually, I didn't get a warning (gcc 4.1.3), but your way is better.
Here's the updated patch if you haven't fixed it already:
PNP: skip UNSET MEM resources as well as DISABLED ones
We don't need to reserve "unset" resources. Trying to reserve
them results in messages like this, which are ugly but harmless:
system 00:08: iomem range 0x0-0x0 could not be reserved
Future PNP patches ...
| Jun 5, 9:32 am 2008 |
| Hugh Dickins | Re: Linux 2.6.26-rc5 (G5 SATA broken)
I've been bisecting that on Quad G5 (sata_svw): irq 18: nobody cared ...,
then later endless ata1.00: exception..., blah blah, ata1: EH complete.
It comes down to:
commit a57c1bade5a0ee5cd8b74502db9cbebb7f5780b2
Author: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Thu May 29 22:10:58 2008 +0100
libata-sff: Fix oops reported in kerneloops.org for pnp devices with no ctl
And the patch I'm finding successful is below: I won't sign it off,
for all I know it's reverting part of what Alan is ...
| Jun 5, 5:09 am 2008 |
| Hugh Dickins | [PATCH] libata: fix G5 SATA broken on -rc5
Fix G5 SATA irq 18: nobody cared, reported on -rc5 by Olaf Hering:
fixlet to a57c1bade5a0ee5cd8b74502db9cbebb7f5780b2 libata-sff:
Fix oops reported in kerneloops.org for pnp devices with no ctl
Signed-off-by: Hugh Dickins <hugh@veritas.com>
Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
---
drivers/ata/libata-sff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 2.6.26-rc5/drivers/ata/libata-sff.c 2008-06-05 07:18:07.000000000 +0100
+++ ...
| Jun 5, 6:44 am 2008 |
| Alex Romosan | Re: Linux 2.6.26-rc5
i get the following oops trying to mount an ntfs partition on thinkpad
t61 running a 64-bit kernel:
BUG: unable to handle kernel paging request at ffffc20005bb0000
IP: [<ffffffffa004fd83>] :ntfs:load_system_files+0x6ce/0x1892
PGD 13bc0b067 PUD 13bc0c067 PMD 139491067 PTE 0
Oops: 0000 [1] PREEMPT SMP
CPU 1
Modules linked in: nls_utf8 ntfs loop i2c_i801 i2c_core ehci_hcd uhci_hcd video output joydev evdev
Pid: 1884, comm: mount Not tainted 2.6.26-rc5 #10
RIP: ...
| Jun 5, 7:47 am 2008 |
| Andrew Morton | Re: [-mmotm] build failure: undefined reference to `wake ...
OK, thanks, that function must have become undead since I last did a
test build.
wakeup_gran() also seems to have been resurrected, so
sched-delete-dead-stuff-2.patch is no longer needed either.
--
| Jun 4, 7:51 pm 2008 |
| Li Zefan | [-mmotm] build failure: undefined reference to `wakeup_p ...
kernel/built-in.o: In function `pick_next':
/home/lizf/linux-2.6.26-rc4/kernel/sched_fair.c:738: undefined reference to `wakeup_preempt_entity'
kernel/built-in.o: In function `check_preempt_wakeup':
/home/lizf/linux-2.6.26-rc4/kernel/sched_fair.c:1194: undefined reference to `wakeup_preempt_entity'
This patch:
sched-delete-dead-stuff.patch
------------------------------------------------
From: Andrew Morton <akpm@linux-foundation.org>
kernel/sched_fair.c:1170: warning: ...
| Jun 4, 7:36 pm 2008 |
| Li Zefan | [PATCH -mmotm] drivers/char/rtc.c: fix build failure
This patch caused build failure:
rtc-push-the-bkl-down-into-the-driver-ioctl-method.patch
drivers/char/rtc.c:721: error: conflicting types for ‘rtc_ioctl’
drivers/char/rtc.c:146: error: previous declaration of ‘rtc_ioctl’ was here
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
rtc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/char/rtc.c.old 2008-06-05 09:11:20.000000000 +0800
+++ a/drivers/char/rtc.c 2008-06-05 09:11:28.000000000 +0800
@@ -143,7 +143,7 ...
| Jun 4, 6:20 pm 2008 |
| kosaki.motohiro | [PATCH 1/5] fix incorrect variable type of do_try_to_fre ...
"Smarter retry of costly-order allocations" patch series change behaver of do_try_to_free_pages().
but unfortunately ret variable tyep unchanged.
thus, overflow problem is possible.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
mm/vmscan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/mm/vmscan.c
===================================================================
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1317,7 +1317,7 @@ static unsigned long ...
| Jun 4, 7:12 pm 2008 |
| KOSAKI Motohiro | Re: [PATCH 1/5] fix incorrect variable type of do_try_to ...
sorry, this patch already get Nishanth-san's ACK.
I'll append it and resend by this mail.
----------------------------
fix incorrect variable type of do_try_to_free_pages()
"Smarter retry of costly-order allocations" patch series change behaver of do_try_to_free_pages().
but unfortunately ret variable tyep unchanged.
thus, overflow problem is possible.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Acked-by: Nishanth Aravamudan <nacc@us.ibm.com>
---
...
| Jun 4, 6:26 pm 2008 |
| KOSAKI Motohiro | Re: [PATCH 2/5] introduce get_vm_event().
sorry, this patch already get Rik-san's ACK.
I'll append it and resend by this mail.
------------------------------------
introduce get_vm_event() new function for easy use vm statics.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Acked-by: Rik van Riel <riel@redhat.com>
---
include/linux/vmstat.h | 7 ++++++-
mm/vmstat.c | 16 ++++++++++++++++
2 files changed, 22 insertions(+), 1 deletion(-)
Index: ...
| Jun 4, 6:29 pm 2008 |
| kosaki.motohiro | [PATCH 2/5] introduce get_vm_event().
introduce get_vm_event() new function for easy use vm statics.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
include/linux/vmstat.h | 7 ++++++-
mm/vmstat.c | 16 ++++++++++++++++
2 files changed, 22 insertions(+), 1 deletion(-)
Index: b/include/linux/vmstat.h
===================================================================
--- a/include/linux/vmstat.h
+++ b/include/linux/vmstat.h
@@ -98,6 +98,8 @@ static inline void vm_events_fold_cpu(in
}
...
| Jun 4, 7:12 pm 2008 |
| kosaki.motohiro | [PATCH 4/5] add throttle to shrink_zone()
add throttle to shrink_zone() for performance improvement and prevent incorrect oom.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
include/linux/mmzone.h | 2 +
include/linux/sched.h | 1
mm/Kconfig | 10 +++++++
mm/page_alloc.c | 3 ++
mm/vmscan.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++++-
5 files changed, 77 insertions(+), 1 deletion(-)
Index: ...
| Jun 4, 7:12 pm 2008 |
| KOSAKI Motohiro | Re: [PATCH 0/5] page reclaim throttle v7
my patch have 2 improvement.
1. ristrict reclaiming parallerism of #task (throttle)
2. reclaiming cut off if other task already freed enough memory.
we already consider #1 on memcg and works well.
but we doesn't support #2 on memcg because balbir-san's said
"memcg doesn't need it".
--
| Jun 4, 7:23 pm 2008 |
| kosaki.motohiro | [PATCH 0/5] page reclaim throttle v7
Hi
I post latest version of page reclaim patch series.
This patch is holding up very well under usex stress test
over 24+ hours :)
Against: 2.6.26-rc2-mm1
changelog
========================================
v6 -> v7
o rebase to 2.6.26-rc2-mm1
o get_vm_stat: make cpu-unplug safety.
o mark vm_max_nr_task_per_zone __read_mostly.
o add check __GFP_FS, __GFP_IO for avoid deadlock.
o fixed compile error on x86_64.
v5 -> v6
o rebase to 2.6.25-mm1
...
| Jun 4, 7:12 pm 2008 |
| KAMEZAWA Hiroyuki | Re: [PATCH 0/5] page reclaim throttle v7
On Thu, 05 Jun 2008 11:12:11 +0900
I like this series and I'd like to support this under memcg when
this goes to mainline. (it seems better to test this for a while
before adding some memcg-related changes.)
Then, please give me inputs.
What do you think do I have to do for supporting this in memcg ?
Handling the case of scan_global_lru(sc)==false is enough ?
Thanks,
--
| Jun 4, 7:06 pm 2008 |
| kosaki.motohiro | [PATCH 3/5] change return type of shrink_zone()
change function return type for following enhancement.
this patch have no behaver change.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
mm/vmscan.c | 71 +++++++++++++++++++++++++++++++++++++-----------------------
1 file changed, 44 insertions(+), 27 deletions(-)
Index: b/mm/vmscan.c
===================================================================
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -51,6 +51,9 @@ struct scan_control {
/* Incremented by the number of ...
| Jun 4, 7:12 pm 2008 |
| kosaki.motohiro | [PATCH 5/5] introduce sysctl of throttle
introduce sysctl parameter of max task of throttle.
<usage>
# echo 5 > /proc/sys/vm/max_nr_task_per_zone
</usage>
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
include/linux/swap.h | 2 ++
kernel/sysctl.c | 9 +++++++++
mm/vmscan.c | 4 +++-
3 files changed, 14 insertions(+), 1 deletion(-)
Index: b/mm/vmscan.c
===================================================================
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -125,9 +125,11 ...
| Jun 4, 7:12 pm 2008 |
| David Miller | [GIT]: Networking
A lot of little things in here, a large chunk of it is
backlog that accumulated while I've been (still) travelling.
I should be done changing timezones every other day next
week.
Highlights:
1) Wired driver fixes from Jeff Garzik and co.
2) Wireless driver fixes from John Linville and co.
3) IPV6 bug fixes from HIDEAKI Yoshifuji et al.
4) IPSEC algorithm string name fix from Adrian-Ken Rueegsegger
5) Bluetooth rfcomm deadlock fix from Dave Young
6) Netfilter bug fixes via ...
| Jun 4, 5:01 pm 2008 |
| Jeff Layton | Re: [2.6.26-rc4] mount.nfsv4/memory poisoning issues...
On Thu, 5 Jun 2008 00:33:54 +0100
Looks like it fell down while trying to take down the kthread during a
failed mount attempt. I have to wonder if I might have introduced a
race when I changed nfs4 callback thread to kthread API. I think we may
need the BKL around the last 2 statements in the main callback thread
function. If you can easily reproduce this, could you test the
following patch and let me know if it helps?
Note that this patch is entirely untested, so test it ...
| Jun 4, 5:35 pm 2008 |
| Daniel J Blueman | Re: [2.6.26-rc4] mount.nfsv4/memory poisoning issues...
This doesn't resolve the issue, alas. I'll hunker down to the
bisection in the next few days.
Thanks,
Daniel
--
Daniel J Blueman
--
| Jun 5, 1:28 am 2008 |
| Jeff Layton | Re: [2.6.26-rc4] mount.nfsv4/memory poisoning issues...
On Thu, 5 Jun 2008 09:28:51 +0100
Yeah, after I sent that I went back and looked and it seemed like
while we don't hold the BKL there, access to the callback info is still
serialized via a semaphore. Thanks for testing it anyway...
--
Jeff Layton <jlayton@redhat.com>
--
| Jun 5, 3:32 am 2008 |
| Dave Airlie | Re: BUG: unable to handle kernel NULL pointer dereferenc ...
This patch will break some other parts of the DRM interface, I'll try
and come up with one that is less likely do stop all the drivers
working.
The problem is there are binaries out there with bad userspace ioctl
bits..
What I'll change it to do is at least allocate the size from the kernel
definition not what the user passed in.
The big problem we have with malformed requests is that userspace asks
for one thing and expects another, so I should key the userspace from
the ioctl nr and ...
| Jun 4, 8:05 pm 2008 |
| Johannes Weiner | Re: BUG: unable to handle kernel NULL pointer dereferenc ...
Hi,
Hm, in drm_getunique, dev is not NULL as it was already dereferenced in
drm_ioctl. file_priv is not used at all. So only data is left.
data is kdata in drm_ioctl and only NULL if the ioctl request is neither
input nor output.
I have not found a check on cmd in the callpath that would filter out
malformed requests. So the user would be allowed to pass in a valid
request number with wrong flags here, correct?
Hannes
---
drm: check ioctl direction before dispatching
The ...
| Jun 4, 5:54 pm 2008 |
| Johannes Weiner | Re: BUG: unable to handle kernel NULL pointer dereferenc ...
Hi,
Hm, like this?
diff --git a/drivers/char/drm/drm_drv.c b/drivers/char/drm/drm_drv.c
index fc54140..019bf1f 100644
--- a/drivers/char/drm/drm_drv.c
+++ b/drivers/char/drm/drm_drv.c
@@ -475,6 +475,9 @@ int drm_ioctl(struct inode *inode, struct file *filp,
else
goto err_i1;
+ /* Do not trust userspace, use our own definition */
+ cmd = ioctl->cmd;
+
func = ioctl->func;
/* is there a local override? */
if ((nr == DRM_IOCTL_NR(DRM_IOCTL_DMA)) && ...
| Jun 5, 11:04 am 2008 |
| Johannes Weiner | Re: BUG: unable to handle kernel NULL pointer dereferenc ...
Hi,
Make that run-time tested, also. This does not just affect linux-next.
The following program oopses my box running Linus' current git:
#include <fcntl.h>
#include <unistd.h>
#include <sys/ioctl.h>
#include <drm/drm.h>
#define DRM_DFILE "/dev/dri/card0"
#define DRM_IOCTL_CAPUT _IO(DRM_IOCTL_BASE, 0x01)
int main(void)
{
int fd = open(DRM_DFILE, O_RDONLY);
if (fd < 0)
return 1;
ioctl(fd, DRM_IOCTL_CAPUT);
perror("ioctl");
close(fd);
return 0;
}
->
[ ...
| Jun 4, 7:21 pm 2008 |
| Kumar Gala | Re: math-emu issue with fp divide
Now that I'm digging into this a bit I'm thinking my issue has to do with
the fix you put in place from back in Aug 2007 (commit
405849610fd96b4f34cd1875c4c033228fea6c0f):
[MATH-EMU]: Fix underflow exception reporting.
2) we ended up rounding back up to normal (this is the case where
we set the exponent to 1 and set the fraction to zero), this
should set inexact too
...
Another example, "0x0.0000000000001p-1022 / 16.0", should signal both
inexact and underflow. ...
| Jun 5, 6:38 am 2008 |
| Jeremy Fitzhardinge | Jun 5, 8:27 am 2008 | |
| Andrew Morton | Re: [PATCH] kobject: Export kobject_rename for pci_hotpl ...
In that case the fix should be integrated into the patch which it is
fixing.
Well, it doesn't _have_ to be integrated because in this case it can
precede acpi-pci-slot-detection-driver.patch. But we might as well
fold it, to keep the commit noise level down.
--
| Jun 4, 11:33 pm 2008 |
| Kenji Kaneshige | Re: [PATCH] kobject: Export kobject_rename for pci_hotpl ...
I think "No", because currently its only required by Alex's "pci slot"
patches.
Thanks,
Kenji Kaneshige
--
| Jun 4, 11:05 pm 2008 |
| Kenji Kaneshige | Re: [PATCH 0/4, v14] PCI, ACPI: Physical PCI slot objects
Hi Alex-san,
I tried to test your patch using latest linux-next, but I could
not apply your patch with the following messages:
$ quilt push
Applying patch patches/fakephp-construct-one-fakephp-slot-per-pci-slot.patch
(Stripping trailing CRs from patch.)
patching file drivers/pci/hotplug/fakephp.c
Hunk #2 succeeded at 102 (offset 1 line).
Hunk #3 FAILED at 116.
Hunk #4 succeeded at 154 (offset 4 lines).
Hunk #5 succeeded at 299 (offset 1 line).
Hunk #6 succeeded at 314 (offset 4 ...
| Jun 4, 7:32 pm 2008 |
| Alex Chiang | Re: [PATCH] kobject: Export kobject_rename for pci_hotpl ...
Originally, gregkh told me "no" because then he would have to
deal with a bunch of patching removing an unused interface, which
Ok, that makes sense to me.
/ac
--
| Jun 5, 8:11 am 2008 |
| Kenji Kaneshige | Re: [PATCH 0/4, v14] PCI, ACPI: Physical PCI slot objects
Alex-san,
Thank you for updated patch. I'll try it.
Unfortunately, I'm a little busy on the other jobs, so the test
report might be delayed until the beginning of next week.
Thanks,
Kenji Kaneshige
--
| Jun 4, 8:20 pm 2008 |
| Andrew Morton | Re: [PATCH] kobject: Export kobject_rename for pci_hotpl ...
Shouldn't this go straight into 2.6.26?
--
| Jun 4, 10:48 pm 2008 |
| Alex Chiang | Re: [PATCH 0/4, v14] PCI, ACPI: Physical PCI slot objects
Hi Kenji-san,
Sorry, that latest patch series was against Linus' tree, not
Yes, thanks for pointing this out. I've fixed patch 1/4.
I verified that patches 2, 3 and 4 apply cleanly against
linux-next, so this should be the only fix you'll need.
Sorry for the confusion.
/ac
commit c0175afea14cdaff3c33d894eb474eed1dcfa65d
Author: Alex Chiang <achiang@hp.com>
Date: Wed Jun 4 21:04:46 2008 -0600
Construct one fakephp slot per PCI slot
Register one slot per slot, ...
| Jun 4, 8:07 pm 2008 |
| Oleg Nesterov | Re: TASK_WAKEKILL && /sbin/init (was: [PATCH 1/2] schedu ...
Forgot to mention, this part is questionable of course. And it can't
prevent the case when "ret = sys_read(count)" succeeds, but ret < count.
Oleg.
--
| Jun 5, 9:16 am 2008 |
| Oleg Nesterov | Re: TASK_WAKEKILL && /sbin/init (was: [PATCH 1/2] schedu ...
This is what I am talking about. The SIGNAL_UNKILLABLE task (init) dequeues
the pending SIGKILL and just ignores it. Then it returns to the user space
with -EIO.
But when we send SIGKILL, the sender wakes up the TASK_KILLABLE task, and
after that fatal_signal_pending() is true. Once again, it is not hard to
fix this problem in kernel/signal.c, but _perhaps_ the change in filemap.c
makes sense anyway.
Oleg.
--
| Jun 5, 9:04 am 2008 |
| Matthew Wilcox | Re: TASK_WAKEKILL && /sbin/init (was: [PATCH 1/2] schedu ...
Have you actually tested this? I thought it was handled by:
/*
* Global init gets no signals it doesn't want.
*/
if (unlikely(signal->flags & SIGNAL_UNKILLABLE) &&
!signal_group_exit(signal))
continue;
in get_signal_to_deliver().
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us ...
| Jun 5, 8:48 am 2008 |
| Oleg Nesterov | Re: [PATCH 1/2] schedule: fix TASK_WAKEKILL vs SIGKILL race
Think about ptrace_notify().
Don't get me wrong. As I said, I think this change would be nice (but I didn't
think thoroughly yet), and it also allows us to cleanup (or fix?) ptrace_stop().
If I knew a better solution, I wouldn't have sent this patch ;)
Yes, we can change all users of TASK_KILLABLE. But personally I think this
would be wrong. I strongly believe this code
current->state = TASK_KILLABLE;
schedule();
should work "as expected".
Btw, I don't completely agree with ...
| Jun 5, 8:23 am 2008 |
| Oleg Nesterov | TASK_WAKEKILL && /sbin/init (was: [PATCH 1/2] schedule: ...
Sorry Matthew, I left this part unanswered because I didn't have the
time yesterday...
If lock_page_killable() fails because the task was killed by SIGKILL or another
fatal signal, do_generic_file_read() returns -EIO.
This seems to be OK, because in fact the userspace won't see this error, the
task will dequeue SIGKILL and exit.
However, /sbin/init is different, it will dequeue SIGKILL, ignore it, and be
confused by this bogus -EIO. Please note that while this bug is not likely,
it is ...
| Jun 5, 8:23 am 2008 |
| Jan Kara | Re: Two questions on VFS/mm
You are right, write_cache_pages() is correct - I've wrongly undrestood
Hmm, the fact is I've seen in my tests writepage() being called on a page
which had its buffers removed. And because we attach buffers to a page in
page_mkwrite() and in write_begin() I think we should not see such page.
I've added more debug printings to the code to verify that the page has
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
--
| Jun 5, 1:12 am 2008 |
| Ben Hutchings | Re: [PATCH] cputopology: Always define CPU topology info ...
[...]
Sorry, I don't know how that escaped me. My changes to the show functions
should be unnecessary - though I think that the two different implementations
for lvalues and rvalues are a premature optimisation.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
| Jun 5, 5:08 am 2008 |
| Andrew Morton | Re: [PATCH] cputopology: Always define CPU topology info ...
See, this is what I meant. After your patch we have:
#ifdef arch_provides_topology_pointers
#define define_siblings_show_map(name) \
static ssize_t show_##name(struct sys_device *dev, char *buf) \
{ \
unsigned int cpu = dev->id; \
cpumask_t siblings = topology_##name(cpu); \
return show_cpumap(0, &siblings, buf); \
}
#define define_siblings_show_list(name) \
static ssize_t show_##name##_list(struct sys_device *dev, char *buf) \
{ \
unsigned int cpu ...
| Jun 4, 9:47 pm 2008 |
| Ben Hutchings | [PATCH] cputopology: Always define CPU topology informat ...
Not all architectures and configurations define CPU topology information.
This can result in an empty topology directory in sysfs, and requires
in-kernel users to protect all uses with #ifdef - see
<http://marc.info/?l=linux-netdev&m=120639033904472&w=2>.
The documentation of CPU topology specifies what the defaults should be
if only partial information is available from the hardware. So we can
provide these defaults as a fallback.
This patch:
- Adds default definitions of the 4 topology ...
| Jun 5, 9:37 am 2008 |
| Andrew Morton | Re: [PATCH] cputopology: Always define CPU topology info ...
um, what does this mean. Will you be sending an updated patch or should
I drop those two or...?
--
| Jun 5, 9:28 am 2008 |
| Jens Axboe | Re: file_splice_read problem in 2.6.24.2?
Yep, that looks like the same 'spinning in splice read' problem, so
the 2.6.25 kernel should work fine.
--
Jens Axboe
--
| Jun 5, 12:03 am 2008 |
| Tristan Linnenbank | Re: file_splice_read problem in 2.6.24.2?
thanks for your reply.
I appended five of the bunch of errors to this mail. They all lock the
CPU for 11 seconds (just like the nfsd errors we had in February/April),
so that could be a sign of them being the same bug.
It seems to be the same problem. We've only seen this behaviour once on
the one machine though. I'll keep a couple of webservers on 2.6.24.2 and
some on 2.6.25.4, just to see what happens.
Thanks!
Kind regards,
Tristan
Jun 4 15:08:38 web10.c1.internal kernel: ...
| Jun 4, 11:59 pm 2008 |
| FUJITA Tomonori | Re: Intel IOMMU (and IOMMU for Virtualization) performances
On Wed, 4 Jun 2008 11:06:15 -0700
Good point, it would be more appropriate to evaluate the performances
of such workload rather than simple I/Os.
I'm interested in what workload Intel people played with and why they
Yeah, probabaly right. I thought that 10GbE give the IOMMU more
Yeah, I can add a nice trick in parisc sba_iommu uses. I'll try next
time.
But it probably gives the bitmap method less gain than the RB tree
since clear the bitmap takes less time than changing the ...
| Jun 5, 7:49 am 2008 |
| James Bottomley | Re: Intel IOMMU (and IOMMU for Virtualization) performances
map_page, actually, but effectively the same thing. However, all
Not necessarily ... there's a safety vs performance issue here. As long
as the iotlb mapping persists, the device can use it to write to the
memory. If you fail to flush, you lose the ability to detect device dma
after free (because the iotlb may still be valid). On standard systems,
this happens so infrequently as to be worth the tradeoff. However, in
virtualised systems, which is what the intel iommu is aimed at, ...
| Jun 5, 12:01 pm 2008 |
| mark gross | Re: Intel IOMMU (and IOMMU for Virtualization) performances
FWIW: You'll see bigger deltas if you boot with intel_iommu=strict, but
those will be because of waiting on IOMMU hardware to flush caches and
I'm going to be out of contact for a few weeks but this work sounds
I'll look closely at your patch later.
--mgross
--
| Jun 5, 3:02 pm 2008 |
| FUJITA Tomonori | Re: Intel IOMMU (and IOMMU for Virtualization) performances
On Wed, 04 Jun 2008 18:56:35 +0200
If we use 4GB virtual DMA address space (as the patch does), we need
128 KB for the bitmap for one domain.
With the RB tree, the memory consumption depends on how many addresses
are mapped (it needs one entry for one address though we could merge
multiple addresses).
--
| Jun 5, 7:49 am 2008 |
| Grant Grundler | Re: Intel IOMMU (and IOMMU for Virtualization) performances
On Thu, Jun 5, 2008 at 7:49 AM, FUJITA Tomonori
<fujita.tomonori@lab.ntt.co.jp> wrote:
10GbE might exercise a different code path. NICs typically use map_single
and storage devices typically use map_sg. But they both exercise the same
underlying resource management code since it's the same IOMMU they poke at.
The batching of the TLB flushes is the key thing. I was being paranoid
by not marking the resource free until after the TLB was flushed. If we
know the allocation is going to be ...
| Jun 5, 11:34 am 2008 |
| Zhao Yakui | Re: [patch -v3 16/22] acpi: use memory_read_from_buffer
it seems that there is no definition of memory_read_from_buffer.
Where is the function of memory_read_from_buffer defined?
Is there a bug about the current function of acpi_table_show?
--
| Jun 4, 6:21 pm 2008 |
| Andrew Morton | Re: [patch -v3 16/22] acpi: use memory_read_from_buffer
No, it's just a cleanup.
From: Akinobu Mita <akinobu.mita@gmail.com>
This patch introduces memory_read_from_buffer().
The only difference between memory_read_from_buffer() and
simple_read_from_buffer() is which address space the function copies to.
simple_read_from_buffer copies to user space memory.
memory_read_from_buffer copies to normal memory.
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Doug Warzecha ...
| Jun 4, 6:29 pm 2008 |
| Jesse Barnes | Re: [PATCH] PCI: Unhide the SMBus on the Compaq Evo D510
Thanks Jean, I'll queue it in linux-next.
Jesse
--
| Jun 5, 1:57 pm 2008 |
| David Woodhouse | Re: [BUILD-FAILURE] linux-next: Tree for June 4 - firmwa ...
I've committed an alternative for firmware/Makefile.
What's the problem in Makefile.headersinst?
--
dwmw2
--
| Jun 5, 2:15 am 2008 |
| Sam Ravnborg | Re: [BUILD-FAILURE] linux-next: Tree for June 4 - firmwa ...
It uses order-only in this line:
$(objhdr-y) $(subdir-y) $(header-y) $(unifdef-y): | $(INSTALL_HDR_PATH)/$(_dst) $(unwanted)
Not a big deal as this is only used during make headers_*
Sam
--
| Jun 5, 3:44 am 2008 |
| Sam Ravnborg | Re: [BUILD-FAILURE] linux-next: Tree for June 4 - firmwa ...
The correct fix is to get rid of make 3.81 features.
We do want the kernel buildable with make 3.79 and we have today only two
places where we do need a newer version of make:
scripts/Makefile.headerinst
and now
firmware/Makefile
Both places should be reworked to avoid this dependency.
I plan to take care of Makfile.headerinst soonish in an attempt
to speed up the checking process (has been on my TODO list for a long time),
And we should not introuduce the below make 3.81 specific ...
| Jun 5, 2:13 am 2008 |
| Kamalesh Babulal | [BUILD-FAILURE] linux-next: Tree for June 4 - firmware/k ...
The make version used is
# make -v
GNU Make 3.80
Thanks the patch, the build failure is fixed but the kernel panics while
booting the machine
BUG: unable to handle kernel paging request at 0000000000003708
IP: [<ffffffff8026cd89>] __alloc_pages_internal+0xc0/0x3d3
PGD 0
Oops: 0000 [1] SMP
last sysfs file:
CPU 0
Modules linked in:
Pid: 1, comm: swapper Not tainted 2.6.26-rc4-next-20080604-autotest #1
RIP: 0010:[<ffffffff8026cd89>] [<ffffffff8026cd89>] ...
| Jun 5, 2:43 am 2008 |
| Uwe | Re: [PATCH] uio_pdrv: Unique IRQ Mode
Hello Magnus,
This depends on the definition of "board support". I think of it as
"code for that (type of) machine", i.e. everything below arch/. With
that definition really each platform device depends on "board support"
I haven't done that though.
Best regards
Uwe
--
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
--
| Jun 5, 4:33 am 2008 |
| Hans J. Koch | Re: [PATCH] uio_pdrv: Unique IRQ Mode
You assume the interrupt is not shared. You can never do that on a
normal x86 PC, for example. E.g. for a PCI card you don't know which irq
Stuff that is useful for other driver writers and not only for userspace
people should be added to Documentation/Docbook/uio_howto.tmpl.
Unfortunately, I forgot to ask Uwe to do this, so I'll probably have to
You have to write code there anyway, e.g. code that configures your GPIO
as input, makes it generate interrupts and so on. And of course, ...
| Jun 5, 2:09 am 2008 |
| Hans J. Koch | Re: [PATCH] uio_pdrv: Unique IRQ Mode
ATM, I work with iMX31 and AT91SAM9263, before that I had a PXA270,
can't remember what was before that...
If it's a device within the SoC, you won't use UIO for that. If you did,
your platform would depend on certain userspace software which is simply
All I said about board support also applies to platform support files
like at91sam9263_devices.c, I'm simply talking about the file where you
uio_pdrv is a generic driver, so I consider it part of the UIO
framework. It adds new ...
| Jun 5, 4:27 am 2008 |
| Magnus Damm | Re: [PATCH] uio_pdrv: Unique IRQ Mode
So your main objection against this patch is that you cannot use it
Ever heard about system on chip? Not all platform devices need board
How is this changing the UIO behavior? I'm modifying the uio_pdrv
driver, which is a driver that you didn't even write yourself. And yet
You don't have to accept it. I'll just repost my original driver and
let someone else merge it then.
/ magnus
--
| Jun 5, 2:46 am 2008 |
| Uwe | Re: [PATCH] uio_pdrv: Unique IRQ Mode
Hello Magnus,
BTW, I wouldn't call it "Unique IRQ Mode" because the non-shared irq is
only a result from automatically disabling the irq. IMHO something like
"No IRQ Handler Mode" is more suitable.
Best regards
Uwe
--
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
--
| Jun 4, 11:49 pm 2008 |
| Magnus Damm | Re: [PATCH] uio_pdrv: Unique IRQ Mode
Exactly what in my patch makes this platform driver only suitable for
I'm not sure if silently and blindly are the first words that pop into
my mind, but sure. Documentation is a good idea. Just let me know
You propose that I put the callbacks in my board support code instead
of modifying the driver. I don't think the board support level is the
proper place for this code. The patch contains no board specific code,
We can reuse this driver for _many_ different SuperH processor models.
Most ...
| Jun 4, 6:25 pm 2008 |
| KAMEZAWA Hiroyuki | Re: [RFC][PATCH 2/2] memcg: hardwall hierarhcy for memcg
On Wed, 4 Jun 2008 21:32:35 +0900
you're right. I misunderstood where the number of children is checked.
Thanks,
--
| Jun 4, 5:04 pm 2008 |
| KOSAKI Motohiro | Re: [PATCH 1/4] per-task-delay-accounting: add memory re ...
Documentation/controllers/memory.txt is good guide :)
<abstract>
try_to_free_pages(): global reclaim entry point
try_to_free_mem_cgroup_pages(): memcgroup reclaim entry point
do_try_to_free_pages(): common layer
Unfortunately, I don't know your requirement and
memcgroup reclaim shold be mesured.
I hope you explain your purpose and benefit more.
Thanks.
--
| Jun 4, 5:50 pm 2008 |
| Keika Kobayashi | Re: [PATCH 4/4] per-task-delay-accounting: /proc export ...
On Wed, 4 Jun 2008 15:41:24 -0700
I agree. There is no strong reason with two method.
I'll drop this one from patch series next time.
--
| Jun 4, 7:30 pm 2008 |
| Hiroshi Shimamoto | Re: [PATCH 1/4] per-task-delay-accounting: add memory re ...
thanks, and playing with this is good too.
I see the point that, on memcgroup enabled system, there are
memcgroup memory reclaim points and try_to_free_mem_cgroup_pages()
is called when the page charge reach the limit.
So if we want to account delay for memory reclaim, we should
account at both of try_to_free_pages() and try_to_free_mem_cgroup_pages().
Ah, sure.
We have an issue that a process which accesses a DB sometime slows down.
We want to know what causes it, without the ...
| Jun 5, 11:56 am 2008 |
| Alok Kataria | Re: [RFC PATCH] x86:Use cpu_khz for loops_per_jiffy calc ...
So then, how about using the tsc_khz (tsc frequency) for this
calculation. Atleast for the boot processor the lpj value can be derived
from the tsc frequency.
So insted of using lpj_tsc for all cpu's we can use it just for the boot
Agreed so we might not be able to use it for other cpus's.
Is there a way to get the cpu frequency of the processor that we are
bringing up, i see that there is cpufreq_quick_get but this would be
initialized very late in the boot process.
If there is a way ...
| Jun 5, 11:37 am 2008 |
| Mike Travis | Re: [crash, bisected] Re: [PATCH 3/4] x86_64: Fold pda i ...
Thanks for the feedback Ingo. I'll test the above config and look at
splitting up the patch. The difficulty is making each patch independently
compilable and testable.
Mike
--
| Jun 5, 9:02 am 2008 |
| Ingo Molnar | [crash, bisected] Re: [PATCH 3/4] x86_64: Fold pda into ...
-tip testing found an instantaneous reboot crash on 64-bit x86, with
this config:
http://redhat.com/~mingo/misc/config-Thu_Jun__5_11_43_51_CEST_2008.bad
there is no boot log as the instantaneous reboot happens before anything
is printed to the (early-) serial console. I have bisected it down to:
| 7670dc09e89a2b151a1cf49eccebc07c41c2ce9f is first bad commit
| commit 7670dc09e89a2b151a1cf49eccebc07c41c2ce9f
| Author: Mike Travis <travis@sgi.com>
| Date: Tue Jun 3 17:30:21 2008 ...
| Jun 5, 3:22 am 2008 |
| Peter Zijlstra | Re: [BUG] hotplug cpus on ia64
Does the below fix it?
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
kernel/sched.c | 15 +++++--
kernel/sched_rt.c | 109 +++++++++++++++++++++++++++++++++++++++++++++++++++---
2 files changed, 115 insertions(+), 9 deletions(-)
Index: linux-2.6/kernel/sched_rt.c
===================================================================
--- linux-2.6.orig/kernel/sched_rt.c
+++ linux-2.6/kernel/sched_rt.c
@@ -280,6 +280,9 @@ static int balance_runtime(struct rt_rq
...
| Jun 5, 5:49 am 2008 |
| Peter Zijlstra | Re: [BUG] hotplug cpus on ia64
Humpfh :-( I'll continue looking then...
Thanks for testing.
--
| Jun 5, 7:18 am 2008 |
| Dimitri Sivanich | Re: [BUG] hotplug cpus on ia64
pid 4502's current affinity list: 3
pid 4502's current affinity list: 0,1,3
(above command now hangs)
(ps output)
0xe0000060b5650000 4502 4349 0 2 S 0xe0000060b5650390 bash
0xe0000060b8da0000 4843 4502 0 2 D 0xe0000060b8da0390 bash
Stack traceback for pid 4843
0xe0000060b8da0000 4843 4502 0 2 D 0xe0000060b8da0390 bash
0xa0000001007d44b0 schedule+0x1210
args (0xe0000060ba470ce4, 0xa000000100dae190, 0xe000006003129200, ...
| Jun 5, 6:51 am 2008 |
| Keith Owens | Re: [RFC PATCH] drop support for KALLSYMS_EXTRA_PASS
I am not happy about removing the check for inconsistent kallsyms data.
Changes to the tool chain could cause this problem to recur and we
would not pick up on it. If we do keep the check for inconsistent data
then we still need some way for the user to continue while the problem
is investigated.
Since your real complaint seems to be the extra time taken in make
allyesconfig then the solution is easy. Change CONFIG_KALLSYMS_EXTRA_PASS
to a Makefile option, KALLSYMS_EXTRA_PASS=y. No extra ...
| Jun 5, 2:19 am 2008 |
| Geert Uytterhoeven | Re: [PATCH 12/12]: wext: Emit event stream entries corre ...
That wouldn't help, as it runs on top of an hypervisor API.
The wired part may be merged back with spider_net one day...
With kind regards,
Geert Uytterhoeven
Software Architect
Sony Techsoft Centre
The Corporate Village
| Jun 5, 12:43 am 2008 |
| Balbir Singh | Re: [-mm] CPU controller statistics (v5)
They are really hard to avoid, otherwise we might be taking away the flexibility
OK, will do. I thought that we had addressed this, but we let this one slip.
Good point. Just goes to show that picking up someone elses code and working off
Yes, true. I might be better off, rewriting it. I'll see.
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
--
| Jun 5, 2:37 am 2008 |
| Nix | Re: [PATCH 1/6] UML - Deal with host time going backwards
Does this really only apply on top of 2.6.22? Which of the bewildering
blizzard of time-fixup patches we've been exchanging do I need? :)
--
`If you are having a "ua luea luea le ua le" kind of day, I can only
assume that you are doing no work due [to] incapacitating nausea caused
by numerous lazy demons.' --- Frossie
--
| Jun 5, 11:19 am 2008 |
| Jeff Dike | Re: [PATCH 1/6] UML - Deal with host time going backwards
Without adding -lrt to the link line here (F7), I get
arch/um/os-Linux/built-in.o: In function `nsecs':
/home/jdike/linux/2.6/linux-2.6.22/arch/um/os-Linux/time.c:84: undefined reference to `clock_gettime'
collect2: ld returned 1 exit status
I have it on top of 2.6.26-rc2-mm1, plus all the other patches I've
sent to Andrew. The patch which started this discussion is the one
you really need though, since this backs it out.
Jeff
--
Work email - jdike at linux dot intel dot ...
| Jun 5, 12:47 pm 2008 |
| Nix | Re: [PATCH 1/6] UML - Deal with host time going backwards
It comes with glibc, and even ls uses it (for clock_gettime(), to
determine what format to use for date display).
Rebuilding for a test now.
--
`If you are having a "ua luea luea le ua le" kind of day, I can only
assume that you are doing no work due [to] incapacitating nausea caused
by numerous lazy demons.' --- Frossie
--
| Jun 5, 11:14 am 2008 |
| Jeff Dike | Re: [PATCH 1/6] UML - Deal with host time going backwards
Aha, I was looking at timer_* and not getting reasonable-looking
results. The one questionable aspect of this is that I need to pull
in a new library (librt) and I wonder how many people don't have it
installed...
Anyway, the patch below seems to make the guest behave reasonably in
the face of the host time doing funky things...
Give it a spin and let me know how it does. If there aren't any
problems, I'll get it into mainline.
Jeff
--
Work email - jdike at linux dot ...
| Jun 5, 8:30 am 2008 |
| Nix | Re: [PATCH 1/6] UML - Deal with host time going backwards
I think it's in there because it's part of the POSIX realtime
extensions, so you should have to, as it were, assent to using something
that's not as portable as just using libc. It makes more sense than
libm, anyway.
(It's completely moot for UML of course :) )
--
`If you are having a "ua luea luea le ua le" kind of day, I can only
assume that you are doing no work due [to] incapacitating nausea caused
by numerous lazy demons.' --- Frossie
--
| Jun 5, 2:41 pm 2008 |
| Thomas Gleixner | Re: [PATCH] fix build bug in "x86: add PCI extended conf ...
Can we please remove this superflous arch/x86/kernel/setup.h file,
which has a length/content ratio of 26:1. This removes the ugly
"../setup.h" includes
Thanks,
tglx
--
| Jun 5, 1:41 pm 2008 |
| Robert Richter | [PATCH] fix build bug in "x86: add PCI extended config s ...
Signed-off-by: Robert Richter <robert.richter@amd.com>
---
arch/x86/kernel/cpu/amd.c | 1 -
arch/x86/kernel/cpu/amd_64.c | 1 +
arch/x86/kernel/setup.c | 4 ++--
arch/x86/kernel/setup_64.c | 2 --
include/asm-x86/mmconfig.h | 6 ------
5 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index 656b40a..99221f9 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -4,7 +4,6 @@
...
| Jun 5, 10:32 am 2008 |
| Will Newton | Re: [PATCH] fsl_usb2_udc: Add a wmb before priming endpoint.
Yes, I'll do that and resend the patch along with the rest of the series I have.
My checkpatch does not seem to complain about the missing comment btw.
--
| Jun 5, 5:00 am 2008 |
| Len Brown | Re: Kernel GPF ACPI
ah yes, I thought this rang a bell...
Happily I find that kerneloops now has links to bugzilla -- sorry i didn't
my previous message...
This issue should be gone as of 2.6.25, please let me know if it isn't.
https://bugzilla.novell.com/show_bug.cgi?id=350017
http://bugzilla.kernel.org/show_bug.cgi?id=10252
thanks,
-Len
--
| Jun 4, 11:00 pm 2008 |
| Len Brown | Re: Kernel GPF ACPI
searching for acpi_thermal_trip_seq_show on kerneloops.org shows that this
may still be a problem -- at least up through 2.6.24.
<adding linux-acpi list to the cc>
thanks,
-Len
--
| Jun 4, 10:54 pm 2008 |
| Yasunori Goto | Re: [PATCH -mm 11/14] bootmem: respect goal more likely
I gotcha! :-)
max -= PFN_DOWN(bdata->node_boot_start);
start -= PFN_DOWN(bdata->node_boot_start);
+ fallback -= PFN_DOWN(bdata->node_boot_start);
if (bdata->last_success > start) {
- /* Set goal here to trigger a retry on failure */
- start = goal = ALIGN(bdata->last_success, step);
+ fallback = start; -------------------------------- (*)
+ start = ALIGN(bdata->last_success, step);
}
(*) is root cause. "fallback" is set as 0, because start is index of bitmap
at here. ...
| Jun 5, 1:31 am 2008 |
| Johannes Weiner | Re: [PATCH -mm 11/14] bootmem: respect goal more likely
Hi,
Sorry, my fault.
How about last_offset -> last_end_off to reflect that it is the offset
of the last allocations end?
And last_succes -> hint_idx to reflect that it is an index we start
searching from but it is not strict and we fall back if we find nothing
starting from there. Also free_bootmem* sets it as a hint from where we
could start searching.
I also would set last_success/hint_idx to the _end_ of the successful
allocation (instead of the beginning of it) in ...
| Jun 4, 9:13 pm 2008 |
| Yasunori Goto | Re: [PATCH -mm 11/14] bootmem: respect goal more likely
Last_sidx is ok. But, last_offset seems to be used to manage some
allocated smaller chunks than one page. I'm not sure last_eidx is ok.
Bye.
--
Yasunori Goto
--
| Jun 4, 7:58 pm 2008 |
| Johannes Weiner | Re: [PATCH -mm 11/14] bootmem: respect goal more likely
Hi,
Ah, you got there too :-)
Here is the original Email I wrote but waited to send out until after I
slept:
---
Hi Yasunori,
here is hopefully the fix to your bootup problem. Let me explain:
This is the last but one bootmem allocation on your box:
Jun 5 11:50:43 localhost kernel: bootmem::alloc_bootmem_core nid=0 size=40000 [16 pages] align=80 goal=100000000 limit=0
Jun 5 11:50:43 localhost kernel: bootmem::__reserve nid=0 start=1020588 end=1020598 flags=1
(->last_success ...
| Jun 5, 9:41 am 2008 |
| Jörn | Re: [PATCH] console - Add configurable support for conso ...
Even that blows. People all too easily forget about the end-to-end
principle. If you want a system that scales well, you have to push as
much work as possible to the ends and do as little as possible in the
center. Applies here as well as in networking.
If CELF funds 20 people to do such tests, they may be able to cope
today. But the stream of developers keeps swelling, so even those 20
won't be able to cope long-term. Instead we have to enable everyone in
the stream of developers to ...
| Jun 4, 11:55 pm 2008 |
| Uwe Klein | Re: [PATCH] console - Add configurable support for conso ...
Adrian Bunk wrote:
> I'm coming more from the point that drivers/media/ might be the area
> in the kernel that currently offers the biggest flexibility - and this
> stuff breaks multiple times for each kernel release, and sorting this
> out is often nontrivial.
Only partially connected:
I have run into trouble in conjunction with the rtai patches
and the no_console option regularly over a couple of years.
compiling is ok linking breaks on afair on ?*pcspeaker*?
and some other symbols. ...
| Jun 5, 12:18 am 2008 |
| Masami Hiramatsu | Re: Kernel marker has no performance impact on ia64.
Hi Peter and Mathieu,
If so, I'd like to suggest below changes,
- introduce below macro in marker.h
#define DEFINE_TRACE(name, vargs, args...) \
static inline void trace_##name vargs \
{ \
trace_mark(name, #vargs, ##args); \
}
- remove __marker_check_format from __trace_mark
- and write a definition in sched_trace.h
DEFINE_TRACE(sched_switch, (struct task_struct *prev, struct task_struct *next),
prev, next);
Thus, we can remove fmt string and also ensure the type ...
| Jun 5, 7:28 am 2008 |
| Peter Zijlstra | Re: Kernel marker has no performance impact on ia64.
Advantage of my method would be that ftrace (and othertracer) can use
I'm not sure - it seems to me it should be part of the tracer because
its a detail/subset of the actual data - rendering it useless for others
So s-tap is meant to parse this sting and interpret the varargs without
being closely tied to the kernel? - Somehow that doesn't make me feel
warm and fuzzy. That not only ties userspace to the information present
in the marker, but to the actual string as well.
The stronger you ...
| Jun 5, 1:12 am 2008 |
| Ben Collins | Re: [PATCH] FIx crash in mmc_block on 64-bit
Not sure how I missed the signed-off-by, but resent to Linus with your
ack. Thanks
--
| Jun 5, 4:11 pm 2008 |
| Pierre Ossman | Re: [PATCH] FIx crash in mmc_block on 64-bit
On Mon, 02 Jun 2008 13:39:19 -0400
A signed-off-by to make things nice and proper, please. :)
You can add an Acked-by: Pierre Ossman <drzeus@drzeus.cx> and pass it
on directly to Linus.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org
--
| Jun 5, 2:25 pm 2008 |
| Sam Ravnborg | Re: [PATCH] kbuild: simplify module versioning procedure
Hi Peter.
It looks like a simplification but there is actually a reason why
it is done with a temporary fil in this way.
Consider a kernel build that is being terminated with ctrl-c
in the middle. If we when ctrl-c are hit are doing the final
steps of genksyms then we will next time we type make
consider all done and we will not redo the modversioning
part of the rule because we have an updated .o file.
We have this issue in other places in the build system but
I have not audited the use ...
| Jun 5, 5:17 am 2008 |
| Andrew Morton | Re: [PATCH 1/5] jbd: strictly check for write errors on ...
Sigh. An object lesson in the value of good changelogging :(
I guess we need to undo this. And yes, propagating errors into AS_EIO
is the way. I guess that's safe without holding lock_page(), as long
as the bh is pinned.
--
| Jun 5, 9:20 am 2008 |
| Hidehiro Kawai | Re: [PATCH 1/5] jbd: strictly check for write errors on ...
My patch doesn't change the policy. JBD aborts the journal when
it detects I/O error in file data since 2.6.11. Perhaps this patch:
http://marc.info/?l=linux-kernel&m=110483888632225
I agree. I understood that there is a case where we don't want to
make the fs read-only when writing file data failed. OTOH there are
people who want to make the fs read-only to avoid the damage from
expanding. Introducing the tunable would be better.
I'm going to send a patch to make this behavior tunable ...
| Jun 5, 4:33 am 2008 |
| Theodore Tso | Re: [PATCH 1/5] jbd: strictly check for write errors on ...
Looking at the code paths touched by patch you referenced, you are
correct. And Andrew even signed off on it. :-)
But if someone was only examining the patch, it wasn't obvious that
the journal was getting aborted when the JBD layer was forcing buffers
from t_sync_datalist to disk. So I suspect the change went in without
proper consideration of the net effect. You just called it out
explicitly in the subject line, which caused Andrew to ask some good
Note that doing this right may be ...
| Jun 5, 7:29 am 2008 |
| Mike Snitzer | Re: [PATCH 1/5] jbd: strictly check for write errors on ...
I'm not completely sure which "it" you mean in "it is the default
today" (seems like you mean errors=continue) but isn't remount-ro
already the ext3 default?
see commit: 1eca93f9cafdec4a332ace9b0fc0d3886d430c28
--
| Jun 4, 8:28 pm 2008 |
| Andreas Dilger | Re: [PATCH 1/5] jbd: strictly check for write errors on ...
Something like the following instead if -EIO and journal abort:
if (!buffer_uptodate(bh)) {
set_bit(AS_EIO, &bh->b_page->mapping->flags);
SetPageError(bh->b_page);
}
It seems end_buffer_async_write() does this already, but
journal_do_submit_data() uses end_buffer_write_sync() and it does not
do either of those operations.
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
--
| Jun 5, 11:49 am 2008 |
| Jan Kara | Re: [PATCH 1/5] jbd: strictly check for write errors on ...
OK, you've convinced me that aborting journal because of EIO on data
block isn't the best thing to do. But it is a bit problematic to return EIO
to userspace - we usually find this in commit code so we work on behalf of
kjournald and user already thinks the write has succeeded (which is
basically problem of any cached write). So the best thing we can do is set
AS_EIO on the mapping and hope userspace will notice (we report such error
when user does fsync/sync/sync_file_range).
Sending some ...
| Jun 5, 2:35 am 2008 |
| David Howells | Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB, v2.
With this patch, SLOB now works on my FRV board.
Acked-by: David Howells <dhowells@redhat.com>
--
| Jun 5, 9:26 am 2008 |
| Zhang, Yanmin | Re: [Bug #10638] sysbench+mysql(oltp, readonly) 30% regr ...
One difference between volanoMark and hackbench is cpu context switch.
cpu context switch looks stable when I run volanoMark, but dones't look
stable with hackbench.
running queue is another difference. With volanoMark, running queue is quite stable.
I tested it by #hackbench process 2000 with/without schedtool.
If I don't kill most background processes (services), the result is still not stable.
If I kill background processes, the fluctuation is within 0.5 seconds
with or without ...
| Jun 4, 7:34 pm 2008 |
| Peter Zijlstra | Re: Inquiry: Should we remove "isolcpus= kernel boot opt ...
Mapping them onto U64_MAX - prio or something like that ought to do.
Handling wraparound of the timeline might get a little involved though -
I'd start with something like:
u64 sched_param::edf_period [ns]
u64 sched_param::edf_runtime [ns]
so that deadline = time_of_schedule + edf_period, and his allowance
within that period is edf_runtime.
fork would inherit the parent's settings, and we'd need to do admission
control on all tasks entering SCHED_EDF, either through ...
| Jun 5, 5:07 am 2008 |
| Mark Hounschell | Re: Inquiry: Should we remove "isolcpus= kernel boot opt ...
Thanks for the detailed tutorial Max. I'm personally still very
skeptical. I really don't believe you'll ever be able to run multiple
_demanding_ RT environments on the same machine. Now matter how many
processors you've got. But even though I might be wrong there, thats
actually OK with me. I, and I'm sure most, don't have a problem with
dedicating a machine to a single RT env.
You've got to hold your tongue just right, look at the right spot on the
wall, and be running the RT patched ...
| Jun 5, 4:44 am 2008 |
| Michael Trimarchi | Re: Inquiry: Should we remove "isolcpus= kernel boot opt ...
This is what I'm doing right now (apart from using timespec structs
instead of u64 values to align the sched_param struct specified by
POSIX on systems with SCHED_SPORADIC support).
Ok, using the same mechanism even for SCHED_EDF tasks seems the
There is some work in this area, and there are some protocols
handling that, but that simple solution will be a good starting
point.
--
| Jun 5, 7:57 am 2008 |
| Michael Trimarchi | Re: Inquiry: Should we remove "isolcpus= kernel boot opt ...
I add this type of class before sched_rt, so the next of sched_edf
I think it can be done with an rb tree. The only tricky
By now I'm facing some problems. I still have not clear what parameters a task forked from a sched_edf task should get, as it would involve some form of admission control, and how to deal with tasks that run longer than their nominal execution time (i.e., should we use some server mechanism to limit the amount of cpu they're using, or handle that in some other ...
| Jun 5, 4:16 am 2008 |
| Bjorn Helgaas | Re: 53052feb6 (PNP: remove pnp_mem_flags() as an lvalue) ...
I just sent Linus the patch to fix this (below).
In Linus' current tree, PNP_MAX_MEM is 24, so I would expect that
you would see 24 iomem messages (either successful or unsuccessful
reservations) for each system device (PNP0C01 or PNP0C02).
Hmm... the other report (on LKML) was for "iomem range 0x0-0x0
could not be reserved", while your messages were for successful
reservations. I don't know why they're different. But I think
this patch should fix both.
PNP: skip UNSET MEM ...
| Jun 5, 9:18 am 2008 |
| Chris Wright | Re: kvm: unable to handle kernel NULL pointer dereference
Sorry, my math was bad. I gave you 0xffffffff8021d44f + 7 + 0x6f9cba,
but it should have been 0xffffffff8021d44f - 17 + 0x6f9cba. Which is
correct (as one would hope, it was a grasp at straws).
Oh, wait. Is this a laptop? Do you suspend/resume? Suspend will free
svm_data, and on resume, any launching a guest will definitely hit the
oops you are seeing.
Do you ever see this in dmesg?
svm_cpu_init: svm_data is NULL on 0
thanks,
chris
--
| Jun 5, 12:27 am 2008 |
| Tobias Diedrich | Re: kvm: unable to handle kernel NULL pointer dereference
No, this is my desktop, but I hibernate daily and always see below
Yes:
[...]
PM: Creating hibernation image:
PM: Need to copy 126181 pages
PM: Normal pages needed: 126181 + 1024 + 38, available pages: 397721
x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106
svm_cpu_init: svm_data is NULL on 0
[...]
--
Tobias PGP: http://9ac7e0bc.uguu.de
このメールは十割再利用されたビットで作られています。
--
| Jun 5, 11:28 am 2008 |
| Tobias Diedrich | Re: kvm: unable to handle kernel NULL pointer dereference
Almost:
ranma@melchior:~/src/linux-2.6.26-rc4.forcedwol$ gdb -q vmlinux
Using host libthread_db library "/lib/libthread_db.so.1".
(gdb) p/x 0xffffffff8021d456 + 0x6f9cba
$1 = 0xffffffff80917110
(gdb) p/x &per_cpu__svm_data
$2 = 0xffffffff809170f8
HTH,
--
Tobias PGP: http://9ac7e0bc.uguu.de
このメールは十割再利用されたビットで作られています。
--
| Jun 4, 11:09 pm 2008 |
| Chris Wright | Re: kvm: unable to handle kernel NULL pointer dereference
Odd, svm_data is NULL, so svm_data->asid_generation is oopsing.
static void pre_svm_run(struct vcpu_svm *svm)
{
int cpu = raw_smp_processor_id();
struct svm_cpu_data *svm_data = per_cpu(svm_data, cpu);
svm->vmcb->control.tlb_ctl = TLB_CONTROL_DO_NOTHING;
if (svm->vcpu.cpu != cpu ||
svm->asid_generation != svm_data->asid_generation) <--- here <---
new_asid(svm, svm_data);
}
Doesn't really make any sense to find svm_data == NULL, since it's
allocated ...
| Jun 4, 9:25 pm 2008 |
| Chris Wright | Re: kvm: unable to handle kernel NULL pointer dereference
Yeah, this is broken. What happens is:
suspend:
hardware_disable
svm_hardware_disable
kfree(svm_data)
per_cpu(svm_data) = NULL
resume:
hardware_enable
svm_hardware_enable
if(!svm_data) printk("svm_cpu_init: svm_data is NULL on 0")
at this point it is broken.
Same would happen on an SMP box by simply doing offline/online of a CPU.
This is definitely busted, looking into a patch.
thanks,
-chris
--
| Jun 5, 11:34 am 2008 |
| Jarod Wilson | Re: [PATCH] firewire: fw-ohci: disable PHY packet recept ...
Good catch.
Signed-off-by: Jarod Wilson <jwilson@redhat.com>
--
Jarod Wilson
jwilson@redhat.com
--
| Jun 5, 12:10 pm 2008 |
| Jarod Wilson | Re: [PATCH] firewire: fw-ohci: write selfIDBufferPtr bef ...
I vaguely recall discussing this one before. Doesn't seem to have caused any
problems in practice, but yeah, should go ahead and be more spec compliant
here.
Signed-off-by: Jarod Wilson <jwilson@redhat.com>
--
Jarod Wilson
jwilson@redhat.com
--
| Jun 5, 12:13 pm 2008 |
| Stefan Richter | [PATCH] firewire: fw-ohci: disable PHY packet reception ...
We want the rcvPhyPkt bit in LinkControl off before we start using the
chip. However, the spec says that the reset value of it is undefined.
Hence switch it explicitly off.
https://bugzilla.redhat.com/show_bug.cgi?id=244576#c48 shows that for
example the nForce2 integrated FireWire controller seems to have it on
by default.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
Supersedes patch "fw-ohci: clear LinkControl register when enabling the
chip". Changed from ~0 to ...
| Jun 5, 11:49 am 2008 |
| Stefan Richter | [PATCH] firewire: fw-ohci: write selfIDBufferPtr before ...
OHCI 1.1 clause 5.10 requires that selfIDBufferPtr is valid when a 1 is
written into LinkControl.rcvSelfID.
This driver bug has so far not been known to cause harm because most
chips obviously accept a later selfIDBufferPtr write.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
drivers/firewire/fw-ohci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/firewire/fw-ohci.c
===================================================================
--- ...
| Jun 5, 11:50 am 2008 |
| Rafael J. Wysocki | Re: [Bug #10822] sky2 oops in 2.6.26-rc3
Dropped from the list of recent regressions.
Thanks,
Rafael
--
| Jun 5, 1:54 pm 2008 |
| Rafael J. Wysocki | Re: [Bug #10634] volanoMark regression with kernel 2.6.26-rc1
Thanks, closed.
Rafael
--
| Jun 5, 2:11 pm 2008 |
| Rafael J. Wysocki | Re: [Bug #10648] CONFIG_PRINTK_TIME broken on git HEAD ?
Thanks, closed.
Rafael
--
| Jun 5, 2:11 pm 2008 |
| Henrique de Moraes H ... | Re: [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection S ...
I think he means power down the g-sensors and related filters and A/D
circuitry. The out-of-tree version of the HDAPS driver can do it as
well.
For what is it worth, I think drivers/accel is a good idea, and I think
the other accel drivers should be moved there.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
--
| Jun 4, 6:06 pm 2008 |
| Pau Oliva Fora | Re: [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data ...
From: Pau Oliva Fora <pau@eslack.org>
Add support for HTC Shift UMPC G-Sensor LIS3LV02DL accelerometer.
Signed-off-by: Pau Oliva Fora <pau@eslack.org>
---
Here's an i2c version of the driver for the LIS3LV02DL accelerometer,
please try to combine it too, so we'll end up having ACPI, SPI and I2C.
Patch against linux-2.6.26-rc5, should apply clean on other versions too.
diff -uprN linux-2.6.26-rc5/drivers/input/joystick/htcgsensor.c linux/drivers/input/joystick/htcgsensor.c
--- ...
| Jun 5, 3:27 pm 2008 |
| Riku Voipio | Re: [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data ...
These chips are connected to either I2C or SPI - This is the 4th driver for
(apparently) these same chips:
http://docwiki.gumstix.org/Lis3lv02dq_spi.c
http://svn.openmoko.org/branches/src/target/kernel/2.6.24.x/patches/lis302dl.patch
Perhaps it would make more sense implement support for SPI
bus on the laptop and use the SPI interface directly instead or
--
| Jun 5, 12:43 am 2008 |
| Jonathan Cameron | Re: [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data ...
The upshot of the discussion Jean referenced was that the there were a
number of other devices / sensors that will form part of the same system.
For an initial bash I'm throwing in a couple of accelerometers, ADC's and
probably one or two other sensors as well. Haven't come up with a good
name as yet, but the point is that accelerometers would be just part of
the relevant subsystem.
Based on one suggestion (and current layout in my source tree), ...
| Jun 5, 2:38 am 2008 |
| Éric Piel | Re: [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data ...
Great to hear that you have started the new subsystem!
It's also nice that you are still hesitant about the name because
"industrialio" sounds for me too... let's say... industrial ;-) For
accelerometers found in laptops and mobile phones, it will sound strange
(although a name is just a name). Maybe "physicsio" (physics as "the
Yes, so I'll keep my plan of first submitting the driver with the
current interface, and latter updating the interface to the new
subsystem when you have stabilised its ...
| Jun 5, 1:34 pm 2008 |
| Jean Delvare | Re: [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection S ...
Well, I would expect all these accelerometer drivers to have a common,
standardized interface, so this should most probably become a real
I am in favor of it.
--
Jean Delvare
--
| Jun 4, 11:29 pm 2008 |
| Pavel Machek | Re: [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection S ...
Agreed.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
| Jun 5, 1:19 am 2008 |
| Jean Delvare | Re: [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection S ...
Hi Eric,
There are already other drivers in this case:
drivers/thermal/thermal_sys.c, drivers/misc/eeepc-laptop.c,
drivers/misc/thinkpad_acpi.c and drivers/input/touchscreen/ads7846.c.
All these drivers have multiple functions, one of them is hardware
monitoring but that's not the main one, so they didn't go under
drivers/hwmon. The applesmc driver would simply be one more driver in
this case.
Note that drivers/mfd is a possible alternative to drivers/misc for
I'm fine with moving the ...
| Jun 4, 11:27 pm 2008 |
| Andrew Morton | Re: [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection S ...
Patch looks reasonable, although my head's spinning a bit over the
Beware that the version becomes essentially meaningless once the code
is merged into mainline. It cannot be used to identify the exact
source code which a user is running - this is done via the main kernel
version instead.
All these comments you have sort-of look like kerneldoc only they aren't.
I suggest that either they be converted to kerneldoc or the /** and
This wakes up every 30 milliseconds which will make ...
| Jun 4, 10:17 pm 2008 |
| Eric Piel | Re: [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data ...
Hi!
Thanks a lot for these links (which I was not aware of). They indeed
seem to handle the same hardware (all via spi). To be even more
complete, here is a link we received off-list for accessing the same
hardware via I²C:
http://pof.eslack.org/HTC/shift/i2c-gsensor.tar.gz
Getting rid of ACPI could be nice, as it tends to be rather slow.
However, so far we've stick to it because it ensures that for the ~15
different models of HP laptop, we can access the hardware exactly the
same way. ...
| Jun 5, 1:28 am 2008 |
| Roland Dreier | Re: howto use ioremap_wc?
This thread reminds me of another question about interfaces for using
PAT. Are there any plans for making pgprot_writecombine() a generic
interface that portable drivers can use to map PCI memory into userspace
with WC turned on? (Falling back to uncached when WC is not available
for whatever reason is fine for the case I have in mind)
Maybe it's better to ask at a higher level: what's the right thing for a
driver to do in an mmap method when it wants to expose PCI memory to
userspace with WC ...
| Jun 4, 9:53 pm 2008 |
| Nick Piggin | Re: [PATCH 0/3] 64-bit futexes: Intro
Well, I should qualify that: it doesn't actually break my algorithm
because you can still implement the unlock without atomic RMWs.
This may require you to have an mfence there, but we can still get
away without atomics (whether that's much cheaper or not, I haven't
measured recently!)
--
| Jun 4, 6:58 pm 2008 |
| Linus Torvalds | Re: [PATCH 0/3] 64-bit futexes: Intro
That's _one_ possible implementation.
Quite frankly, I think it's the less likely one. It's much more likely
that the cache read access and the store buffer probe happen in parallel
(this is a really important hotpath for any CPU, but even more so x86
where there are more of loads and stores that are spills). And then the
store buffer logic would return the data and a bytemask mask (where the
mask would be all zeroes for a miss), and the returned value is just the
You'd have to ...
| Jun 4, 8:08 pm 2008 |
| Nick Piggin | Re: [PATCH 0/3] 64-bit futexes: Intro
I see what you're saying, but I hadn't really considered it before.
Not that I've attempted to do much of these sub-word operations
without consulting you first (which brings us here) ;).
I'd have thought that for a case like this, you'd simply hit the store
alias logic and store forwarding would stall because it doesn't have
the full data.
I'd like to know for sure.
The other thing that could be possible, and I'd imagine maybe more likely
to be implemented in a real CPU because it ...
| Jun 4, 6:56 pm 2008 |
| Nick Piggin | Re: [PATCH 0/3] 64-bit futexes: Intro
I'd be very surprised if that was the case. But the unlock code needn't
do that anyway. It could do
movb reg,(byteptr) # clear PG_locked
movb (byteptr+1),reg # load PG_waiters
--
| Jun 4, 6:45 pm 2008 |
| Nick Piggin | Re: [PATCH 0/3] 64-bit futexes: Intro
Well, it would just be nice to hear a "no we'll never do that", "we
Well I have a simple test case to show loads pass earlier non conflicting
stores in the case that loads do not come from the store buffer (ie.
*inter* processor forwarding).
And store forwarding, by definition means that the load can complete before
the store can possibly be visible to another CPU I'd say. So yes, I'm
sure this does happen too.
--
| Jun 4, 9:29 pm 2008 |
| Dave Jones | Re: via agp patches
On Sat, May 31, 2008 at 10:41:13AM -0700, Greg KH wrote:
> On Sat, May 31, 2008 at 10:47:15AM -0400, Dave Jones wrote:
> > On Fri, May 30, 2008 at 05:32:50PM -0700, Greg KH wrote:
> > >
> > > Looks like this adds a new device id, I have no idea why they remove
> > > another one at the same time...
> >
> > I sent a patch adding the missing ident to airlied a few weeks back.
> > I think it's currently in -mm.
>
> Great.
>
> > The removal of the other id is a mystery to me.
...
| Jun 5, 10:45 am 2008 |
| Armin Schindler | Re: [PATCH] isdn divas: fix proc creation
I don't know where you found this. I have look even in older versions, but
the pointer divas_proc_entry is set by proc_create(). The patch to
divasproc.c is wrong, it exists from the beginning of the driver.
Agreed here. The reason for doing remove_divas_proc() anyway, was to
make sure all possible settings done in !create_divas_proc() are
reverted. But since nothing else is done here, it is okay to remove it.
--
| Jun 5, 3:25 am 2008 |
| Rusty Russell | Re: [patch 02/41] cpu alloc: The allocator
[Empty message]
| Jun 5, 4:48 pm 2008 |
| Rusty Russell | Re: [patch 04/41] cpu ops: Core piece for generic atomic ...
Yes. Because the only true per-cpu vars are the static ones, cpu_local_inc()
only works on identifiers, not arbitrary pointers. Once this is fixed, we
should be enhancing the infrastructure to allow that (AFAICT it's not too
Yes, this should be fixed. I thought i386 had optimized versions pre-merge,
but I was wrong (%gs for per-cpu came later, and noone cleaned up these naive
versions). Did you want me to write them?
I actually think that using local_t == atomic_t is better than ...
| Jun 5, 4:59 pm 2008 |
| Haavard Skinnemoen | Re: [patch 2.6.26-rc4] add HAVE_CLK to Kconfig, for driv ...
Great idea! This will allow us to clean up some of the dependency mess
in the shared AVR32/AT91 drivers and get better compile-testing
coverage.
Acked-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
--
| Jun 5, 6:54 am 2008 |
| Paul Jackson | Re: [PATCH] genirq: Expose default irq affinity mask (take 3)
If the acked-by comes fairly shortly after the original
patch, and isn't excessively buried in a bunch of discussion,
then Andrew will catch it, and add it to the patch in his
queue.
If you have to resubmit the patch anyway, then of course,
add the acked-by then.
If neither of the above applies, and the acked-by is lost,
but your patch is successfully applied anyway, then either of
(1) if you're feeling lazy, don't worry about it, or
(2) reply again to that lkml thread, being sure ...
| Jun 5, 12:25 pm 2008 |
| Chris Wright | Jun 4, 6:06 pm 2008 | |
| Jeff Dike | Re: [BUG] Linux 2.6.25.4 task_struct leak
I misunderstood - I thought you were seeing a task_struct leak within
Yes, it does. I don't see the flags causing a leak, though. What
might be more likely (although I really have no idea) is ptrace.
Possibly a reference is held when it should have been dropped. This
might also show up with strace or gdb.
Jeff
--
Work email - jdike at linux dot intel dot com
--
| Jun 4, 5:49 pm 2008 |
| Gross, Mark | RE: [PATCH 1/2] Eliminate double kfree
ACK.
Thanks,
--mgross
--
| Jun 5, 3:32 pm 2008 |
| Jesse Barnes | Re: [PATCH 1/2] Eliminate double kfree
Thanks Julia, I'll put this in linux-next.
Jesse
--
| Jun 5, 1:58 pm 2008 |
| Jan Engelhardt | Re: Pipe buffers' limit of 16 * 4K
Can you merge it?
--
| Jun 5, 2:55 am 2008 |
| Maciej W. Rozycki | Re: [PATCH 8/8] x86: I/O APIC: Timer through 8259A secon ...
It seems wrong to me to set timer_through_8259 in apic_{32,64}.c -- can I
get .config for this setup as well as the bootstrap log? Why is the 8259A
needed here to supply the timer interrupt? It shouldn't be needed except
as arranged in check_timer() -- elsewhere the corresponding I/O APIC input
is not set up correctly.
Note I have chosen the default value of timer_through_8259 deliberately
to trigger dodgy cases like this ;) so that they can be investigated.
Maciej
--
| Jun 5, 7:55 am 2008 |
| Maciej W. Rozycki | Re: [PATCH 8/8] x86: I/O APIC: Timer through 8259A secon ...
I can reproduce the hang, except with a slightly different options. I
have spotted the places where the watchdog is set up incorrectly. I shall
post fixes shortly, once I have got them polished and tested. Feel free
to throw them at your qemu.
Also it's worth noting there's more breakage of the NMI watchdog for this
configuration ("maxcpus=1 noapic") -- it fails to tick on the CPU #0 on my
system for some reason, but that's well beyond the scope of this series,
so I am not going to look ...
| Jun 5, 12:47 pm 2008 |
| Ingo Molnar | Re: [PATCH 8/8] x86: I/O APIC: Timer through 8259A secon ...
Maciej,
-tip testing found an IO-APIC related hang, and i bisected it down to
the problem below. What do you think about my solution? Another option
would be to add the lapic as a clockevent device in the failure path.
(since we know the NMI watchdog wont work)
Ingo
------------>
Subject: x86, io-apic: fix nmi_watchdog=1 bootup hang
From: Ingo Molnar <mingo@elte.hu>
nmi_watchdog=1 hangs on 64-bit:
[ 0.250000] Detected 12.564 MHz APIC timer.
[ 0.254178] APIC timer ...
| Jun 5, 2:19 am 2008 |
| Ingo Molnar | Re: [PATCH 8/8] x86: I/O APIC: Timer through 8259A secon ...
find them here:
http://redhat.com/~mingo/misc/config-Thu_Jun__5_16_40_50_CEST_2008.bad
http://redhat.com/~mingo/misc/log-Thu_Jun__5_16_40_50_CEST_2008.bad
NOTE: you need to copy out and use the boot parameters from the boot
log:
[ 0.000000] Command line: root=/dev/sda6 console=ttyS0,115200
earlyprintk=se rial,ttyS0,115200 debug initcall_debug apic=verbose
sysrq_always_enabled ignore _loglevel selinux=0 nmi_watchdog=1
profile=0 maxcpus=1 nosmp no_hz=off highres =0 noapic ...
| Jun 5, 8:03 am 2008 |
| Cyrill Gorcunov | Re: [PATCH 8/8] x86: I/O APIC: Timer through 8259A secon ...
[Maciej W. Rozycki - Thu, Jun 05, 2008 at 07:33:04PM +0100]
| On Thu, 5 Jun 2008, Ingo Molnar wrote:
|
| > NOTE: you need to copy out and use the boot parameters from the boot
| > log:
| >
| > [ 0.000000] Command line: root=/dev/sda6 console=ttyS0,115200
| > earlyprintk=se rial,ttyS0,115200 debug initcall_debug apic=verbose
| > sysrq_always_enabled ignore _loglevel selinux=0 nmi_watchdog=1
| > profile=0 maxcpus=1 nosmp no_hz=off highres =0 noapic nolapic_timer
| > hpet=disable ...
| Jun 5, 11:52 am 2008 |
| Maciej W. Rozycki | Re: [PATCH 8/8] x86: I/O APIC: Timer through 8259A secon ...
Thanks. I figured out I cannot build an x86-64 kernel, because my i386
compiler does not support the target. Probably because of target library
dependencies at the time I built my compiler. I would have to build a
bare-iron cross-compiler for the x86-64 which I'd rather not to just to
fix this small problem -- it usually takes a few days to sort out all the
pesky details when doing such a build from scratch, so it better be well
justified.
However, the reason is quite clear to me -- the ...
| Jun 5, 11:33 am 2008 |
| Cyrill Gorcunov | Re: [PATCH 8/8] x86: I/O APIC: Timer through 8259A secon ...
[Maciej W. Rozycki - Thu, Jun 05, 2008 at 07:33:04PM +0100]
| On Thu, 5 Jun 2008, Ingo Molnar wrote:
|
| > NOTE: you need to copy out and use the boot parameters from the boot
| > log:
| >
| > [ 0.000000] Command line: root=/dev/sda6 console=ttyS0,115200
| > earlyprintk=se rial,ttyS0,115200 debug initcall_debug apic=verbose
| > sysrq_always_enabled ignore _loglevel selinux=0 nmi_watchdog=1
| > profile=0 maxcpus=1 nosmp no_hz=off highres =0 noapic nolapic_timer
| > hpet=disable ...
| Jun 5, 12:00 pm 2008 |
| Ian Kent | Re: Linux 2.6.26-rc4
Here is a patch for autofs4 to, hopefully, resolve this.
Keep in mind this doesn't address any other autofs4 issues but I it
should allow us to identify if this was in fact the root cause of the
problem Jesper reported.
autofs4 - leave rehashed dentry positive
From: Ian Kent <raven@themaw.net>
Correct the error of making a positive dentry negative after it has been
instantiated.
This involves removing the code in autofs4_lookup_unhashed() that
makes the dentry negative and ...
| Jun 5, 12:31 am 2008 |
| Andrew Morton | Re: Linux 2.6.26-rc4
On Thu, 05 Jun 2008 15:31:37 +0800
OK, so here we work out that autofs4_init_ino() had to allocate a new
This all seems a bit ungainly. I assume that on entry to
autofs4_dir_symlink(), ino->size is equal to strlen(symname)? If it's
not, that strcpy() will overrun.
But if ino->size _is_ equal to strlen(symname) then why did we just
recalculate the same thing?
I'm suspecting we can zap a lump of code and just do
cp = kstrdup(symname, GFP_KERNEL);
This all looks very similar ...
| Jun 5, 3:30 pm 2008 |
| Jesper Krogh | Re: Linux 2.6.26-rc4
Yes, I'll apply it an report back. Dont expect anything before early
next week.
Jesper
--
Jesper
--
| Jun 5, 2:34 pm 2008 |
| Linus Torvalds | Re: Linux 2.6.26-rc4
Jesper, can you test this? I think you said you could trigger this in ~24
hours or so? I'd love to have some testing of some heavy autofs user. Even
if it's not a guarantee of a fix (due to reproducing the bug not being
entirely trivial), at least I'd like to know that it doesn't introduce any
obvious new problems either..
Linus
--
| Jun 5, 2:29 pm 2008 |
| Ingo Molnar | Re: [fixed] [patch] Re: [bug] stuck localhost TCP connec ...
i unapplied the reverts then applied your fix, and got this hang after
1.5 hours of testing:
titan:~> netstat -nt
Active Internet connections (w/o servers)
Proto Recv-Q Send-Q Local Address Foreign Address State
tcp 0 65032 10.0.1.14:39454 10.0.1.19:3632 ESTABLISHED
10.0.1.14 is this box, Core2Duo dual-core. 10.0.1.19 is another box with
16 CPUs.
Ingo
--
| Jun 5, 7:22 am 2008 |
| Ilpo Järvinen | Jun 5, 11:00 am 2008 | |
| Ilpo Järvinen | Re: [fixed] [patch] Re: [bug] stuck localhost TCP connec ...
On Thu, 5 Jun 2008, Ilpo J
| Jun 5, 2:13 pm 2008 |
| Patrick McManus | Re: [fixed] [patch] Re: [bug] stuck localhost TCP connec ...
Sorry, I don't see anything - it seems to boil down to the same code in
the DA and non-DA case as far as I can tell, but after a while all the
twisty passages seem to look alike.
If Ingo confirms that the recv end was running the locking patch code,
it would be interesting to just confirm the sysreq+t looks the same as
before - it is possible the patch turned the race into a non-obvious
deadlock.
I'm sure your smaller revert will make the problem go away just as the
larger one did, fwiw. ...
| Jun 5, 4:29 pm 2008 |
| Martin Michlmayr | Re: mips/kernel/traps.c build error
It's still not in mainline as of rc5.
--
Martin Michlmayr
http://www.cyrius.com/
--
| Jun 5, 4:57 am 2008 |
| Andrea Righi | Re: [PATCH 1/3] Add io-throttle controller documentation
[snip]
Thanks for reviewing the documentation Randy. I'll apply your fixes to
the next version of the patch.
-Andrea
--
| Jun 5, 5:36 am 2008 |
| Pierre Ossman | Re: [RFC PATCH 1/2] mmc_spi: export probe and remove functions
On Mon, 2 Jun 2008 16:53:37 +0400
I'm not necessarily against that idea. What I don't like is using a
function for different things. So you'd need to restructure things a
platform_get_attr("ocr") perhaps? I'm afraid I have not dealt enough
with the embedded parts of the kernel to give a complete suggestion as
to how this might be solved.
My concern is building something OF specific right now, only to have to
restructure things when the next firmware interface shows up and having
to deal ...
| Jun 5, 2:16 pm 2008 |
| Arnd Bergmann | Re: [RFC PATCH] fs code: Push the BKL down into the file ...
Ok, I tried that, and it mostly worked fine. I have a patch
now that converts all block drivers to use unlocked_ioctl,
and, where appropriate, compat_ioctl.
I tried changing the prototype from
long (*unlocked_ioctl) (struct file *file, unsigned, unsigned long);
to
int (*unlocked_ioctl) (block_device *bdev, unsigned, unsigned long);
There are two problems with removing the file argument:
* A handful of drivers use file->f_mode to check for permissions.
Obviously, this needs to ...
| Jun 5, 1:59 am 2008 |
| Ankita Garg | Re: [ANNOUNCE] sched: schedtop utility
Hi,
Thanks Peter for the explanation...
I agree with the above and that is the reason why I did not see weird
values with cpu_time. But, run_delay still would suffer skews as the end
points for delta could be taken on different cpus due to migration (more
so on RT kernel due to the push-pull operations). With the below patch,
I could not reproduce the issue I had seen earlier. After every dequeue,
we take the delta and start wait measurements from zero when moved to a
different rq.
...
| Jun 4, 10:20 pm 2008 |
| Luming Yu | Jun 4, 6:49 pm 2008 | |
| Petr Tesarik | Re: [RFC PATCH] set TASK_TRACED before arch_ptrace code ...
Hm, I think without utrace, it gets out-of-sync once, so syscall entries
and exits are swapped from that point on. With utrace, it gets
out-of-sync _twice_, so it eventually looks fine. But the strace output
definitely looks incorrect even with utrace:
5718 execve("./test2.sh", [], [/* 23 vars */]) = 1
5718 execve("", [0x840c001000100003, 0x26230c14203032, 0x8cb0008800140a81, 0xa643100801808402, 0x2400905000040088, 0x11600a0072000001, 0xad814a00402e0, 0x2200012464009344, 0x1180418512c40026, ...
| Jun 5, 4:16 am 2008 |
| Benjamin Herrenschmidt | Re: MMIO and gcc re-ordering issue
Note that the powerpc implementation currently clears the flag
on spin_lock and tests it on unlock. We are considering changing
that to not touch the flag on spin_lock and just clear it whenever
we do a sync (ie, on unlock, on explicit mmiowb, and possibly even
on readl's where we happen to do sync's).
Ben.
--
| Jun 5, 1:43 am 2008 |
| Jes Sorensen | Re: MMIO and gcc re-ordering issue
Hi Jesse,
I am going to take a stab at implementing this so we can see how much
of an impact it will have.
Cheers,
Jes
--
| Jun 5, 1:40 am 2008 |
| David Newall | Re: ASUS SplashTop and Phoenix Hyperspace infringing ker ...
Yet it is DeviceVM that distributes it to ASUS, so the GPL obligations
attach thereto.
--
| Jun 4, 7:55 pm 2008 |
| Alan Cox | Re: ASUS SplashTop and Phoenix Hyperspace infringing ker ...
Thst isn't a simple question and rather depends upon the contractual
arrangements don't you think ? If I offer to supply it by CD your
software will be delivered by the postal service, from whom you did not
buy the product.
A company might have liability for the failure of its agents to perform
Let me propose a different theory: ASUS thought a smaller 12MB download
It's a mini virtual machine using the cpu extensions. It really shouldn't
need any deeply magical kernel patches except maybe ...
| Jun 5, 1:54 am 2008 |
| Pierre Ossman | Re: [PATCH 0/9] au1xmmc updates #3
On Mon, 19 May 2008 10:03:39 +0200
The role of maintainer is vacant if you want it. *nudge* ;)
| Jun 5, 2:09 pm 2008 |
| Pierre Ossman | Re: [PATCH 9/9] au1xmmc: Add back PB1200/DB1200 MMC acti ...
On Mon, 19 May 2008 10:08:37 +0200
You might want to consider using the LED subsystem now that the MMC
core exports a trigger. Look at my next tree for how sdhci uses it.
Rgds
Pierre
| Jun 5, 2:08 pm 2008 |
| Pierre Ossman | Re: [PATCH 8/9] au1xmmc: abort requests early if no card ...
On Mon, 19 May 2008 10:08:04 +0200
You should use -ENOMEDIUM for this case.
Rgds
Pierre
| Jun 5, 2:05 pm 2008 |
| Pierre Ossman | Re: [PATCH 1/9] Alchemy: export get_au1x00_speed for modules
On Mon, 19 May 2008 11:49:53 +0200
So who should push this to Linus? If this set is the only patches
depending on it, it would be easiest if I carry it in my tree.
Rgds
Pierre
| Jun 5, 2:03 pm 2008 |
| David Brownell | Re: [PATCH 0/4] Fix forcedeth hibernate/wake-on-lan problems
I'm likewise "afraid" that may be too much to expect.
If that's true, it's going to be even harder making
the cross-platform Linux PM framework do what it needs
to do. Having various devices (not just laptop lids or
power buttons, or RTC alarms) wake systems from low power
states is pretty fundamental to the "P" part of ACPI.
I kind of think the ACPI team needs to just become more
responsive. They helped Windows do this stuff; why has
Linux only seen delays and obstacles in this ...
| Jun 4, 7:38 pm 2008 |
| Marc Pignat | Re: [PATCH 3/3] mmc: change .get_ro() callback semantics
Ack, we will gain at most 1-4 assembly instructions, in a function that
WARN_ON(ret > 0 && ret != 1 || ret == INT_MIN) will do ;)
I agree with you once more, I never thinked about a runtime check.
I don't really want to see a WARN_ON(foo) after each call to get_ro or get_cd.
But I'm sure if we specify "give me a positive value when a card is detected",
someone will write gpio & bit, and three years later, someone will fall in
the (gpio & lastbit < 0 case).
So we should specify: "give ...
| Jun 5, 8:58 am 2008 |
| Anton Vorontsov | Re: [PATCH 3/3] mmc: change .get_ro() callback semantics
This isn't always practical. For example, host is using u8 register for
the status, so it might safely return u8 & mask, that will always fit
into int. Or very smart/adventurous authors might be aware that, for the
particular host, mask's bit isn't last, and safely do uXX & mask. :-)
The above is weak argument of course, since it is about optimization.
As an counter-evidence, the strict scheme that you described probably
less error prone. But is it? To implement it we'll need something ...
| Jun 5, 7:43 am 2008 |
| Anton Vorontsov | [PATCH] mmc: toughen get_ro() and get_cd() return values
For the sake of safety, document that drivers should return only
1 or 0 from the get_ro() and get_cd() callbacks. Also document context
in which these callbacks should be executed.
wbsd driver modified to comply with this requirement.
Also, fix mmc_spi driver to not return raw values from the platform
get_cd hook (oops).
Suggested-by: Marc Pignat <marc.pignat@hevs.ch>
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
On Thu, Jun 05, 2008 at 05:58:59PM +0200, Marc Pignat ...
| Jun 5, 10:10 am 2008 |
| Jiri Kosina | Re: [PATCH 01/10] modpost: add support for hid
Jiri,
I have rebased the patch series on top of current state of the queued
patches in my tree and applied them to 'hidbus' branch of my tree. So you
can base any further respins of the patches on the version you can find in
this branch right now.
I have not yet pulled that branch into the branch that is pulled into -mm
and linux-next, there are some things that I think still need sorting out
-- I have sent you some feedback yesterday.
Thanks a lot,
--
Jiri Kosina
SUSE ...
| Jun 5, 2:26 am 2008 |
| Pavel Machek | Re: 2.6.25 -> 2.6.26-rc1: pcmcia flash card changed name ...
Sorry it took me so long...
Pavel
2.6.26-rc5: flash card is at /dev/hdc.
Linux version 2.6.26-rc5 (pavel@amd) (gcc version 4.1.3 20071209 (prerelease) (Debian 4.1.2-18)) #303 SMP Thu Jun 5 12:04:18 CEST 2008
PAT disabled. Not yet verified on this CPU type.
BIOS-provided physical RAM map:
BIOS-e820: 0000000000000000 - 000000000009f000 (usable)
BIOS-e820: 000000000009f000 - 00000000000a0000 (reserved)
BIOS-e820: 00000000000d2000 - 00000000000d4000 (reserved)
BIOS-e820: ...
| Jun 5, 3:21 am 2008 |
| Andrea Arcangeli | Re: [PATCH 001/001] mmu-notifier-core v17
Yes, actual removal is deferred until after mmu_notifier_release()
Thanks for the review Paul! I should also have added your precious
Acked-by to the 1/3 and 3/3 but the important is the ack by email ;)
--
| Jun 5, 9:51 am 2008 |
| Bart Van Assche | Re: Strange mptbase / mptscsih kernel messages
Hello Sathya,
It took some time before I could have a closer look at the system on
which I observed the strange kernel messages. Apparently the RAID
controller (LSISAS3081E ?) is not connected directly to the 16 disks
but via a SAS expander (Super Micro SC836 SAS Backplane with two LSI
SASX28 Expander Chips --
http://www.supermicro.com/products/chassis/3U/836/SC836E2-R800.cfm).
It will be a challenge to find out which component triggered the
kernel messages and how to make the storage ...
| Jun 5, 6:58 am 2008 |
| Stefan Richter | [PATCH regression fix] x86: fix CONFIG_NONPROMISC_DEVMEM ...
Here is an attempt to translate the prompt and help text into something
which is legible and, as a bonus, correct.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
Bogosity already reported on May 4.
Besides, AFAICT it is a security option, not a debug option, hence
misplaced in Kconfig.debug. It would be an actual debug option if the
logic was the inverse: PROMISC_DEVMEM, bool "Promiscuous /dev/mem".
arch/x86/Kconfig.debug | 20 ++++++++++++--------
1 file changed, 12 ...
| Jun 5, 1:37 pm 2008 |
| Stefan Richter | Re: [PATCH regression fix] x86: fix CONFIG_NONPROMISC_DE ...
Hmm, now "N" could be mistaken for "no access at all".
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
Here is an attempt to translate the prompt and help text into something
which is legible and, as a bonus, correct.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
arch/x86/Kconfig.debug | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
Index: ...
| Jun 5, 1:47 pm 2008 |
| Greg KH | Re: 2.6.25.1, stray noise in dmesg
I agree, I'll change the message to be this, thanks for the patch.
greg k-h
--
| Jun 5, 12:38 pm 2008 |
| Frans Pop | Re: 2.6.25.1, stray noise in dmesg
I'm going to bring this up one last time.
Google currently already shows 1060 hits for this new error:
http://www.google.com/search?q=%22unable+to+enumerate+USB+device%22&ie=UTF-8&o...
This one is particularly interesting as it shows quite a few systems
are affected: https://bugzilla.redhat.com/show_bug.cgi?id=446845
Given its apparent prevalence I'm still wondering whether this is
really broken hardware in all cases or that there could be an error
in detection in some cases.
Note ...
| Jun 5, 11:50 am 2008 |
| Paul E. McKenney | Re: 2.6.26-rc4: RIP __call_for_each_cic+0x20/0x50
Hence the CFQ code perhaps just an innocent bystander in the wrong place
at the wrong time. Fair enough!
Thanx, Paul
--
| Jun 4, 9:23 pm 2008 |
| Frank Ch. Eigler | Re: [PATCH 1/1] x86: fix text_poke
Linus, was it your intention to signal that you would veto any uses of
the current trace_mark mechanism, and wait for this hypothetical
function-recompilation-splicing widget as a replacement? This is how
some people are interpreting this old thread.
A number of problems with the new idea were brought up, and no one
appears to have taken interest in trying to build it to see if they
can be overcome or if there are more.
On the other hand, a number of concerns with the markers have ...
| Jun 5, 10:44 am 2008 |
| David Woodhouse | Re: [PATCH resend] Adding dummy release functions to avo ...
Do not taunt Happy Fun Dave.
--
dwmw2
--
| Jun 5, 9:31 am 2008 |
| Vitaliy Ivanov | [PATCH resend] Adding dummy release functions to avoid w ...
Hi all,
Natalie reported that patch wasn't accepted.
Please check this out. If I need to correct it somehow then pls let me know.
V.
---------- Forwarded message ----------
From: Vitaliy Ivanov <vitalivanov@gmail.com>
Date: Wed, Apr 16, 2008 at 3:34 AM
Subject: [PATCH] Adding dummy release functions to avoid warnings.
To: linux-kernel@vger.kernel.org, devzero@web.de, jsun@junsun.net,
dwmw2@infradead.org
Subject: [PATCH] Adding dummy release functions to avoid warnings.
From: ...
| Jun 5, 2:39 am 2008 |
| Vitaliy Ivanov | Re: [PATCH resend] Adding dummy release functions to avo ...
Andrew,
Damn. I knew that everything is not so easy here;) Got it. Tnx.
But in such case there are _again_ many drivers that do implement such
fake functions. Again is because when I tried to port some usb driver
there were issues with locking that was not correct but many drivers
worked exactly this incorrect way.
Anyway, tnx for clarifying this.
V.
--
| Jun 5, 9:32 am 2008 |
| Andrew Morton | Re: [PATCH resend] Adding dummy release functions to avo ...
Please see Documentation/kobject.txt - search for the text
I expect that
hgafb-convert-to-new-platform-driver-api-bugzilla-9689.patch which I
merged yesterday will help here.
--
| Jun 5, 9:07 am 2008 |
| Yan Li | Re: 2.6.24 Kernel Soft Lock Up with heavy I/O in dm-crypt
This patch actual has lead to performance _gain_.
Test Result, performance gain:
aes-cbc-essiv:sha256, keysize 128: 2.53%
aes-xts-plain, keysize 256: 0.26%
aes-xts-plain, keysize 512: 9.31%
Test kernel:
AMD64 2.6.24 from Debian Etch-and-a-half
Test command:
# dd if=/dev/zero of=/dev/mapper/open_device bs=500M count=100
This would write 50G zero data to an open LUKS raw device (no
filesystem overhead here), as 500M per block. This will stress mainly
the cryptographic and dm code, ...
| Jun 5, 3:44 pm 2008 |
| previous day | today | next day |
|---|---|---|
| June 4, 2008 | June 5, 2008 | June 6, 2008 |
